1
0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-11-29 07:58:28 +00:00

Don't emit a prompt in Eshell when a background command is killed

* lisp/eshell/esh-cmd.el (eshell-resume-command): Check for
background-ness before resetting the prompt.

* test/lisp/eshell/esh-cmd-tests.el
(esh-cmd-test/background/simple-command): Make the regexp a bit
stricter.
(esh-cmd-test/background/kill): New test.
This commit is contained in:
Jim Porter 2024-07-09 10:45:35 -07:00
parent ec1e300a21
commit 0de0056fd6
2 changed files with 22 additions and 3 deletions

View File

@ -1030,6 +1030,9 @@ process(es) in a cons cell like:
PROC is the process that invoked this from its sentinel, and
STATUS is its status."
(when proc
;; Iterate over all the commands associated with this process. Each
;; element is a list of the form (BACKGROUND FORM PROCESSES) (see
;; `eshell-add-command').
(dolist (command (eshell-commands-for-process proc))
(unless (seq-some #'eshell-process-active-p (nth 2 command))
(setf (nth 2 command) nil) ; Clear processes from command.
@ -1040,8 +1043,12 @@ STATUS is its status."
(not (string-match eshell-reset-signals status)))
(eshell-resume-eval command)
(eshell-remove-command command)
(declare-function eshell-reset "esh-mode" (&optional no-hooks))
(eshell-reset))))))
;; Check if the command we just aborted is marked as a
;; background command. If not, we need to reset the prompt so
;; the user can enter another command.
(unless (car command)
(declare-function eshell-reset "esh-mode" (&optional no-hooks))
(eshell-reset)))))))
(defun eshell-resume-eval (command)
"Destructively evaluate a COMMAND which may need to be deferred.

View File

@ -113,7 +113,7 @@ bug#59469."
(with-temp-eshell
(eshell-match-command-output
(format "*echo hi > #<%s> &" bufname)
(rx "[echo" (? ".exe") "] " (+ digit) "\n"))
(rx bos "[echo" (? ".exe") "] " (+ digit) "\n"))
(eshell-wait-for-subprocess t))
(should (equal (buffer-string) "hi\n"))))
@ -129,6 +129,18 @@ bug#59469."
(eshell-wait-for-subprocess t))
(should (equal (buffer-string) "olleh\n"))))
(ert-deftest esh-cmd-test/background/kill ()
"Make sure that a background command that gets killed doesn't emit a prompt."
(skip-unless (executable-find "sleep"))
(let ((background-message (rx bos "[sleep" (? ".exe") "] " (+ digit) "\n")))
(with-temp-eshell
(eshell-match-command-output "*sleep 10 &" background-message)
(kill-process (caar eshell-process-list))
(eshell-wait-for-subprocess t)
;; Ensure we didn't emit another prompt after killing the
;; background process.
(should (eshell-match-output background-message)))))
;; Lisp forms