mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-11-30 08:09:04 +00:00
Code Issues Releases Activity

Follow-up improvements for last change in gmalloc.c.

Browse Source 
src/gmalloc.c (aligned_alloc): Don't allocate more memory than
 needed, and don't reallocate if the initial allocation already
 fits the bill.  Suggested by Ken Brown <kbrown@cornell.edu>.

Fixes: debbugs:16901
This commit is contained in:
Eli Zaretskii 2014-03-04 19:35:15 +02:00
parent 3106d59bce
commit 201572eca8
2 changed files with 33 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ChangeLog
View File

@ -1,3 +1,9 @@
2014-03-04 Eli Zaretskii <eliz@gnu.org>
* gmalloc.c (aligned_alloc): Don't allocate more memory than
needed, and don't reallocate if the initial allocation already
fits the bill. Suggested by Ken Brown <kbrown@cornell.edu>.
2014-03-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
* xterm.c (x_draw_stretch_glyph_string): Reset clipping.

41
src/gmalloc.c
View File

@ -38,6 +38,10 @@ License along with this library. If not, see <http://www.gnu.org/licenses/>.
#include <w32heap.h> /* for sbrk */
#endif
#ifdef emacs
extern void emacs_abort (void);
#endif
#ifdef __cplusplus
extern "C"
{
@ -1594,24 +1598,33 @@ aligned_alloc (size_t alignment, size_t size)
/* Figure out how much we will need to pad this particular block
to achieve the required alignment. */
adj = (uintptr_t) result % alignment;
if (adj == 0)
adj = alignment;
do
if (adj != 1)
{
/* Reallocate the block with only as much excess as it needs. */
free (result);
result = malloc (size + alignment - adj);
if (result == NULL) /* Impossible unless interrupted. */
return NULL;
do
{
/* Reallocate the block with only as much excess as it
needs. */
free (result);
result = malloc (size + alignment - adj);
if (result == NULL) /* Impossible unless interrupted. */
return NULL;
lastadj = adj;
adj = (uintptr_t) result % alignment;
/* It's conceivable we might have been so unlucky as to get a
different block with weaker alignment. If so, this block is too
short to contain SIZE after alignment correction. So we must
try again and get another block, slightly larger. */
} while (adj < lastadj);
lastadj = adj;
adj = (uintptr_t) result % alignment;
if (adj == 0)
adj = alignment;
/* It's conceivable we might have been so unlucky as to get
a different block with weaker alignment. If so, this
block is too short to contain SIZE after alignment
correction. So we must try again and get another block,
slightly larger. */
} while (adj < lastadj);
}
if (adj != 0)
if (adj != alignment)
{
/* Record this block in the list of aligned blocks, so that `free'
can identify the pointer it is passed, which will be in the middle