mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-12-14 09:39:42 +00:00
Code Issues Releases Activity

Cache results of `css--property-values'

Browse Source 
* lisp/textmodes/css-mode.el (css--property-values): Cache computed
values.

* test/lisp/textmodes/css-mode-tests.el (css-test-property-value-cache):
New regression test for the above.
This commit is contained in:
Simen Heggestøyl 2016-04-24 11:03:22 +02:00
parent 5cb7620027
commit 8e2e252932
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lisp/textmodes/css-mode.el
View File

@ -792,13 +792,15 @@ the symbol VALUE-CLASS."
Completion candidates are looked up in `css-property-alist' by
the string PROPERTY."
(or (gethash property css--property-value-cache)
(seq-mapcat
(lambda (value)
(if (stringp value)
(list value)
(or (css--value-class-lookup value)
(css--property-values (symbol-name value)))))
(cdr (assoc property css-property-alist)))))
(let ((values
(seq-mapcat
(lambda (value)
(if (stringp value)
(list value)
(or (css--value-class-lookup value)
(css--property-values (symbol-name value)))))
(cdr (assoc property css-property-alist)))))
(puthash property values css--property-value-cache))))
(defun css--complete-property-value ()
"Complete property value at point."

7
test/lisp/textmodes/css-mode-tests.el
View File

@ -57,6 +57,13 @@
;; because it refers to the value class of the same name.
(should (= (length (css--property-values "color")) 18)))
(ert-deftest css-test-property-value-cache ()
"Test that `css--property-value-cache' is in use."
(should-not (gethash "word-wrap" css--property-value-cache))
(let ((word-wrap-values (css--property-values "word-wrap")))
(should (equal (gethash "word-wrap" css--property-value-cache)
word-wrap-values))))
(ert-deftest css-test-value-class-lookup ()
(should
(equal (sort (css--value-class-lookup 'position) #'string-lessp)