mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-11-22 07:09:54 +00:00
Code Issues Releases Activity

Use lexical-binding in find-cmd.el and add tests

Browse Source 
* lisp/find-cmd.el: Use lexical-binding.
* test/lisp/find-cmd-tests.el: New file.
This commit is contained in:
Stefan Kangas 2021-01-29 02:47:38 +01:00
parent 3ddea271cc
commit bab133e6d0
2 changed files with 47 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lisp/find-cmd.el
View File

@ -1,4 +1,4 @@
;;; find-cmd.el --- Build a valid find(1) command with sexps
;;; find-cmd.el --- Build a valid find(1) command with sexps -*- lexical-binding: t -*-
;; Copyright (C) 2008-2021 Free Software Foundation, Inc.
@ -28,7 +28,7 @@
;; (find-cmd '(prune (name ".svn" ".git" ".CVS"))
;; '(and (or (name "*.pl" "*.pm" "*.t")
;; (mtime "+1"))
;; (fstype "nfs" "ufs"))))
;; (fstype "nfs" "ufs")))
;; will become (un-wrapped):

45
test/lisp/find-cmd-tests.el Normal file
View File

@ -0,0 +1,45 @@
;;; find-cmd-tests.el --- tests for find-cmd.el. -*- lexical-binding: t -*-
;; Copyright (C) 2021 Free Software Foundation, Inc.
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Code:
(require 'ert)
(require 'find-cmd)
(ert-deftest find-cmd-test-find-cmd ()
(should
(string-match
(rx "find " (+ any)
" \\( \\( -name .svn -or -name .git -or -name .CVS \\)"
" -prune -or -true \\)"
" \\( \\( \\(" " -name \\*.pl -or -name \\*.pm -or -name \\*.t \\)"
" -or -mtime \\+1 \\) -and \\( -fstype nfs -or -fstype ufs \\) \\) ")
(find-cmd '(prune (name ".svn" ".git" ".CVS"))
'(and (or (name "*.pl" "*.pm" "*.t")
(mtime "+1"))
(fstype "nfs" "ufs"))))))
(ert-deftest find-cmd-test-find-cmd/error-unknown-atom ()
(should-error (find-cmd '(unknown 123))))
(ert-deftest find-cmd-test-find-cmd/error-wrong-argnum ()
(should-error (find-cmd '(name))))
(provide 'find-cmd-tests)
;;; find-cmd-tests.el ends here