From 9b8fced07907f63e358c28ce0834eaa3f7cdd957 Mon Sep 17 00:00:00 2001 From: Niclas Zeising Date: Thu, 7 Nov 2019 18:49:58 +0000 Subject: [PATCH] Add comment about USES+=xorg in mk files Add a comment clarifying why USES+=xorg is used in a couple of Mk/Uses/* files, even though it does not provide any immediate functionality. --- Mk/Uses/gl.mk | 4 +++- Mk/Uses/motif.mk | 4 +++- Mk/Uses/xorg-cat.mk | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Mk/Uses/gl.mk b/Mk/Uses/gl.mk index 071fb53bc501..865a43a67dce 100644 --- a/Mk/Uses/gl.mk +++ b/Mk/Uses/gl.mk @@ -45,7 +45,9 @@ LIB_DEPENDS+= ${_GL_${_component}_LIB_DEPENDS} .endif .endfor -# We only need USES=xorg if we want USE_XORG modules +# We only need to include xorg.mk if we want USE_XORG modules +# USES+=xorg does not provide any functionality, it just silences an error +# message about USES=xorg not being set .if defined(USE_XORG) && !empty(USE_XORG) USES+= xorg .include "${USESDIR}/xorg.mk" diff --git a/Mk/Uses/motif.mk b/Mk/Uses/motif.mk index 549f7b53caf2..01e7139ff8d7 100644 --- a/Mk/Uses/motif.mk +++ b/Mk/Uses/motif.mk @@ -27,7 +27,9 @@ LIB_DEPENDS+= libXm.so.4:x11-toolkits/open-motif MOTIFLIB?= -L${LOCALBASE}/lib -lXm MAKE_ENV+= MOTIFLIB="${MOTIFLIB}" -# We only need USES=xorg if we want USE_XORG modules +# We only need to include xorg.mk if we want USE_XORG modules +# USES+=xorg does not provide any functionality, it just silences an error +# message about USES=xorg not being set .if defined(USE_XORG) && !empty(USE_XORG) USES+= xorg .include "${USESDIR}/xorg.mk" diff --git a/Mk/Uses/xorg-cat.mk b/Mk/Uses/xorg-cat.mk index 74335beea011..203a61a97fd0 100644 --- a/Mk/Uses/xorg-cat.mk +++ b/Mk/Uses/xorg-cat.mk @@ -177,7 +177,9 @@ USE_XORG+= fontutil . endif # ${_XORG_CAT} == -# We only need USES=xorg if we want USE_XORG modules +# We only need to include xorg.mk if we want USE_XORG modules +# USES+=xorg does not provide any functionality, it just silences an error +# message about USES=xorg not being set . if defined(USE_XORG) && !empty(USE_XORG) USES+= xorg .include "${USESDIR}/xorg.mk"