From 14fd107181ca9be783f9d9391836ce1fc44803fe Mon Sep 17 00:00:00 2001 From: Maxime Henrion Date: Tue, 8 Apr 2003 18:35:51 +0000 Subject: [PATCH] Add an XXX comment for the atomic operation in the __alpha__ case so that it doesn't confuse more people. Use the more correct atomic_clear_16() instead of atomic_clear_short(). --- sys/dev/fxp/if_fxp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/fxp/if_fxp.c b/sys/dev/fxp/if_fxp.c index 756a1a9a1f74..562a8dfc51bc 100644 --- a/sys/dev/fxp/if_fxp.c +++ b/sys/dev/fxp/if_fxp.c @@ -1383,8 +1383,10 @@ fxp_start(struct ifnet *ifp) * granularities, we must prevent the card from DMA'ing * up the status while we update the command field. * This could cause us to overwrite the completion status. + * XXX This is probably bogus and we're _not_ looking + * for atomicity here. */ - atomic_clear_short(&sc->fxp_desc.tx_last->tx_cb->cb_command, + atomic_clear_16(&sc->fxp_desc.tx_last->tx_cb->cb_command, htole16(FXP_CB_COMMAND_S)); #else sc->fxp_desc.tx_last->tx_cb->cb_command &=