diff --git a/contrib/sendmail/src/mci.c b/contrib/sendmail/src/mci.c index 4955197a6ebb..4ff75780bfbc 100644 --- a/contrib/sendmail/src/mci.c +++ b/contrib/sendmail/src/mci.c @@ -398,6 +398,57 @@ mci_get(host, m) return mci; } + +/* +** MCI_CLOSE -- (forcefully) close files used for a connection. +** Note: this is a last resort, usually smtpquit() or endmailer() +** should be used to close a connection. +** +** Parameters: +** mci -- the connection to close. +** where -- where has this been called? +** +** Returns: +** none. +*/ + +void +mci_close(mci, where) + MCI *mci; + char *where; +{ + bool dumped; + + if (mci == NULL) + return; + dumped = false; + if (mci->mci_out != NULL) + { + if (tTd(56, 1)) + { + sm_dprintf("mci_close: mci_out!=NULL, where=%s\n", + where); + mci_dump(sm_debug_file(), mci, false); + dumped = true; + } + (void) sm_io_close(mci->mci_out, SM_TIME_DEFAULT); + mci->mci_out = NULL; + } + if (mci->mci_in != NULL) + { + if (tTd(56, 1)) + { + sm_dprintf("mci_close: mci_in!=NULL, where=%s\n", + where); + if (!dumped) + mci_dump(sm_debug_file(), mci, false); + } + (void) sm_io_close(mci->mci_in, SM_TIME_DEFAULT); + mci->mci_in = NULL; + } + mci->mci_state = MCIS_CLOSED; +} + /* ** MCI_NEW -- allocate new MCI structure ** diff --git a/contrib/sendmail/src/sendmail.h b/contrib/sendmail/src/sendmail.h index 673cee5cf073..370fae856b89 100644 --- a/contrib/sendmail/src/sendmail.h +++ b/contrib/sendmail/src/sendmail.h @@ -728,6 +728,7 @@ MCI /* functions */ extern void mci_cache __P((MCI *)); +extern void mci_close __P((MCI *, char *where)); extern void mci_dump __P((SM_FILE_T *, MCI *, bool)); extern void mci_dump_all __P((SM_FILE_T *, bool)); extern void mci_flush __P((bool, MCI *)); diff --git a/contrib/sendmail/src/usersmtp.c b/contrib/sendmail/src/usersmtp.c index 0bcbcf51bbf1..24b09549a12a 100644 --- a/contrib/sendmail/src/usersmtp.c +++ b/contrib/sendmail/src/usersmtp.c @@ -89,6 +89,7 @@ smtpinit(m, mci, e, onlyhelo) */ SmtpError[0] = '\0'; + SmtpMsgBuffer[0] = '\0'; CurHostName = mci->mci_host; /* XXX UGLY XXX */ if (CurHostName == NULL) CurHostName = MyHostName; @@ -2899,7 +2900,10 @@ smtpquit(m, mci, e) char *oldcurhost; if (mci->mci_state == MCIS_CLOSED) + { + mci_close(mci, "smtpquit:1"); return; + } oldcurhost = CurHostName; CurHostName = mci->mci_host; /* XXX UGLY XXX */ @@ -3133,7 +3137,7 @@ reply(m, mci, e, timeout, pfunc, enhstat, rtype) if (strncmp(SmtpMsgBuffer, "QUIT", 4) == 0) { errno = mci->mci_errno; - mci->mci_state = MCIS_CLOSED; + mci_close(mci, "reply:1"); return -1; } mci->mci_state = MCIS_ERROR; @@ -3158,7 +3162,7 @@ reply(m, mci, e, timeout, pfunc, enhstat, rtype) /* errors on QUIT should be ignored */ if (strncmp(SmtpMsgBuffer, "QUIT", 4) == 0) { - mci->mci_state = MCIS_CLOSED; + mci_close(mci, "reply:2"); return -1; }