From 31a4b1aa03e3c53f81e141c54c657ee8cff74b0d Mon Sep 17 00:00:00 2001 From: Edward Tomasz Napierala Date: Sun, 21 Sep 2014 10:34:15 +0000 Subject: [PATCH] Turns out -1 is a perfectly valid error number, ERESTART. Remove useless code written under assumption that it wasn't. Sponsored by: The FreeBSD Foundation --- sys/fs/autofs/autofs.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sys/fs/autofs/autofs.c b/sys/fs/autofs/autofs.c index 988a1ab21b4f..5a247b440665 100644 --- a/sys/fs/autofs/autofs.c +++ b/sys/fs/autofs/autofs.c @@ -429,11 +429,6 @@ autofs_trigger_one(struct autofs_node *anp, &autofs_softc->sc_lock); autofs_restore_sigmask(&oldset); if (error != 0) { - /* - * XXX: For some reason this returns -1 - * instead of EINTR, wtf?! - */ - error = EINTR; AUTOFS_WARN("cv_wait_sig for %s failed " "with error %d", ar->ar_path, error); break; @@ -495,7 +490,7 @@ autofs_trigger(struct autofs_node *anp, anp->an_retries = 0; return (0); } - if (error == EINTR) { + if (error == EINTR || error == ERESTART) { AUTOFS_DEBUG("trigger interrupted by signal, " "not retrying"); anp->an_retries = 0; @@ -541,11 +536,6 @@ autofs_ioctl_request(struct autofs_daemon_request *adr) error = cv_wait_sig(&autofs_softc->sc_cv, &autofs_softc->sc_lock); if (error != 0) { - /* - * XXX: For some reason this returns -1 instead - * of EINTR, wtf?! - */ - error = EINTR; sx_xunlock(&autofs_softc->sc_lock); AUTOFS_DEBUG("failed with error %d", error); return (error);