From 3b7e0c53d5885584c31b76949de3c078830ec2ee Mon Sep 17 00:00:00 2001 From: Don Lewis Date: Fri, 13 May 2016 00:02:03 +0000 Subject: [PATCH] Use strlcpy() instead of strncpy() to ensure that qup->fsname is NUL terminated. Don't bother checking for truncation since the subsequent quota_read() should detect that and fail. Reported by: Coverity CID: 1009980 MFC after: 1 week --- usr.sbin/edquota/edquota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/edquota/edquota.c b/usr.sbin/edquota/edquota.c index 0cd117f19969..6a6c194f6ab9 100644 --- a/usr.sbin/edquota/edquota.c +++ b/usr.sbin/edquota/edquota.c @@ -390,7 +390,7 @@ getprivs(long id, int quotatype, char *fspath) if ((qup = (struct quotause *)calloc(1, sizeof(*qup))) == NULL) errx(2, "out of memory"); qup->qf = qf; - strncpy(qup->fsname, fs->fs_file, sizeof(qup->fsname)); + strlcpy(qup->fsname, fs->fs_file, sizeof(qup->fsname)); if (quota_read(qf, &qup->dqblk, id) == -1) { warn("cannot read quotas on %s", fs->fs_file); freeprivs(qup);