From 6b4df955a11fb7a0f4e81572d61500a751af31a7 Mon Sep 17 00:00:00 2001
From: Enji Cooper <ngie@FreeBSD.org>
Date: Tue, 31 Oct 2017 05:11:55 +0000
Subject: [PATCH] Polish up end-user messages

---
 tests/tools/gather_coverage.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/tools/gather_coverage.sh b/tests/tools/gather_coverage.sh
index f86ccf66b1b2..f7a43a018ced 100755
--- a/tests/tools/gather_coverage.sh
+++ b/tests/tools/gather_coverage.sh
@@ -35,7 +35,7 @@ SCRIPT=${0##*/}
 
 error()
 {
-	printf >&2 "${SCRIPT}: ERROR: $@\n"
+	printf >&2 "${SCRIPT}: ERROR: %s\n" "$@"
 }
 
 require_command()
@@ -45,7 +45,7 @@ require_command()
 	if ! command -v $cmd >/dev/null; then
 		error "required command not found: $cmd"
 		if [ $# -gt 0 ]; then
-			printf >&2 "$@\n"
+			printf >&2 "%s\n" "$@"
 		fi
 		exit 1
 	fi
@@ -54,13 +54,13 @@ require_command()
 
 
 require_command ${GCOV} \
-    "Install gcov from base or the appropriate version from ports"
+    'Install gcov from base, or specify alternate version, e.g., from ports, using $GCOV.'
 for cmd in lcov genhtml; do
-	require_command ${cmd} "Install devel/lcov from ports"
+	require_command ${cmd} "Install devel/lcov from ports."
 done
 
 if ! COVERAGE_TMP=$(mktemp -d tmp.XXXXXX); then
-	error "failed to create COVERAGE_TMP"
+	error "failed to create COVERAGE_TMP."
 	exit 1
 fi
 trap "rm -Rf '$COVERAGE_TMP'" EXIT INT TERM