From a5906b6cd2cd2d4bd212cc6ead8c08f39f1997f2 Mon Sep 17 00:00:00 2001 From: Jun Kuriyama Date: Fri, 10 Sep 2004 14:45:00 +0000 Subject: [PATCH] I found "portsdb -u" dumps core with recent INDEX file, and this is caused by refering broken (uninitialized?) pointer which is retrieved from __bt_new() (and from mpool_new()). I don't know why this linp[0] is read before stored because this should be controlled by .lower and .upper member of PAGE structure which are correctly initialized. But this workaround fixes the problem on my environment and this module has #ifdef PURIFY option which initializes new and reused memory from mpool by memset(p, 0xff, size) like as I did. Please feel free to fix the real bug instead of my workaround. --- lib/libc/db/btree/bt_split.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libc/db/btree/bt_split.c b/lib/libc/db/btree/bt_split.c index 9112ec8a0330..0e478dee7be6 100644 --- a/lib/libc/db/btree/bt_split.c +++ b/lib/libc/db/btree/bt_split.c @@ -361,6 +361,8 @@ bt_page(t, h, lp, rp, skip, ilen) r->nextpg = h->nextpg; r->prevpg = h->pgno; r->flags = h->flags & P_TYPE; + /* XXX: Workaround for broken page data access. */ + r->linp[0] = 0xffff; /* * If we're splitting the last page on a level because we're appending