1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-12 09:58:36 +00:00
freebsd/sys/x86
Andriy Gapon de15b11aaa x86 cpususpend_handler: call wbinvd after setting suspend state bits
Without a subsequent wbinvd the changes to suspended_cpus (and
resuming_cpus) can be lost at least on AMD systems that use MOESI cache
coherency protocol.  That can happen because one of APs ends up as an
Owner of the corresponding cache line(s) and the changes may never reach
the main memory before the AP is reset.

While here, move clearing of suspended_cpus a little bit earlier as the
fact of returning from savectx (with zero return value) means that the
CPU has fully restored it execution context.

Also, rework the comment that describes the need for resuming_cpus.

This change fixed suspend to RAM a previously broken AMD-based system.

Reviewed by:	kib
Discussed with:	bde
MFC after:	3 weeks
Differential Revision: https://reviews.freebsd.org/D15295
2018-05-07 12:22:25 +00:00
..
acpica Redo r332918 with the ACPICA API and remove debug.acpi.suspend_deep_bounce. 2018-05-03 19:00:50 +00:00
bios sys/x86: further adoption of SPDX licensing ID tags. 2017-11-27 15:11:47 +00:00
cpufreq cpufreq: Remove error-prone table terminators in favor of automatic sizing 2018-04-14 03:15:05 +00:00
include Add helper macros to hide some boring repeatable ceremonies to define 2018-05-03 21:45:59 +00:00
iommu Don't include DMAR map entry zone items in kernel dumps. 2018-02-18 16:03:50 +00:00
isa ANSIfy sys/x86 2018-03-17 01:40:09 +00:00
pci Add ISA PNP tables to ISA drivers. Fix a few incidental comments. 2018-01-29 00:22:30 +00:00
x86 x86 cpususpend_handler: call wbinvd after setting suspend state bits 2018-05-07 12:22:25 +00:00
xen xen: fix formatting of xen_init_ops 2018-05-02 10:20:55 +00:00