From 09025a7147084783bf1dd4d1bec463ceab8d16b4 Mon Sep 17 00:00:00 2001
From: Ben Wilber <ben@desync.com>
Date: Thu, 9 May 2024 20:08:15 -0600
Subject: [PATCH] ipfw: correctly report table manipulation errors

Let ipfw(8) report the actual error instead of the error that
may have come from calling printf().

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1221
---
 sbin/ipfw/tables.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c
index 7901950acad..4c783e02f85 100644
--- a/sbin/ipfw/tables.c
+++ b/sbin/ipfw/tables.c
@@ -1037,6 +1037,9 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add,
 		}
 	}
 
+	/* Get real OS error */
+	error = errno;
+
 	/* Report results back */
 	ptent = tent_buf;
 	for (i = 0; i < count; ptent++, i++) {
@@ -1089,8 +1092,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add,
 
 	if (error == 0)
 		return;
-	/* Get real OS error */
-	error = errno;
 
 	/* Try to provide more human-readable error */
 	switch (error) {