From 7288dfa6c20433fcd57201943d1acee86f46c64a Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Wed, 16 Jul 2025 18:20:50 +0200 Subject: [PATCH] .github/PULL_REQUEST_TEMPLATE: shorten TODO list This doesn't really change the items, but shortens the writing a lot, making them much more readable, especially while still drafting the PR. Mentioning the release notes for the previous release is not really important, because it doesn't apply for the big majority of pull requests. --- .github/PULL_REQUEST_TEMPLATE.md | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e0cb5210e5a5..6f2f01e5d33e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,26 +10,26 @@ For new packages please briefly describe the package or provide a link to its ho -- Built on platform(s) +- Built on platform: - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin -- [ ] Tested, as applicable: - - [NixOS test(s)] (look inside [nixos/tests]) - - and/or [package tests] - - or, for functions and "core" functionality, tests in [lib/tests] or [pkgs/test] -- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage] -- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) -- Nixpkgs Release Notes (or backporting 25.05 Nixpkgs Release notes) - - [ ] (Package updates) Added a release notes entry if the change is major or breaking -- NixOS Release Notes (or backporting 25.05 NixOS Release notes) - - [ ] (Module updates) Added a release notes entry if the change is significant - - [ ] (Module addition) Added a release notes entry if adding a new NixOS module -- [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other contributing documentation in corresponding paths. +- Tested, as applicable: + - [ ] [NixOS tests] in [nixos/tests]. + - [ ] [Package tests] at `passthru.tests`. + - [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality. +- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage]. +- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`. +- Nixpkgs Release Notes + - [ ] Package update: when the change is major or breaking. +- NixOS Release Notes + - [ ] Module addition: when adding a new NixOS module. + - [ ] Module update: when the change is significant. +- [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and others READMEs. -[NixOS test(s)]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests -[package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests +[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests +[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md