From 0bcef7f512654c19ca2d28c75849be1069cc3524 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Sun, 3 Aug 2025 17:06:21 +0300 Subject: [PATCH 1/4] abbaye-des-morts: use `finalAttrs` pattern --- pkgs/by-name/ab/abbaye-des-morts/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/ab/abbaye-des-morts/package.nix b/pkgs/by-name/ab/abbaye-des-morts/package.nix index baed89f1b682..a335bad9da24 100644 --- a/pkgs/by-name/ab/abbaye-des-morts/package.nix +++ b/pkgs/by-name/ab/abbaye-des-morts/package.nix @@ -7,14 +7,14 @@ SDL2_mixer, }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "abbaye-des-morts"; version = "2.0.5"; src = fetchFromGitHub { owner = "nevat"; repo = "abbayedesmorts-gpl"; - tag = "v${version}"; + tag = "v${finalAttrs.version}"; sha256 = "sha256-muJt1cml0nYdgl0v8cudpUXcdSntc49e6zICTCwzkks="; }; @@ -46,4 +46,4 @@ stdenv.mkDerivation rec { license = lib.licenses.gpl3; maintainers = with lib.maintainers; [ marius851000 ]; }; -} +}) From 058b2b16921f2e72b317fa2d2dd68e9c1a4797ef Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Sun, 3 Aug 2025 17:10:41 +0300 Subject: [PATCH 2/4] abbaye-des-morts: use `${placeholder "out"}` --- pkgs/by-name/ab/abbaye-des-morts/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/ab/abbaye-des-morts/package.nix b/pkgs/by-name/ab/abbaye-des-morts/package.nix index a335bad9da24..6a20fc2ff4eb 100644 --- a/pkgs/by-name/ab/abbaye-des-morts/package.nix +++ b/pkgs/by-name/ab/abbaye-des-morts/package.nix @@ -25,7 +25,7 @@ stdenv.mkDerivation (finalAttrs: { ]; makeFlags = [ - "PREFIX=$(out)" + "PREFIX=${placeholder "out"}" "DESTDIR=" ]; From acca62bcd114fabdb2a602e17f89f4570ce97ad7 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Sun, 3 Aug 2025 17:14:47 +0300 Subject: [PATCH 3/4] abbaye-des-morts: drop `preInstall` Already handled by Makefile --- pkgs/by-name/ab/abbaye-des-morts/package.nix | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkgs/by-name/ab/abbaye-des-morts/package.nix b/pkgs/by-name/ab/abbaye-des-morts/package.nix index 6a20fc2ff4eb..b4931863c872 100644 --- a/pkgs/by-name/ab/abbaye-des-morts/package.nix +++ b/pkgs/by-name/ab/abbaye-des-morts/package.nix @@ -34,11 +34,6 @@ stdenv.mkDerivation (finalAttrs: { --replace -fpredictive-commoning "" ''; - preInstall = '' - mkdir -p $out/bin - mkdir -p $out/share/applications - ''; - meta = { homepage = "https://locomalito.com/abbaye_des_morts.php"; description = "Retro arcade video game"; From 67ab5122c1bb9e7f366384d9d5c04d7e9533bc07 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Sun, 3 Aug 2025 16:59:38 +0300 Subject: [PATCH 4/4] abbaye-des-morts: fix darwin build --- pkgs/by-name/ab/abbaye-des-morts/package.nix | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/ab/abbaye-des-morts/package.nix b/pkgs/by-name/ab/abbaye-des-morts/package.nix index b4931863c872..e0905c31c0ca 100644 --- a/pkgs/by-name/ab/abbaye-des-morts/package.nix +++ b/pkgs/by-name/ab/abbaye-des-morts/package.nix @@ -27,11 +27,15 @@ stdenv.mkDerivation (finalAttrs: { makeFlags = [ "PREFIX=${placeholder "out"}" "DESTDIR=" - ]; + ] + ++ lib.optional stdenv.isDarwin "PLATFORM=mac"; - preBuild = lib.optionalString stdenv.cc.isClang '' + # Even with PLATFORM=mac, the Makefile specifies some GCC-specific CFLAGS that + # are not supported by modern Clang on macOS + postPatch = lib.optionalString stdenv.isDarwin '' substituteInPlace Makefile \ - --replace -fpredictive-commoning "" + --replace-fail "-funswitch-loops" "" \ + --replace-fail "-fgcse-after-reload" "" ''; meta = {