Winter a19cd4ffb1 Revert "treewide: replace rev with tag"
This reverts commit 65a333600d5c88a98d674f637d092807cfc12253.

This wasn't tested for correctness with something like fodwatch [0],
and should not have been (self-)merged so quickly, especially without
further review.

It also resulted in the breakage of at least one package [1] (and that's
the one we know of and was caught).

A few packages that were updated in between this commit and this revert
were not reverted back to using `rev`, but other than that, this is a
1:1 revert.

[0]: https://codeberg.org/raphaelr/fodwatch
[1]: https://github.com/NixOS/nixpkgs/pull/396904 / 758551e4587d75882aebc21a04bee960418f8ce9
2025-04-08 02:57:25 -04:00

52 lines
1.3 KiB
Nix

{
lib,
buildPythonPackage,
fetchFromGitHub,
cmake,
pkg-config,
boost,
gfal2,
glib,
pythonAtLeast,
# For tests
gfal2-util ? null,
}:
buildPythonPackage rec {
pname = "gfal2-python";
version = "1.12.2";
src = fetchFromGitHub {
owner = "cern-fts";
repo = "gfal2-python";
rev = "v${version}";
hash = "sha256-Xk+gLTrqfWb0kGB6QhnM62zAHVFb8rRAqCIBxn0V824=";
};
nativeBuildInputs = [
cmake
pkg-config
];
buildInputs = [
boost
gfal2
glib
];
# We don't want setup.py to (re-)execute cmake in buildPhase
# Besides, this package is totally handled by CMake, which means no additional configuration is needed.
dontConfigure = true;
pythonImportsCheck = [ "gfal2" ];
passthru = {
inherit gfal2;
tests = {
inherit gfal2-util;
} // lib.optionalAttrs (gfal2-util != null) gfal2-util.tests or { };
};
meta = with lib; {
description = "Python binding for gfal2";
homepage = "https://github.com/cern-fts/gfal2-python";
license = licenses.asl20;
maintainers = with maintainers; [ ShamrockLee ];
# It currently fails to build against Python 3.12 or later,
# complaining CMake faililng to find Python include path, library path and site package path.
broken = pythonAtLeast "3.12";
};
}