With git-clone version 0.8 and onwards, it started running as non-root
and GKE clusters were having some issues, so, we temporarily moved all
tasks to use git-clone version 0.7. Ref: https://github.com/tektoncd/catalog/pull/1079
Since we have now moved to kind clusters in our CI, this issue is now
resolved and thus moving all tasks to use latest version of git-clone
Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Some tasks were referencing absolute paths for `results`. It is recommended
to use variable replacement syntax in the API spec. This PR migrates the
absolute paths for results to variable syntax notation.
While consuming the result `IMAGE_URL` produced by buildah task, a new
line character '\n' was getting appended and the same was causing issues
which using the task.
- Added `-n` flag with echo in order to remove the newline character
- Modified the tests for the same
Signed-off-by: vinamra28 <jvinamra776@gmail.com>
With git-clone version 0.8, Task now runs as non-root and with this change I
guess it's not working well with our GKE clusters and tests started
failing in nightly runs.
For now changing the version of git-clone to use 0.7 so that for now CI
is unblocked 😅
Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: https://github.com/tektoncd/hub/pull/539
This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
At this moment all tasks which can be executed on linux/s390x or
linux/ppc64le are tested and labelled accordingly.
The rest of the tasks can be labelled as `linux/amd64`, which
is default platform and where tasks are already tested via
default PR testing cycle.
Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
quay.io/buildah/stable:v1.18.0 and quay.io/skopeo/stable:v1.3.0 are
multi-arch images, bumping them for buildah and skopeo-copy tasks will
allow to run the tasks on different architectures.
Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
- Initially all tags were mapped to categories in Hub,
for e.g. config.yaml: https://github.com/tektoncd/hub/blob/master/config.yaml,
so whenever a new tag was added in a task it was mapped to a category called `others`.
Hence before every release we had to manually map these new tags to some category,
hence after the discussion in Catalog and Hub WG, a proposal was created for adding
a category as an annotation.
- PR to update the TEP-0003-Tekton Catalog Organization: https://github.com/tektoncd/community/pull/352
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
This change simply adds comments to secrets and other password/key
material that are used in testing. The usage of these secrets is okay
(they're all either dummy tokens or auth material set for local
instances spun up during tests), but adding comments to provide some
background for anyone browsing the code.
Also redacted a cert used in the buildah sample. While this was
safe since it was generated specifically for the sample, there isn't a strict
need for a valid cert here, so we can replace this with something that looks
cert-like instead.
Since buildah has been built with the latest golang 1.15 version which has SAN
enforcement, we provide subjectAltName in the generation of self generated
certificate.
See https://security.stackexchange.com/a/183973
- git-cli examples moved from git-cli/examples/git-cli -> git-cli/examples/
- git-rebase examples moved from git-rebase/examples/git-rebase -> git-rebase/examples/
- changed workingdir -> workingDir in git-rebase
- corrected install command in az
- improved YAML in readme for proper rendering
Signed-off-by: vinamra28 <vinjain@redhat.com>
We are bumping the buildah task to 0.2 since this needs at least pipeline
0.17.0.
This will add a optional workspace for the cert dir to pass to buildah
--cert-dir flag.
I have modified the test to create a registry with SSL certs and make the
buildah task using it.
This add a complete example on how to use this with the openshift internal
registry.
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
We were previously using the outdated git_clone version 0.1 in the
add_git_clone_task function.
So let's introduce a more generic function :
```
add_task ${task} ${version}
```
if version is 'latest' it will always install the latest version of the task.
Change all pre-apply-task-hook to use that function instead.
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Buildah image in few tasks was not pointing to latest
image release tag, so updated the image to point to
latest release.
Signed-off-by: Divyansh42 <diagrawa@redhat.com>
Centralize all the the git-clone apply commands we had around the
pre-apply-task-hook to a central common function.
This will make easier to have the same git-clone task version used everywhere.
Add some documentation about the helper functions along the way.
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
We don't really have a concept in Tekton of something called a "Workspace volume",
but multiple READMEs now refer to it.
This commit removes the term "Workspace volume" in favor of simply "Workspace".
Changes include:
- adds version label
- adds a minimum pipeline versions supported by the task
- adds tags for task
- modified description to add a summary
This patch also moves the buildah files to the task directory
and modifies the path for install task command in readme file
Issue: #386
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
