mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-11-26 07:33:47 +00:00
Code Issues Releases Activity

Speed up ls-lisp

Browse Source 
This speeds up Dired by 25% in large directories.
* lisp/ls-lisp.el (ls-lisp--time-locale): New defvar.
(ls-lisp-format-time): calculate the locale for formatting times
only once and cache the value in 'ls-lisp--time-locale'.
(Bug#44273)
This commit is contained in:
Eli Zaretskii 2020-10-31 11:41:53 +02:00
parent 41c4f337c8
commit 96ec034071
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lisp/ls-lisp.el
View File

@ -836,6 +836,9 @@ Return nil if no time switch found."
((memq ?t switches) 5) ; last modtime ((memq ?t switches) 5) ; last modtime
((memq ?u switches) 4))) ; last access ((memq ?u switches) 4))) ; last access
(defvar ls-lisp--time-locale nil
"Locale to be used for formatting file times.")
(defun ls-lisp-format-time (file-attr time-index) (defun ls-lisp-format-time (file-attr time-index)
"Format time for file with attributes FILE-ATTR according to TIME-INDEX. "Format time for file with attributes FILE-ATTR according to TIME-INDEX.
Use the same method as ls to decide whether to show time-of-day or year, Use the same method as ls to decide whether to show time-of-day or year,
@ -851,11 +854,13 @@ All ls time options, namely c, t and u, are handled."
(condition-case nil (condition-case nil
;; Use traditional time format in the C or POSIX locale, ;; Use traditional time format in the C or POSIX locale,
;; ISO-style time format otherwise, so columns line up. ;; ISO-style time format otherwise, so columns line up.
(let ((locale system-time-locale)) (let ((locale (or system-time-locale ls-lisp--time-locale)))
(if (not locale) (if (not locale)
(let ((vars '("LC_ALL" "LC_TIME" "LANG"))) (let ((vars '("LC_ALL" "LC_TIME" "LANG")))
(while (and vars (not (setq locale (getenv (car vars))))) (while (and vars (not (setq locale (getenv (car vars)))))
(setq vars (cdr vars))))) (setq vars (cdr vars)))
;; Cache the locale for next calls.
(setq ls-lisp--time-locale (or locale "C"))))
(if (member locale '("C" "POSIX")) (if (member locale '("C" "POSIX"))
(setq locale nil)) (setq locale nil))
(format-time-string (format-time-string