mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-12-11 09:20:51 +00:00
Code Issues Releases Activity

Move warnings about bad let-bindings from source optimiser to cconv

Browse Source 
* lisp/emacs-lisp/byte-opt.el (byte-optimize-let-form): Move warnings...
* lisp/emacs-lisp/cconv.el (cconv-convert): ...here, which is an
overall better place (closer to the front-end).
This commit is contained in:
Mattias Engdegård 2021-07-29 17:20:41 +02:00
parent dc9e2a1749
commit ab9c06449d
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lisp/emacs-lisp/byte-opt.el
View File

@ -697,16 +697,11 @@ Same format as `byte-optimize--lexvars', with shared structure and contents.")
(let-vars nil))
(dolist (binding (car form))
(let (name expr)
(cond ((consp binding)
(setq name (car binding))
(unless (symbolp name)
(byte-compile-warn "let-bind nonvariable: `%S'" name))
(setq expr (byte-optimize-form (cadr binding) nil)))
((symbolp binding)
(setq name binding))
(t (byte-compile-warn "malformed let binding: `%S'" binding)))
(let* (
(value (and (byte-optimize--substitutable-p expr)
(if (atom binding)
(setq name binding)
(setq name (car binding))
(setq expr (byte-optimize-form (cadr binding) nil)))
(let* ((value (and (byte-optimize--substitutable-p expr)
(list expr)))
(lexical (not (or (and (symbolp name)
(special-variable-p name))

7
lisp/emacs-lisp/cconv.el
View File

@ -358,6 +358,13 @@ places where they originally did not directly appear."
letsym binder))
(setq value (cadr binder))
(car binder)))
(_ (cond
((not (symbolp var))
(byte-compile-warn "attempt to let-bind nonvariable `%S'"
var))
((or (booleanp var) (keywordp var))
(byte-compile-warn "attempt to let-bind constant `%S'"
var))))
(new-val
(pcase (cconv--var-classification binder form)
;; Check if var is a candidate for lambda lifting.