mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2025-01-15 17:00:26 +00:00
Code Issues Releases Activity

* keyboard.c (make_lispy_event): Avoid unnecessary tests

Browse Source 
of bit 28 and of whether an unsigned value is negative.
This simplifies the code a bit, and pacifies clang 3.4.
This commit is contained in:
Paul Eggert 2014-09-24 11:25:04 -07:00
parent 558eb84ff9
commit cd812613c8
2 changed files with 25 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ChangeLog
View File

@ -1,3 +1,9 @@
2014-09-24 Paul Eggert <eggert@cs.ucla.edu>
* keyboard.c (make_lispy_event): Avoid unnecessary tests
of bit 28 and of whether an unsigned value is negative.
This simplifies the code a bit, and pacifies clang 3.4.
2014-09-24 Eli Zaretskii <eliz@gnu.org>
* systime.h (Time): Define as size_t, to be consistent with 64-bit

41
src/keyboard.c
View File

@ -5548,30 +5548,27 @@ make_lispy_event (struct input_event *event)
ARRAYELTS (iso_lispy_function_keys));
#endif
/* Handle system-specific or unknown keysyms. */
if (event->code & (1 << 28)
|| event->code - FUNCTION_KEY_OFFSET < 0
|| (event->code - FUNCTION_KEY_OFFSET
>= ARRAYELTS (lispy_function_keys))
|| !lispy_function_keys[event->code - FUNCTION_KEY_OFFSET])
{
/* We need to use an alist rather than a vector as the cache
since we can't make a vector long enough. */
if (NILP (KVAR (current_kboard, system_key_syms)))
kset_system_key_syms (current_kboard, Fcons (Qnil, Qnil));
return modify_event_symbol (event->code,
event->modifiers,
Qfunction_key,
KVAR (current_kboard, Vsystem_key_alist),
0, &KVAR (current_kboard, system_key_syms),
PTRDIFF_MAX);
}
if ((FUNCTION_KEY_OFFSET <= event->code
&& (event->code
< FUNCTION_KEY_OFFSET + ARRAYELTS (lispy_function_keys)))
&& lispy_function_keys[event->code - FUNCTION_KEY_OFFSET])
return modify_event_symbol (event->code - FUNCTION_KEY_OFFSET,
event->modifiers,
Qfunction_key, Qnil,
lispy_function_keys, &func_key_syms,
ARRAYELTS (lispy_function_keys));
return modify_event_symbol (event->code - FUNCTION_KEY_OFFSET,
/* Handle system-specific or unknown keysyms.
We need to use an alist rather than a vector as the cache
since we can't make a vector long enough. */
if (NILP (KVAR (current_kboard, system_key_syms)))
kset_system_key_syms (current_kboard, Fcons (Qnil, Qnil));
return modify_event_symbol (event->code,
event->modifiers,
Qfunction_key, Qnil,
lispy_function_keys, &func_key_syms,
ARRAYELTS (lispy_function_keys));
Qfunction_key,
KVAR (current_kboard, Vsystem_key_alist),
0, &KVAR (current_kboard, system_key_syms),
PTRDIFF_MAX);
#ifdef HAVE_NTGUI
case MULTIMEDIA_KEY_EVENT: