mirror/emacs
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2025-01-13 16:38:14 +00:00
Code Issues Releases Activity

* movemail.c (popmail): Report fchown failure instead of ignoring it.

Browse Source 
But if the file already has the right ownership, don't worry about it.
This commit is contained in:
Paul Eggert 2011-02-21 14:31:55 -08:00
parent 4df52042a5
commit f0939c31a6
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib-src/ChangeLog
View File

@ -1,5 +1,8 @@
2011-02-21 Paul Eggert <eggert@cs.ucla.edu>
* movemail.c (popmail): Report fchown failure instead of ignoring it.
But if the file already has the right ownership, don't worry about it.
* make-docfile.c (input_buffer): Rename variables to avoid shadowing.
* movemail.c (main, pop_retr): Rename locals to avoid shadowing.

13
lib-src/movemail.c
View File

@ -723,7 +723,18 @@ popmail (char *mailbox, char *outfile, int preserve, char *password, int reverse
error ("Error in open: %s, %s", strerror (errno), outfile);
return EXIT_FAILURE;
}
fchown (mbfi, getuid (), -1);
if (fchown (mbfi, getuid (), -1) != 0)
{
int fchown_errno = errno;
struct stat st;
if (fstat (mbfi, &st) != 0 || st.st_uid != getuid ())
{
pop_close (server);
error ("Error in fchown: %s, %s", strerror (fchown_errno), outfile);
return EXIT_FAILURE;
}
}
if ((mbf = fdopen (mbfi, "wb")) == NULL)
{