1
0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2025-01-07 15:21:46 +00:00
Commit Graph

133117 Commits

Author SHA1 Message Date
Stefan Monnier
53c29c4d3c * lisp/emacs-lisp/gv.el (gv-define-setter): Silence compiler warning
Code placed in the `gv-expander` property will presumably only be used
when gv is loaded (bug#14529).
2018-04-18 15:56:15 -04:00
Paul Eggert
403f3d2c85 Tell user about read-integer-overflow-as-float
* src/lread.c (string_to_number): Suggest
read-integer-overflow-as-float in signal message.
Suggested by Stefan Monnier (Bug#31118#58).
2018-04-18 12:48:48 -07:00
Martin Rudalics
ce0e253f48 ; * etc/NEWS: Improve last change as proposed by Phil Sainty 2018-04-18 14:19:21 +02:00
Noam Postavsky
b89ff0efdb Don't assume term-current-row cache is valid (Bug#31193)
* lisp/term.el (term-down): Call `term-current-row' instead of
directly accessing the variable `term-current-row.  Following a resize
of the terminal's window, `term-current-row' is reset to nil, so it is
not safe to assume it is a number.
2018-04-18 07:33:27 -04:00
Martin Rudalics
326a296fed ; * etc/NEWS: Mention 'display-buffer-in-major-side-window' change (Bug#31194) 2018-04-18 09:10:03 +02:00
Paul Eggert
5dff4905d7 Fix signal for large integers with valid syntax
* src/lread.c (read_integer): If a radixed integer has valid syntax
but is waayyy too large, signal overflow instead of invalid syntax.
* test/src/lread-tests.el (lread-long-hex-integer): New test.
2018-04-17 16:23:48 -07:00
Lars Ingebrigtsen
2457d10ebf (sql-stop): Don't bug out if the SQL buffer is killed
* lisp/progmodes/sql.el (sql-stop): Don't bug out if the SQL
buffer is killed (bug#30244).
2018-04-18 01:22:49 +02:00
David Beswick
2e54ffebb8 Don't display an initial-buffer-choice buffer twice
* lisp/startup.el (command-line-1): Don't display an
initial-buffer-choice buffer twice if the user is also explicitly
specifying it on the mode line, but shift it to the initial place
(bug#29999).

Copyright-paperwork-exempt: yes
2018-04-17 23:54:14 +02:00
Lars Ingebrigtsen
d2d1f39536 Revert hunk mistakenly applied in last patch 2018-04-17 23:26:11 +02:00
Lars Ingebrigtsen
e3b0dd6bf1 Fix problem in `g' in Info with strings like "(foo)"
* lisp/info.el (Info-find-file): Add a new parameter to avoid
jumping to the directory if the user looks for a filename on the
form "(foo)" that doesn't exist.
(Info-read-node-name-1): Use it to allow completing over strings
like "(foo)" without losing focus (bug#30091).
2018-04-17 23:14:55 +02:00
Basil L. Contovounesios
f10fa789ca Set :version of shr faces
* lisp/net/shr.el (shr-strike-through, shr-link, shr-selected-link):
Set :version tag (bug#31200).
2018-04-17 21:46:26 +02:00
Lars Ingebrigtsen
d742d4ca2e shr doc string fix
* lisp/net/shr.el (shr-strike-through, shr-link)
(shr-selected-link): Doc string fix.
2018-04-17 21:43:34 +02:00
Basil L. Contovounesios
3dfec182d2 Modernise face specs and set version tags in eww/shr
* lisp/net/shr.el (shr-strike-through, shr-link, shr-selected-link):
Set :version tag (bug#31200).

* lisp/net/eww.el (eww-form-text, eww-form-textarea):
* lisp/net/shr.el (shr-strike-through, shr-link, shr-selected-link):
Use (DISPLAY . PLIST) face spec syntax as recommended in
'(elisp) Defining Faces'.
2018-04-17 21:42:04 +02:00
Lars Ingebrigtsen
c99ba23160 When undoing a mark-as-read, display the group if it isn't
* lisp/gnus/gnus-group.el (gnus-group-jump-to-group): Return
whether we found the group.
(gnus-info-clear-data): Make the group visible if it wasn't.

* lisp/gnus/gnus-sum.el (gnus-group-make-articles-read): Ditto.
(gnus-update-read-articles): Ditto.
2018-04-17 21:32:25 +02:00
Juri Linkov
0c9e3df3c2 Use next-error-found to set next-error-last-buffer.
https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00207.html

* lisp/simple.el (next-error-buffer): New buffer-local variable
instead of making buffer-local next-error-last-buffer.  (Bug#20489)
(next-error-found-function): New defcustom.
(next-error-buffer-on-selected-frame): Use t for avoid-current arg
of next-error-buffer-p.
(next-error-find-buffer): Add second rule for using the current
next-error-buffer if it's not visited by other navigation.
(next-error, next-error-internal): Call next-error-found.
(next-error-found): New function with body extracted mostly from
next-error.

* lisp/vc/add-log.el (change-log-goto-source-internal): New function
with body from change-log-goto-source.
(change-log-goto-source): Call change-log-goto-source-internal and
next-error-found.
(change-log-next-error): Call change-log-goto-source-internal
instead of change-log-goto-source.
(change-log-mode): Don't set next-error-last-buffer.  (Bug#28864)

* lisp/vc/diff-mode.el (diff-goto-source): Call next-error-found.

* lisp/progmodes/xref.el (xref-goto-xref): Call next-error-found.

* lisp/replace.el (occur-mode-goto-occurrence)
(occur-mode-goto-occurrence-other-window)
(occur-mode-display-occurrence): Call next-error-found.
(occur-next-error): Remove unnecessary with-current-buffer.
(Bug#27362, bug#30646)
2018-04-17 22:27:48 +03:00
Lars Ingebrigtsen
d12800303f Tweak shr window width computation
* lisp/net/shr.el (shr-insert-document): The computation of the
window width is apparently one pixel too wide for the shr line
folding algorithm (bug#31196).
2018-04-17 20:34:12 +02:00
Lars Ingebrigtsen
01a32a0f97 (gnus-summary-select-article-buffer): Further point placing tweak
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Further tweak for the previous point-placing tweak.
2018-04-17 20:09:28 +02:00
Lars Ingebrigtsen
c90984250b Tweak point placement in gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Ensure that point is where it's supposed to be after switching to
the article buffer.
2018-04-17 20:02:26 +02:00
Eli Zaretskii
3bdc9a1683 Fix flyspell-auto-correct-previous-word broken by recent change
* lisp/textmodes/flyspell.el (flyspell-auto-correct-word): Keep
flyspell-auto-correct-region also when repeatedly invoking
flyspell-auto-correct-previous-word.  (Bug#31188)
2018-04-17 20:45:51 +03:00
Lars Ingebrigtsen
62a075b016 Make the `c' command work in a single-article Gnus view
* lisp/gnus/gnus-art.el (gnus-article-read-summary-keys): Make `c'
work from the article buffer (bug#31195) when no summary buffer is
shown.
2018-04-17 19:34:40 +02:00
Lars Ingebrigtsen
1d5d23a9f6 Place point consistently in the Gnus group buffer on exit
* lisp/gnus/gnus-sum.el (gnus-summary-exit): Place point correctly
when exiting with `q' (and the like) from the article buffer when
only the article buffer is displayed (bug#31195).  This is
apparently yet another fall-out from the "preserve-visible-point-
in-windows" patches of yesteryear...
2018-04-17 19:21:42 +02:00
Lars Ingebrigtsen
950d6cc744 Reimplement shr-next-link' and shr-previous-link'
* lisp/net/shr.el (shr-next-link): Use
`text-property-search-forward'.
(shr-previous-link): Use `text-property-search-backward'.
2018-04-17 18:53:23 +02:00
Lars Ingebrigtsen
6f572972d1 Add text-property-search-forward' and -backward'
* doc/lispref/text.texi (Property Search): Document
`text-property-search-forward' and `text-property-search-backward'.

* lisp/emacs-lisp/text-property-search.el: New file.
2018-04-17 18:53:23 +02:00
Eli Zaretskii
a539eb51ac * test/src/lread-tests.el (lread-test-bug-31186): New test. 2018-04-17 18:40:41 +03:00
Tino Calancha
c969fbd40b * lisp/textmodes/artist.el (artist-mode): Ensure we have a font 2018-04-17 22:20:28 +09:00
Andreas Schwab
3fa472b487 Fix undefined behaviour while looking for lexical-binding file variable (bug 31186)
* src/lread.c (lisp_file_lexically_bound_p): Reset
beg_end_state before reading variable or value.
2018-04-17 11:43:14 +02:00
Katsumi Yamaoka
003071346c * lisp/mail/sendmail.el (mail-sendmail-undelimit-header): Work for
the case where the mail header separator has already been deleted.
2018-04-17 06:22:17 +00:00
Lars Ingebrigtsen
b0d261e29e (gnus-group-goto-group): Return correct value after previous patch
* lisp/gnus/gnus-group.el (gnus-group-goto-group): Return the
correct value after the previous patch.
2018-04-17 02:11:02 +02:00
Lars Ingebrigtsen
c8be645598 Fix inconsistent point movement in the Gnus group buffer
* lisp/gnus/gnus-group.el (gnus-group-goto-group): If we can't
find the group we're looking for, then don't move point at all
(bug#23021).
2018-04-16 23:10:03 +02:00
Lars Ingebrigtsen
36e5673753 (artist-mode): Warn about proportional fonts
* lisp/textmodes/artist.el (artist-mode): Warn about proportional
fonts (bug#24175).
2018-04-16 21:20:08 +02:00
Lars Ingebrigtsen
e1a0cbbcf8 Make mail-sendmail-undelimit-header actually remove the delimiter
* lisp/mail/sendmail.el (mail-sendmail-undelimit-header): Actually
remove the mail header separator (bug#17488).  In all the cases
where this is called, the separator will probably already have
been removed, so the only thing this does is place point at the
end of the headers.
2018-04-16 13:58:39 +02:00
Lars Ingebrigtsen
6ec3ec7fbe (semantic-symref-results-mode-map): Fix typo in previous check-in
* lisp/cedet/semantic/symref/list.el
(semantic-symref-results-mode-map): Fix typo in previous check-in.
2018-04-16 13:48:44 +02:00
Philipp Stephani
9f2d21ca53 Avoid undefined behavior in 'defvar' (Bug#31072)
* src/eval.c (Fdefvar): Check that first argument is a symbol.
* test/src/eval-tests.el (defvar/bug31072): New unit test.
2018-04-15 23:50:06 -07:00
Stefan Monnier
836dce63c3 EUDC: Enable lexical binding and do some cleanups
* lisp/net/eudc.el: Enable lexical binding.
(cl-lib): Always require cl-lib, not only when byte compiling.
(eudc-mode-map): Set parent keymap within let form.
(eudc-update-local-variables): Use #' read syntax for function
argument to map function.
(eudc-select): Likewise.
(eudc-format-attribute-name-for-display): Likewise
(eudc-filter-duplicate-attributes): Likewise.
(eudc-format-query): Likewise.
(eudc-expand-inline): Likewise.
(eudc-query-form): Likewise.
(eudc-print-attribute-value): Use mapc instead of mapcar.
(eudc-filter-partial-records): Use cl-every.
(eudc-distribute-field-on-records): Use delete-dups to
simplify function.
(eudc-expand-inline): Replace while with dolist and let form.
(eudc-query-form): Set inhibit-read-only after switching
buffers.  Remove useless and call.
(eudc-load-eudc): Add a FIXME comment.
2018-04-15 19:24:15 -04:00
Rüdiger Sonderfeld
7d0fa6081e In HTML mode, don't match </ with the wrong /
* lisp/textmodes/sgml-mode.el (sgml-slash): In HTML mode, don't
match <br /><h1>...</ with the preceding / (bug#16508).
2018-04-15 23:56:24 +02:00
Lars Ingebrigtsen
99323422a5 Use quit-buffer instead of semantic-symref-hide-buffer
* lisp/cedet/semantic/symref/list.el
(semantic-symref-hide-buffer): Removed (bug#15857).
(semantic-symref-results-mode-map): Use quit-buffer instead.
2018-04-15 23:44:56 +02:00
Lars Ingebrigtsen
9e4cae7bc9 Doc string update for gnus-extract-address-components
* lisp/gnus/gnus-util.el (gnus-extract-address-components): Doc
update.
2018-04-15 23:12:26 +02:00
Lars Ingebrigtsen
003a89b6c8 Add an undo command to url-cookie-mode
* lisp/url/url-cookie.el (url-cookie-undo): New command and
keystroke (bug#16650).
2018-04-15 22:48:28 +02:00
Lars Ingebrigtsen
f262b10b46 Tweak the look of the cookie buffer after cookie deletion
* lisp/url/url-cookie.el (url-cookie--generate-buffer): Factor out
into its own function.
(url-cookie-delete): Use it to make the buffer look consistent
after deleting a cookie.
2018-04-15 22:36:16 +02:00
Lars Ingebrigtsen
a37a14e0a8 Make eww handle "http://a/../../../g"
* lisp/net/eww.el (eww): Strip leading elements off URLs on the
form "http://a/../../../g", because that's what all the other
browsers do (bug#8622).
2018-04-15 22:20:28 +02:00
Lars Ingebrigtsen
1c16fbd1b2 Make url-cookie-write-file be more permissive
* lisp/url/url-cookie.el (url-cookie-write-file): If
`url-cookie-file' isn't set (due to url.el not being used yet),
don't error out in this function (bug#23183).
2018-04-15 21:50:38 +02:00
Lars Ingebrigtsen
2e1caf3254 Don't warn the user about large files if they are unreadable
* lisp/files.el (abort-if-file-too-large): There's no point in
warning the user about a too-large file if we're not able to read
it (bug#29549).  Hopefully this doesn't introduce a race condition
between this test and the `file-readable-p' test later.
2018-04-15 21:03:34 +02:00
Lars Ingebrigtsen
b72de45eb0 Only save the mailer choice after sending the mail
* lisp/mail/sendmail.el (sendmail-query-once): Only save the
mailer choice after we've sent the mail, so that if that fails,
the user has an easy way to back out of the choice and make
another (bug#14487).
(sendmail-query-user-about-smtp): Return the choice; don't save it.
2018-04-15 20:42:44 +02:00
Lars Ingebrigtsen
54f7ec01c3 (compose-mail): Give a better error message for `mail-user-agent'
* lisp/simple.el (compose-mail): Give a better error message for
invalid values for `mail-user-agent' (bug#17979).
2018-04-15 20:06:27 +02:00
Lars Ingebrigtsen
1143906b79 Fix typo in gnus.texi
* doc/misc/gnus.texi (Summary Message Commands): Fix typo in last
change.
2018-04-15 19:53:27 +02:00
Lars Ingebrigtsen
652ce40c50 Update doc string after previous ietf-drums change
* lisp/mail/ietf-drums.el (ietf-drums-parse-address): Doc fix
after previous change.
2018-04-15 19:49:47 +02:00
Lars Ingebrigtsen
47d52c2255 mail-extr.el: Mention `mail-header-parse-address' in the doc string
* lisp/mail/mail-extr.el (mail-extract-address-components):
Mention `mail-header-parse-address' in the doc string.
2018-04-15 19:45:05 +02:00
Lars Ingebrigtsen
a38f79a8fd Allow `mail-header-parse-address' to decode encoded words
* lisp/mail/ietf-drums.el (ietf-drums-parse-address): Take an
optional parameter to decode the display name.
2018-04-15 19:42:10 +02:00
Eli Zaretskii
4341aacd87 Minor wording improvement in "Bookmarks"
* doc/emacs/regs.texi (Bookmarks): Improve wording.  Suggested by
"Siraphob (Ben) Phipathananunth" <siraben@disroot.org>.
2018-04-15 20:34:44 +03:00
Lars Ingebrigtsen
a3a9d5434d Revert "Make mail-extract-address-components return the user name more"
This reverts commit 8b50ae8b22.

According to tests in bug#27656 by OGAWA Hirofumi, this patch
led to wrong results when binding

(dolist (addr '("Rasmus <rasmus@gmx.us>" "Rasmus <mbox@gmx.us>"))
  (dolist (ignore-single '(t nil))
    (dolist (ignore-same '(t nil))
      (let ((mail-extr-ignore-single-names ignore-single)
	    (mail-extr-ignore-realname-equals-mailbox-name ignore-same))
	(message "%s" (mail-extract-address-components addr))))))

in combination.
2018-04-15 19:28:04 +02:00