of a new entry inside of an existing entry. Minor code cleanup.
(todo-add-category): Change the interactive spec. Signal an error
if the Todo file is non-empty but contains no category. Reject
category names that could induce bugs and confusion. Call
todo-mode if the Todo file is new and unsaved. Simplify handling
of local variables cookie. Properly display the newly added
category in Todo mode.
(todo-show): Call todo-initial-setup only if there is neither a
Todo file nor a corresponding unsaved buffer.
(todo-category-alist): Delete function.
(todo-completing-read): New function.
(todo-insert-item, todo-jump-to-category): Use it.
(todo-insert-item): Make the use of the prefix argument conform to
the doc string.
old name as alias, update callers.
(lunar-phases): Rename from phases-of-moon. Keep old name as alias.
(diary-lunar-phases): Rename from diary-phases-of-moon. Keep old name as alias.
(calendar-month-digit-width, calendar-month-width)
(calendar-right-margin): New variables.
(calendar-recompute-layout-variables, calendar-set-layout-variable):
New functions.
(calendar-left-margin, calendar-intermonth-spacing)
(calendar-column-width, calendar-day-header-width)
(calendar-day-digit-width): New options.
(calendar-first-date-row): New constant.
(calendar-move-to-column, calendar-ensure-newline): New functions,
replacing calendar-insert-indented.
(calendar-insert-indented): Remove function.
(calendar-generate-month): Use calendar-move-to-column and
calendar-ensure-newline. Use layout variables.
(calendar-generate, calendar-update-mode-line)
(calendar-font-lock-keywords): Use layout variables.
(calendar-column-to-month): New function.
(calendar-cursor-to-date): Use calendar-column-to-month.
Use layout variables.
cal-menu-today-holidays.
(cal-menu-today-holidays): Remove function.
(cal-menu-holiday-window-suffix): Simplify.
(cal-menu-list-holidays-year, cal-menu-list-holidays-following-year)
(cal-menu-list-holidays-previous-year, calendar-mouse-goto-date):
Remove unused functions.
(calendar-mouse-view-diary-entries): Use format rather than concat.
(cal-menu-x-popup-menu): Turn it into a macro.
(calendar-mouse-holidays, calendar-mouse-view-diary-entries)
(calendar-mouse-print-dates): Adapt for cal-menu-x-popup-menu change.
(cal-menu-event-to-date): Remove function.
(calendar-mouse-holidays, calendar-mouse-view-diary-entries)
(calendar-mouse-view-other-diary-entries, calendar-mouse-print-dates)
(cal-menu-set-date-title): Use calendar-cursor-to-date rather than
cal-menu-event-to-date.
(calendar-mouse-tex-day, calendar-mouse-tex-week, calendar-mouse-tex-week2)
(calendar-mouse-tex-week-iso, calendar-mouse-tex-week-monday)
(calendar-mouse-tex-filofax-daily, calendar-mouse-tex-filofax-2week)
(calendar-mouse-tex-filofax-week, calendar-mouse-tex-month)
(calendar-mouse-tex-month-landscape, calendar-mouse-tex-year)
(calendar-mouse-tex-filofax-year, calendar-mouse-tex-year-landscape):
Remove functions.
(cal-menu-context-mouse-menu): Replace the above functions with the
cal-tex versions. Add HTML submenu.
(cal-tex-cursor-year-landscape, cal-tex-cursor-filofax-year)
(cal-tex-cursor-month-landscape, cal-tex-cursor-month)
(cal-tex-cursor-week, cal-tex-cursor-week2, cal-tex-cursor-week-iso)
(cal-tex-cursor-week-monday, cal-tex-cursor-filofax-2week)
(cal-tex-cursor-filofax-week, cal-tex-cursor-filofax-daily)
(cal-tex-cursor-day): Handle mouse events. Rename ARG to N.
(cal-tex-cursor-month): Mark N as optional.
(calendar-set-mark):
* calendar/diary-lib.el (diary-insert-entry):
* calendar/solar.el (calendar-sunrise-sunset): Use it.
* calendar/cal-menu.el (calendar-mouse-sunrise/sunset)
(calendar-mouse-insert-diary-entry, calendar-mouse-set-mark): Delete.
(cal-menu-context-mouse-menu): Use calendar-set-mark, diary-insert-entry,
and calendar-sunrise-sunset instead, to get proper key-shortcuts.
name as obsolete alias. Doc fix. Change custom type and version.
(diary-list-entries-hook, diary-list-entries, diary-simple-display)
(diary-fancy-display): Doc fixes.
(diary-list-entries, diary-include-other-diary-files, diary-mail-entries):
Use diary-display-function rather than diary-display-hook.
(icalendar-version): Increase to "0.19".
(icalendar--date-style): New function.
(icalendar--datetime-to-diary-date): Doc fix. Use icalendar--date-style.
(icalendar--datestring-to-isodate): Doc fix. Handle iso date style.
(icalendar--convert-yearly-to-ical):
(icalendar--convert-recurring-to-diary): Handle iso date style,
use icalendar-date-style.
Move to calendar-faces group.
Move non-autoloaded define-obsolete-variable-alias calls for
defcustoms not in dumped files before the associated defcustom.
(calendar-today, diary, holiday): Doc fix. Move to calendar-faces group.
Move non-autoloaded define-obsolete-variable-alias calls for
defcustoms not in dumped files before the associated defcustom.
Keep old name as alias, update users.
(calendar-mark-diary-entries-flag): Rename mark-diary-entries-in-calendar.
Keep old name as alias, update users.
(calendar-view-holidays-initially-flag): Rename
view-calendar-holidays-initially. Keep old name as alias, update users.
(calendar-mark-holidays-flag): Rename mark-holidays-in-calendar.
Keep old name as alias, update users.
(calendar-initial-window-hook): Rename initial-calendar-window-hook.
Keep old name as alias, update users.
(calendar-today-visible-hook): Rename today-visible-calendar-hook.
Keep old name as alias, update users.
(calendar-today-invisible-hook): Rename today-invisible-calendar-hook.
Keep old name as alias, update users.
(diary-iso-date-forms): Rename iso-date-diary-pattern. Update users.
(diary-american-date-forms): Rename american-date-diary-pattern.
Keep old name as alias, update users.
(diary-european-date-forms): Rename european-date-diary-pattern.
Keep old name as alias, update users.
(calendar-iso-date-display-form): Rename iso-calendar-display-form.
Keep old name as alias, update users.
(calendar-european-date-display-form): Rename european-calendar-display-form.
Keep old name as alias, update users.
(calendar-american-date-display-form): Rename european-calendar-display-form.
Keep old name as alias, update users.
(diary-show-holidays-flag): Rename holidays-in-diary-buffer.
Keep old name as alias, update users.
(holiday-general-holidays): Rename general-holidays. Keep old name as alias,
update users.
(holiday-oriental-holidays): Rename oriental-holidays. Keep old name as alias,
update users.
(holiday-local-holidays): Rename local-holidays. Keep old name as alias,
update users.
(holiday-other-holidays): Rename other-holidays. Keep old name as alias,
update users.
(holiday-hebrew-holidays): Rename hebrew-holidays. Keep old name as alias,
update users.
(holiday-christian-holidays): Rename christian-holidays.
Keep old name as alias, update users.
(holiday-islamic-holidays): Rename islamic-holidays. Keep old name as alias,
update users.
(holiday-bahai-holidays): Rename bahai-holidays. Keep old name as alias,
update users.
(holiday-solar-holidays): Rename solar-holidays. Keep old name as alias,
update users.
(diary-fancy-buffer): Rename fancy-diary-buffer. Keep old name as alias,
update users.
(calendar-other-calendars-buffer): Rename other-calendars-buffer. Update users.
(calendar-hebrew-yahrzeit-buffer): Rename cal-hebrew-yahrzeit-buffer.
Update users.
(calendar-increment-month): Rename increment-calendar-month.
Keep old name as alias, update callers.
(calendar-increment-month-cons): Rename old calendar-increment-month.
Update callers.
(calendar-extract-month): Rename extract-calendar-month.
Keep old name as alias, update callers
(calendar-extract-day): Rename extract-calendar-day. Keep old name as alias,
update callers.
(calendar-extract-year): Rename extract-calendar-year. Keep old name as alias,
update callers.
(calendar-generate-window): Rename generate-calendar-window. Update callers.
(calendar-generate): Rename generate-calendar. Update callers.
(calendar-generate-month): Rename generate-calendar-month. Update callers.
(calendar-redraw): Rename redraw-calendar. Update callers.
(calendar-describe-mode): Rename describe-calendar-mode. Update uses.
(calendar-mouse-other-month): Rename mouse-calendar-other-month.
Update callers.
(calendar-update-mode-line): Rename update-calendar-mode-line. Update callers.
(calendar-exit): Rename exit-calendar. Keep old name as alias, update callers.
(calendar-mark-visible-date): Rename mark-visible-calendar-date.
Keep old name as alias, update callers.
Keep old name as alias, update users.
(diary-list-entries-hook): Rename list-diary-entries-hook.
Keep old name as alias, update users.
(diary-mark-entries-hook): Rename mark-diary-entries-hook.
Keep old name as alias, update users.
(diary-nongregorian-listing-hook): Rename nongregorian-diary-listing-hook.
Keep old name as alias, update users.
(diary-nongregorian-marking-hook): Rename nongregorian-diary-marking-hook.
Keep old name as alias, update users.
(diary-print-entries-hook): Rename print-diary-entries-hook.
Keep old name as alias, update users.
(diary-abbreviated-year-flag): Rename abbreviated-calendar-year.
Keep old name as alias, update users.
(diary-number-of-entries): Rename number-of-diary-entries.
Keep old name as alias, update users.
(view-diary-entries, list-diary-entries, show-all-diary-entries):
Give version of obsolescence.
(diary-view-other-diary-entries): Rename view-other-diary-entries.
Keep old name as alias, update callers.
(diary-add-to-list): Rename add-to-diary-list. Keep old name as alias,
update callers.
(diary-include-other-diary-files): Rename include-other-diary-files.
Keep old name as alias, update callers.
(diary-simple-display): Rename simple-diary-display. Keep old name as alias,
update callers.
(diary-fancy-display): Rename fancy-diary-display. Keep old name as alias,
update callers.
(diary-print-entries): Rename print-diary-entries. Keep old name as alias,
update callers.
(diary-marking-entries-flag): Rename marking-diary-entries. Update users.
(diary-marking-entry-flag): Rename marking-diary-entry. Update users.
(diary-mark-entries): Rename mark-diary-entries. Keep old name as alias,
update callers.
(diary-mark-sexp-entries): Rename mark-sexp-diary-entries.
Keep old name as alias, update callers.
(diary-mark-included-diary-files): Rename mark-included-diary-files.
Keep old name as alias, update callers.
(calendar-mark-days-named): Rename mark-calendar-days-named.
Keep old name as alias, update callers.
(calendar-mark-month): Rename mark-calendar-month. Keep old name as alias,
update callers.
(calendar-mark-date-pattern): Rename mark-calendar-date-pattern.
Keep old name as alias, update callers.
(diary-sort-entries): Rename sort-diary-entries. Keep old name as alias,
update callers.
(diary-list-sexp-entries): Rename list-sexp-diary-entries.
Keep old name as alias, update callers.
(diary-make-entry): Rename make-diary-entry. Keep old name as alias,
update callers.
(diary-insert-entry): Rename insert-diary-entry. Keep old name as alias.
(diary-insert-weekly-entry): Rename insert-weekly-diary-entry.
Keep old name as alias.
(diary-insert-monthly-entry): Rename insert-monthly-diary-entry.
Keep old name as alias.
(diary-insert-yearly-entry): Rename insert-yearly-diary-entry.
Keep old name as alias.
(diary-insert-anniversary-entry): Rename insert-anniversary-diary-entry.
Keep old name as alias.
(diary-insert-block-entry): Rename insert-block-diary-entry.
Keep old name as alias.
(diary-insert-cyclic-entry): Rename insert-cyclic-diary-entry.
Keep old name as alias.
(diary-fancy-font-lock-keywords): Rename fancy-diary-font-lock-keywords.
Keep old name as alias, update users.
(diary-fancy-display-mode): Rename fancy-diary-display-mode.
Keep old name as alias, update callers.
Move here from solar.el and rename. Doc fix. Keep old name as alias.
(solar-setup, solar-sunrise-sunset, calendar-latitude)
(calendar-longitude, calendar-time-zone): Declare for compiler.
(calendar-chinese-time-zone): Rename chinese-calendar-time-zone.
Keep old name as alias, update users.
(calendar-chinese-location-name): Rename chinese-calendar-location-name.
Keep old name as alias.
(calendar-chinese-daylight-time-offset):
Rename chinese-calendar-daylight-time-offset. Keep old name as alias,
update users.
(calendar-chinese-standard-time-zone-name):
Rename chinese-calendar-standard-time-zone-name.
Keep old name as alias, update users.
(calendar-chinese-daylight-saving-start):
Rename chinese-calendar-daylight-savings-starts.
Keep old name as alias, update users.
(calendar-chinese-daylight-saving-end):
Rename chinese-calendar-daylight-savings-ends. Keep old name as alias,
update users.
(calendar-chinese-daylight-saving-start-time):
Rename chinese-calendar-daylight-savings-starts-time.
Keep old name as alias, update users.
(calendar-chinese-daylight-saving-end-time):
Rename chinese-calendar-daylight-savings-ends-time.
Keep old name as alias, update users.
(calendar-chinese-celestial-stem): Rename
calendar-chinese-celestial-stem. Keep old name as alias, update users.
(calendar-chinese-terrestrial-branch):
Rename calendar-chinese-terrestrial-branch. Keep old name as alias,
update users.
(calendar-chinese-zodiac-sign-on-or-after):
Rename chinese-zodiac-sign-on-or-after. Update callers.
(calendar-chinese-new-moon-on-or-after): Rename chinese-new-moon-on-or-after.
Update callers.
(calendar-chinese-month-list): Rename chinese-month-list. Update callers.
(calendar-chinese-number-months): Rename number-chinese-months. Update callers.
(calendar-chinese-compute-year): Rename compute-chinese-year. Update callers.
(calendar-chinese-year-cache): Rename chinese-year-cache. Update users.
(calendar-chinese-year): Rename chinese-year. Update callers.
(calendar-chinese-year-cache-init): Rename chinese-year-cache-init.
(calendar-chinese-to-absolute): Rename calendar-absolute-from-chinese.
Keep old name as alias, update callers.
(calendar-chinese-print-date): Rename calendar-print-chinese-date.
Keep old name as alias, update callers.
(calendar-chinese-months-to-alist): Rename make-chinese-month-assoc-list.
Update callers.
(calendar-chinese-months): Rename chinese-months. Update callers.
(calendar-chinese-goto-date): Rename calendar-goto-chinese-date.
Keep old name as alias, update callers.
Update callers.
(calendar-hebrew-last-month-of-year): Rename hebrew-calendar-last-month-of-year.
Update callers.
(calendar-hebrew-elapsed-days): Rename hebrew-calendar-elapsed-days.
Update callers.
(calendar-hebrew-days-in-year): Rename hebrew-calendar-days-in-year.
Update callers.
(calendar-hebrew-long-heshvan-p): Rename hebrew-calendar-long-heshvan-p.
Update callers.
(calendar-hebrew-short-kislev-p): Rename hebrew-calendar-short-kislev-p.
Update callers.
(calendar-hebrew-last-day-of-month): Rename hebrew-calendar-last-day-of-month.
Update callers.
(calendar-hebrew-to-absolute): Rename calendar-absolute-from-hebrew.
Keep old name as alias, update callers.
(calendar-hebrew-print-date): Rename calendar-print-hebrew-date.
Keep old name as alias, update callers.
(calendar-hebrew-yahrzeit): Rename hebrew-calendar-yahrzeit.
Keep old name as alias, update callers.
(calendar-hebrew-goto-date): Rename calendar-goto-hebrew-date.
Keep old name as alias.
(holiday-hebrew-rosh-hashanah): Rename holiday-rosh-hashanah-etc.
Keep old name as alias.
(holiday-hebrew-hanukkah): Rename holiday-hanukkah. Keep old name as alias.
(holiday-hebrew-passover): Rename holiday-passover-etc.
Keep old name as alias.
(holiday-hebrew-tisha-b-av): Rename holiday-tisha-b-av-etc.
Keep old name as alias, update callers.
(diary-hebrew-list-entries): Rename list-hebrew-diary-entries.
Keep old name as alias.
(calendar-hebrew-mark-date-pattern): Rename mark-hebrew-calendar-date-pattern.
Keep old name as alias, update callers.
(diary-hebrew-mark-entries): Rename mark-hebrew-diary-entries.
Keep old name as alias.
(diary-hebrew-insert-entry): Rename insert-hebrew-diary-entry.
Keep old name as alias.
(diary-hebrew-insert-monthly-entry): Rename insert-monthly-hebrew-diary-entry.
Keep old name as alias.
(diary-hebrew-insert-yearly-entry): Rename insert-yearly-hebrew-diary-entry.
Keep old name as alias.
(calender-hebrew-list-yahrzeits): Rename list-yahrzeit-dates.
Keep old name as alias.
(diary-hebrew-omer): Rename diary-omer. Keep old name as alias.
(diary-hebrew-yahrzeit): Rename diary-yahrzeit. Keep old name as alias.
(diary-hebrew-rosh-hodesh): Rename diary-rosh-hodesh. Keep old name as alias.
(calendar-hebrew-parashiot-names): Rename hebrew-calendar-parashiot-names.
Update callers.
(calendar-hebrew-parasha-name): Rename hebrew-calendar-parasha-name.
(calendar-hebrew-year-Saturday-incomplete-Sunday):
Rename hebrew-calendar-year-Saturday-incomplete-Sunday.
(calendar-hebrew-year-Saturday-complete-Tuesday):
Rename hebrew-calendar-year-Saturday-complete-Tuesday.
(calendar-hebrew-year-Monday-incomplete-Tuesday):
Rename hebrew-calendar-year-Monday-incomplete-Tuesday.
(calendar-hebrew-year-Monday-complete-Thursday):
Rename hebrew-calendar-year-Monday-complete-Thursday.
(calendar-hebrew-year-Tuesday-regular-Thursday):
Rename hebrew-calendar-year-Tuesday-regular-Thursday.
(calendar-hebrew-year-Thursday-regular-Saturday):
Rename hebrew-calendar-year-Thursday-regular-Saturday.
(calendar-hebrew-year-Thursday-complete-Sunday):
Rename hebrew-calendar-year-Thursday-complete-Sunday.
(calendar-hebrew-year-Saturday-incomplete-Tuesday):
Rename hebrew-calendar-year-Saturday-incomplete-Tuesday.
(calendar-hebrew-year-Saturday-complete-Thursday):
Rename hebrew-calendar-year-Saturday-complete-Thursday.
(calendar-hebrew-year-Monday-incomplete-Thursday):
Rename hebrew-calendar-year-Monday-incomplete-Thursday.
(calendar-hebrew-year-Monday-complete-Saturday):
Rename hebrew-calendar-year-Monday-complete-Saturday.
(calendar-hebrew-year-Tuesday-regular-Saturday):
Rename hebrew-calendar-year-Tuesday-regular-Saturday.
(calendar-hebrew-year-Thursday-incomplete-Sunday):
Rename hebrew-calendar-year-Thursday-incomplete-Sunday.
(calendar-hebrew-year-Thursday-complete-Tuesday):
Rename hebrew-calendar-year-Thursday-complete-Tuesday.
(diary-hebrew-parasha): Rename diary-parasha. Keep old name as alias.
Update for above name changes of constants.
Keep old name as alias.
(diary-islamic-entry-symbol): Rename islamic-diary-entry-symbol.
Keep old name as alias.
(diary-bahai-entry-symbol): Rename bahai-diary-entry-symbol.
Keep old name as alias.
(hebrew-holidays-1, hebrew-holidays-2, hebrew-holidays-3)
(hebrew-holidays-4): Don't autoload obsolescence.
calendar-string-to-mayan-long-count. Update callers.
(calendar-mayan-print-date): Rename calendar-print-mayan-date.
Update callers, keep old name as alias.
(calendar-mayan-read-haab-date): Rename calendar-read-mayan-haab-date.
Update callers.
(calendar-mayan-read-tzolkin-date): Rename calendar-read-mayan-tzolkin-date.
Update callers.
(calendar-mayan-next-haab-date): Rename calendar-next-haab-date.
Keep old name as alias.
(calendar-mayan-previous-haab-date): Rename calendar-previous-haab-date.
Keep old name as alias.
(calendar-mayan-next-tzolkin-date): Rename calendar-next-tzolkin-date.
Keep old name as alias.
(calendar-mayan-previous-tzolkin-date): Rename calendar-previous-tzolkin-date.
Keep old name as alias.
(calendar-mayan-next-round-date): Rename calendar-next-calendar-round-date.
Keep old name as alias.
(calendar-mayan-previous-round-date): Rename
calendar-previous-calendar-round-date. Keep old name as alias.
(calendar-mayan-long-count-to-absolute): Rename
calendar-absolute-from-mayan-long-count. Keep old name as alias.
(calendar-mayan-goto-long-count-date): Rename
calendar-goto-mayan-long-count-date. Keep old name as alias.
Update callers, keep old name as alias.
(calendar-iso-print-date): Rename calendar-print-iso-date.
Update callers, keep old name as alias.
(calendar-iso-goto-date): Rename calendar-goto-iso-date.
Keep old name as alias.
(calendar-iso-goto-week): Rename calendar-goto-iso-week.
Keep old name as alias.
(calendar-islamic-leap-year-p): Rename islamic-calendar-leap-year-p.
Update callers.
(calendar-islamic-last-day-of-month): Rename islamic-calendar-last-day-of-month.
Update callers.
(calendar-islamic-day-number): Rename islamic-calendar-day-number.
Update callers.
(calendar-islamic-to-absolute): Rename calendar-absolute-from-islamic.
Update callers, keep old name as alias.
(calendar-islamic-print-date): Rename calendar-print-islamic-date.
Update callers, keep old name as alias.
(calendar-islamic-goto-date): Rename calendar-goto-islamic-date.
Keep old name as alias.
(diary-islamic-list-entries): Rename list-islamic-diary-entries.
Update callers, keep old name as alias.
(calendar-islamic-mark-date-pattern): Rename mark-islamic-calendar-date-pattern.
Update callers, keep old name as alias.
(diary-islamic-insert-entry): Rename insert-islamic-diary-entry.
Keep old name as alias.
(diary-islamic-insert-monthly-entry): Rename insert-monthly-islamic-diary-entry.
Keep old name as alias.
(diary-islamic-insert-yearly-entry): Rename insert-yearly-islamic-diary-entry.
Keep old name as alias.
Update callers, keep old name as alias.
(calendar-julian-print-date): Rename calendar-print-julian-date.
Update callers, keep old name as alias.
(calendar-julian-goto-date): Rename calendar-goto-julian-date.
Update callers, keep old name as alias.
(calendar-astro-to-absolute): Rename calendar-absolute-from-astro.
Update callers, keep old name as alias.
(calendar-astro-print-day-number): Rename
calendar-print-astro-day-number. Update callers, keep old name as alias.
(calendar-astro-goto-day-number): Rename calendar-goto-astro-day-number.
Update callers, keep old name as alias.
Rename all-hebrew-calendar-holidays. Update callers, keep old name as alias.
(calendar-christian-all-holidays-flag): Rename
all-christian-calendar-holidays. Update callers, keep old name as alias.
(calendar-islamic-all-holidays-flag): Rename
all-islamic-calendar-holidays. Update callers, keep old name as alias.
(calendar-bahai-all-holidays-flag): Rename all-bahai-calendar-holidays.
Update callers, keep old name as alias.
(holiday-filter-visible-calendar): Doc fix. Use mapcar.
(holiday-easter-etc): Fix nesting of result. Tweak holiday order.
Use calendar-date-is-visible-p, not holiday-filter-visible-calendar.
Make obsolete.
(hebrew-holidays-2): Just use holiday-hanukkah now it respects
all-hebrew-calendar-holidays.
(hebrew-holidays, christian-holidays, islamic-holidays, bahai-holidays):
Simplify using new functions.
(generate-calendar-window): Use bound-and-true-p.
Doc fix. Add optional argument. Simplify.
(holiday-tisha-b-av-etc): Use memq rather than unless.
(holiday-julian): Autoload it.
(holiday-hebrew-misc): New function.
(appt-display-message): Move beep before display.
(appt-check): Make interactive. Reduce the number of lets.
Use string-equal to compare mode-line strings.
(appt-disp-window): Pluralize "minute" as needed. Make appt buffer read-only.
(appt-select-lowest-window, appt-make-list): Reduce the number of lets.
(appt-delete): Simplify.
(mark-visible-calendar-date): Check for font-lock-mode before using faces.
(hebrew-holidays-3, generate-calendar-month)
(calendar-gregorian-from-absolute): Reduce the number of lets.
(hebrew-holidays-4, generate-calendar-window): Simplify.
(calendar-for-loop): Make obsolete.
(calendar-nth-named-day): Doc fix.
(calendar-holiday-list, holiday-easter-etc): Simplify by using mapcar.
(calendar-list-holidays): Return holiday-list.
(list-holidays): Use let rather than let*. Remove un-needed locals
`d', `never'.
(calendar-check-holidays): Return result from dolist.
(holiday-float): Use a single let*. Simplify if-and to and.
(holiday-sexp, holiday-advent, holiday-greek-orthodox-easter): Use a
single let*.
(mark-visible-calendar-date): Also use overlay for mark characters.
(calendar-unmark): Unmark by removing all overlays, rather than redrawing.
(calendar-starred-day): Remove.
(calendar-mode): Disable undo. Don't make calendar-starred-day local.
(calendar-cursor-to-date): No need for special star handling now using overlays.
(calendar-star-date): Use overlays.
(calendar-hebrew-date-is-visible-p): Extract some common code into
separate function.
(holiday-hebrew, mark-hebrew-calendar-date-pattern): Use it.
(calendar-hebrew-from-absolute, holiday-hanukkah)
(mark-hebrew-calendar-date-pattern): Reduce nesting of some lets.
(insert-hebrew-diary-entry, insert-monthly-hebrew-diary-entry)
(insert-yearly-hebrew-diary-entry): Use diary-insert-entry-1.
(diary-make-date): Autoload it.
(diary-yahrzeit): Doc fix. Use diary-make-date.
icalendar--datetime-to-noneuropean-date. Make old name obsolete alias.
(icalendar--datetime-to-iso-date): New function.
(icalendar--datetime-to-diary-date): Doc fix. Respect
calendar-date-style if bound.
(european-date-diary-pattern,european-calendar-display-form)
(american-calendar-display-form, diary-display-hook): Doc fixes.
(european-calendar-style): Doc fix. Use calendar-set-date-style for
custom :set. Mark as obsolete.
(calendar-date-style, iso-date-diary-pattern)
(iso-calendar-display-form): New user variables.
(diary-date-forms, calendar-date-display-form): Set using
calendar-date-style. Doc fix.
(calendar-set-date-style): New command.
(european-calendar, american-calendar): Use calendar-set-date-style.
Mark as obsolete.
(cal-menu-list-holidays-following-year, cal-menu-list-holidays-previous-year):
Simplify now that 2nd arg of holiday-list is optional.
(calendar-mouse-holidays): Remove un-needed local `l'.
(list-diary-entries-hook, mark-diary-entries-hook)
(include-other-diary-files, mark-included-diary-files): Doc fixes.
(diary-set-header): New function.
(diary-header-line-flag, diary-header-line-format):
Use diary-set-header for custom :set function.
(diary-set-maybe-redraw): Use symbol-value rather than eval.
(diary-attrtype-convert): Use intern-soft rather than read.
(diary-display-no-entries): New function.
(simple-diary-display, fancy-diary-display): Use it.
(fancy-diary-display): Doc fix. Remove unneeded local entry-list.
(calendar-and-diary-frame-parameters): Doc fixes.
(make-fancy-diary-buffer): Remove declaration.
(calendar-dedicate-diary): Replace call to deleted function
make-fancy-diary-buffer.
(calendar-frame-setup): New function.
(calendar-one-frame-setup, calendar-only-one-frame-setup)
(calendar-two-frame-setup): Call calendar-frame-setup to do the actual
work, and mark as obsolete.
(special-display-buffer-names): Don't mess with this; it's not our business.
(cal-x-load-hook): Defvar it, and mark as obsolete.
(calendar-mouse-print-dates): Use calendar-other-dates.
(calendar-mouse-holidays): Re-use the title.
(calendar-mouse-view-diary-entries): Use or.
(calendar-mouse-chinese-date): Remove unused command.
(cal-menu-load-hook): Mark as obsolete.