1
0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2025-01-17 17:58:46 +00:00
Commit Graph

2032 Commits

Author SHA1 Message Date
Paul Eggert
529a133c39 * movemail.c: Fix race condition and related bugs (Bug#8836).
(main) [!MAIL_USE_SYSTEM_LOCK]: Prefer mkstemp to mktemp, as this
fixes some race conditions.  Report mkstemp/mktemp errno rather
than a possibly-garbage errno.  Reinitialize the template each
time through the loop, as earlier mkstemp/mktemp calls could have
trashed it.  Pass 0600 (not 0666) to mktemp, for consistency
with mkstemp; the permissions don't matter anyway.
2011-06-10 10:50:07 -07:00
Dan Nicolaescu
fe91f5a091 * lib-src/emacsclient.c (socket_status): Use constant pointer. 2011-06-01 10:15:27 -07:00
Paul Eggert
55d4c1b248 [ChangeLog]
Use 'inline', not 'INLINE'.
* configure.in, autogen/config.in (INLINE): Remove.
[lib-src/ChangeLog]
Use 'inline', not 'INLINE'.
* etags.c (hash): Now inline unconditionally.
* make-docfile.c (put_char): inline, not INLINE.
[nt/ChangeLog]
Use 'inline', not 'INLINE'.
* config.nt (INLINE): Remove.
[src/ChangeLog]
Use 'inline', not 'INLINE'.
* alloc.c, fontset.c (INLINE): Remove.
* alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
* intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
* xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
* gmalloc.c (register_heapinfo): Use inline unconditionally.
* lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2011-05-28 15:39:39 -07:00
Glenn Morris
497c74cdc9 * lib-src/Makefile.in (all, clean): Use $EXE_FILES. 2011-05-25 00:13:57 -07:00
Glenn Morris
e949074338 Small further clean-up in lib-src/Makefile.in
* lib-src/Makefile.in (.c.o): Remove (every .o file has an explicit rule).
(insrcdir): New.
(stamp-rcs2log, stamp-rcs-checkin, stamp-grep-changelog, stamp-vcdiff):
Use $insrcdir to suppress unaesthetic ignored errors.
(clean): Simplify list of things to delete.
2011-05-24 19:33:35 -07:00
Glenn Morris
d114d4f36e * lib-src/Makefile.in (movemail${EXEEXT}): Build in one step, not via .o file. 2011-05-24 21:32:34 -04:00
Glenn Morris
7bdede3f5e Tiny simplifications in lib-src/Makfile.in
* lib-src/Makfile.in (REGEXPOBJ, REGEXPDEPS): Remove.  Replace by expansion.
(etags${EXEEXT}): Just depend on regex.o, not regex.h as well.
2011-05-24 21:23:14 -04:00
Glenn Morris
1c728a9d3c * lib-src/Makefile.in (update-game-score${EXEEXT}): Use a single rule. 2011-05-23 20:43:17 -07:00
Glenn Morris
8d366f40eb * lib-src/etags.c: Fix typo in previous comment change. 2011-05-20 19:27:00 -07:00
Glenn Morris
e5638bc123 * lib-src/etags.c: Comment. 2011-05-20 19:08:21 -07:00
Glenn Morris
4a72048482 Remove the SOME_MACHINE_LISP distinction in src/Makefile.in.
See discussion in http://debbugs.gnu.org/8302

* configure.in (NS_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
(WINDOW_SUPPORT): Remove output variables that are no longer used.

* lib-src/makefile.w32-in (echolisp): Remove rule that is no longer needed.
(clean): No more echolisp.tmp.

* .bzrignore: Remove lib-src/echolisp.tmp.

* lisp/emacs-lisp/autoload.el (batch-update-autoloads):
Set autoload-excludes by parsing lisp/loadup.el rather than Makefiles.

* lisp/loadup.el: Update commentary.

* msdos/sed1x.inp (TOOLTIP_SUPPORT, WINDOW_SUPPORT):
* msdos/sed1v2.inp (MSDOS_SUPPORT, NS_SUPPORT, MOUSE_SUPPORT)
(TOOLTIP_SUPPORT, WINDOW_SUPPORT): No need to edit these any more.

* src/Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
(REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
(BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
(lisp): Set the order to that of loadup.el.
(shortlisp): Make it a copy of $lisp.
(SOME_MACHINE_LISP): Remove.
($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
Use just $shortlisp, not $SOME_MACHINE_LISP too.
2011-05-18 23:04:16 -07:00
Glenn Morris
c136e5cdf2 Remove lib-src/fakemail.c.
* lib-src/fakemail.c: Remove file.

* lib-src/Makefile.in (UTILITIES): Remove fakemail${EXEEXT}.
(fakemail${EXEEXT}): Remove rule.

* lib-src/makefile.w32-in ($(BLD)/fakemail.exe, fakemail)
($(BLD)/fakemail.$(O)): Remove.

* lisp/mail/sendmail.el (sendmail-program): Fall back to just "sendmail".

* lisp/mail/feedmail.el: Update commentary.

* doc/emacs/ack.texi (Acknowledgments): Remove fakemail.c.

* etc/NEWS: Mention this.

* INSTALL: Remove fakemail.
2011-05-17 20:39:45 -07:00
Ted Zlatanov
17519c9050 Fix verb tense in ChangeLog message. 2011-04-26 07:49:53 -05:00
Ted Zlatanov
418401a53f Add GnuTLS support for W32.
* lib-src/makefile.w32-in (obj): Added gnutls.o.
2011-04-24 20:28:55 -05:00
Paul Eggert
fd35b6f967 Static checks with GCC 4.6.0 and non-default toolkits. 2011-04-16 16:11:35 -07:00
Paul Eggert
68afa9ca47 * pop.c: Undo previous change. 2011-04-16 15:32:35 -07:00
Paul Eggert
fe3bfdde8d * pop.c (socket_connection): Double-cast to avoid GCC warning
about alignment.
2011-04-16 14:21:24 -07:00
Paul Eggert
5a9c1e26a7 * movemail.c (mail_spool_name): Protoize.
(main): Remove unused var.  Mark var as initialized.
Move locals to avoid shadowing, and use time_t for times.
2011-04-16 14:20:25 -07:00
Paul Eggert
cd52b2441e * fakemail.c (xmalloc, xreallc): Use standard C prototypes
with void *.  This avoids warnings about pointer casts.
2011-04-16 14:13:07 -07:00
Paul Eggert
c5443aa547 * emacsclient.c (main): Don't use uninitialized var.
(IS_ANY_SEP): Remove; unused.
(get_current_dir_name): Add an extern decl.
2011-04-16 14:11:28 -07:00
Juanma Barranquero
3338398778 Update and split ChangeLogs. 2011-04-06 14:18:10 +02:00
Paul Eggert
41cf7d1aec Fix more problems found by GCC 4.6.0's static checks. 2011-04-05 22:19:39 -07:00
Paul Eggert
72b04a8a97 * emacsclient.c (message): Mark it as a printf-like function. 2011-04-05 12:59:58 -07:00
Paul Eggert
8e48d7bc3f * make-docfile.c (IF_LINT): New macro, copied from emacsclient.c.
(write_c_args): Use it to suppress GCC warning.
2011-04-01 13:28:50 -07:00
Paul Eggert
77861b9528 Fix more problems found by GCC 4.6.0's static checks. 2011-03-29 17:39:12 -07:00
Paul Eggert
8c422c3083 * etags.c (just_read_file): Remove dummy variable and simplify. 2011-03-28 23:54:38 -07:00
Glenn Morris
9af30bdf17 Remove (RET)SIGTYPE; it is identical to void on all supported systems.
Ref: http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg01068.html

* configure.in (AC_TYPE_SIGNAL): Remove obsolete macro.
(AH_BOTTOM): Do not define SIGTYPE.

* lib-src/emacsclient.c: Replace SIGTYPE with void.

* nt/config.nt: Remove RETSIGTYPE, SIGTYPE (identical to void).

* src/syssignal.h: Replace RETSIGTYPE with void.

* src/atimer.c, src/data.c, src/dispnew.c, src/emacs.c, src/floatfns.c:
* src/keyboard.c, src/keyboard.h, src/lisp.h, src/process.c, src/sysdep.c:
* src/xterm.c: Replace SIGTYPE with void everywhere.

* src/s/template.h (SIGTYPE): Remove commented out definition.
* src/s/usg5-4-common.h (SIGTYPE): Remove definition.

* admin/CPP-DEFINES: Remove SIGTYPE.
2011-03-26 19:27:11 -07:00
Juanma Barranquero
9c88f33949 w32: Fix some warnings reported by -Wall -Wextra.
* lib-src/ntlib.c: Include <ctype.h>.

* nt/cmdproxy.c: Include <ctype.h>.
  (make_absolute): Remove unused variable `i'.

* src/w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
  (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
  (Fx_close_connection): Remove unused variable `i'.

* src/w32font.c (w32font_draw): Return number of glyphs.
  (w32font_open_internal): Remove unused variable `i'.
  (w32font_driver): Add missing initializer.

* src/w32menu.c (utf8to16): Remove unused variable `utf16'.
  (fill_in_menu): Remove unused variable `items_added'.

* src/w32term.c (last_mouse_press_frame): Remove static global variable.
  (w32_clip_to_row): Remove unused variable `f'.
  (x_delete_terminal): Remove unused variable `i'.

* src/w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
  (NOTHING): Remove unused static global variable.
  (uniscribe_check_otf): Remove unused variable `table'.
  (uniscribe_font_driver): Add missing initializers.
2011-03-23 17:25:38 +01:00
Glenn Morris
8cc1d51933 Replace mkinstalldirs with `install-sh -d', as automake recommends.
* Makefile.in (mkdir): Use `install-sh -d' instead of mkinstalldirs.
(sync-from-gnulib): Don't sync mkinstalldirs.

* make-dist: Don't distribute mkinstalldirs.

* leim/Makefile.in (install): Use `install-sh -d' rather than mkinstalldirs.

* lib-src/Makefile.in ($(DESTDIR)${archlibdir}):
Use `install-sh -d' rather than mkinstalldirs.

* configure.in, doc/emacs/Makefile.in: Update comments.

* admin/notes/copyright: Remove mkinstalldirs.
2011-03-22 20:09:55 -07:00
Paul Eggert
c9c49752e1 Fix more problems found by GCC 4.5.2's static checks. 2011-03-22 18:01:59 -07:00
Paul Eggert
b1f961e1fa * ebrowse.c: Use size_t, not int, for sizes.
This avoids a warning with gcc -Wstrict-overflow, and works
better for very large objects.
(inbuffer_size): Now size_t.  All uses changed.
(xmalloc, xrealloc, operator_name, process_file): Use size_t for
sizes.  Don't bother testing whether a size_t value can be negative.
2011-03-21 11:03:15 -07:00
Paul Eggert
58cb46fbf4 * etags.c (Ada_funcs): Redo slightly to avoid overflow warning. 2011-03-21 09:41:03 -07:00
Paul Eggert
3ef271f27f etags: In Prolog functions, don't assume int fits in size_t.
This avoids a warning with gcc -Wstrict-overflow.
* etags.c (Prolog_functions, prolog_pr, prolog_atom): Use size_t,
not int, to store sizes.
(prolog_atom): Return 0, not -1, on error.  All callers changed.
2011-03-21 09:40:05 -07:00
Paul Eggert
5d6d7e5701 Add Bug#. 2011-03-21 09:22:16 -07:00
Paul Eggert
f0d80d43ba update-game-score: fix bug with -r
* update-game-score.c (main): Don't set 'scores' to garbage when
-r is specified and scorecount != MAX_SCORES.  This bug was
introduced in the 2002-04-10 change, and was found with gcc
-Wstrict-overflow (GCC 4.5.2, x86-64).
2011-03-21 00:46:53 -07:00
Paul Eggert
d5cad867ec [ChangeLog]
fakemail: Remove dependency on ignore-value.
* Makefile.in (GNULIB_MODULES): Add stdio.
* lib/stdio.in.h, m4/stdio_h.m4: New files, automatically
imported from gnulib.
[lib-src/ChangeLog]
fakemail: Remove dependency on ignore-value.
This undoes some of the recent fakemail-related changes.
It is made possible due to recent changes to gnulib's stdio module.
* Makefile.in (fakemail${EXEEXT}): Do not depend on ignore-value.h.
* fakemail.c: Do not include ignore-value.h.
(put_line): Do not use ignore_value.
2011-03-20 22:04:41 -07:00
Juanma Barranquero
e18c0aa335 Remove unnecessary "(tiny change)" markers. 2011-03-07 22:16:42 +01:00
Drake Wilson
0b973fc594 Add --quiet option for emacsclient (bug#663) (tiny change)
* lib-src/emacsclient.c (longopts): Add quiet.
(decode_options): Handle q/quiet.
(print_help_and_exit): Add q/quiet.
(main): Suppress some messages if quiet option is used.

* doc/emacs/misc.texi (emacsclient Options): Add q/quiet.
2011-03-02 23:00:23 -08:00
Eli Zaretskii
00030ef0b6 Fix dependencies following 2011-02-26T05:54:36Z!eggert@cs.ucla.edu.
lib-src/Makefile.in (fakemail${EXEEXT}): Depend on lib/ignore-value.h.
2011-02-26 10:36:56 +02:00
Eli Zaretskii
a54af40e14 Fix the MS-Windows build after 2011-02-26T05:54:36Z!eggert@cs.ucla.edu.
emacsclient.c (xstrdup) [WINDOWSNT]: Function added back.
 (w32_getenv): Use xstrdup to return all values in malloc'ed
 storage.
2011-02-26 09:44:38 +02:00
Paul Eggert
9e1b7fe6be * ebrowse.c (BROWSE_STRUCT): Remove unused macro. 2011-02-25 21:43:51 -08:00
Paul Eggert
6c0668d97b * ebrowse.c (parse_qualified_param_ident_or_type): Make it clear
to reader (and to the compiler) that the loop always executes at
least once.  This prevents a warning with recent GCC.
2011-02-25 21:41:42 -08:00
Paul Eggert
a4fe4e890a * fakemail.c: Include <ignore-value.h>.
(put_line): Explicitly ignore fwrite return value, for benefit of
recent glibc + gcc.
(close_the_streams): Diagnose output errors instead of merely
exiting with nonzero status.
(my_fclose, main): Diagnose input errors, and exit with nonzero status.
Formerly, input errors were silently ignored.
2011-02-25 21:36:51 -08:00
Paul Eggert
70279bd1cb * ebrowse.c (insert_keyword): Rename parameter to avoid shadowing diagnostic. 2011-02-25 16:23:33 -08:00
Paul Eggert
34e6d7823a * ebrowse.c (putstr): Rename from PUTSTR and turn into a function.
All callers changed.  This is cleaner, and avoids GCC warnings about
passing NULL to fputs.
2011-02-25 16:22:13 -08:00
Paul Eggert
4be3dfc5e3 * emacsclient.c (IF_LINT): New macro.
(set_local_socket, main): Use it to suppress warnings with
GCC -Wuninitialized.
2011-02-25 16:17:02 -08:00
Paul Eggert
b9170155fb * emacsclient.c (xstrdup): Remove; no longer needed.
(get_current_dir_name, w32_getenv, get_server_config, find_tty):
(set_local_socket, main):
Use const char *, not char *, for pointers that are not assigned
through.
2011-02-25 15:55:06 -08:00
Paul Eggert
7e6bb4c94c * emacsclient.c (main): Avoid dangling 'if'. 2011-02-25 15:39:18 -08:00
Paul Eggert
b0bbc07d9a * emacsclient.c: Redo local variables to avoid shadowing problems.
(message, socket_status, start_daemon_and_retry_set_socket):
Rename locals.
(main): Move decl of "i".
2011-02-25 15:35:16 -08:00
Paul Eggert
3f5e6230d7 * etags.c (ISUPPER): Move to inside the only #ifdef where it's used.
This avoids an unused-macro warning with some GCC settings.
2011-02-25 15:26:55 -08:00