1
0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2025-01-23 18:47:57 +00:00
emacs/test/lisp/hl-line-tests.el
Mattias Engdegård 7c0c2b1bb5 Remove useless unwind-protect forms, or make them useful as intended
* lisp/imenu.el (imenu--generic-function):
* lisp/mail/yenc.el (yenc-decode-region):
* lisp/textmodes/table.el (table-recognize-region):
* test/lisp/dired-tests.el (dired-test-directory-files):
* test/lisp/hl-line-tests.el (hl-line-tests-sticky):
Fix unwind-protect bracketing mistakes that caused the unwind code to
be misplaced.
* lisp/strokes.el (strokes-read-stroke): Fix a bracketing mistake that
misplaced the unwind code, and another one that misplaced the
else-clause of an `if` form.
* test/lisp/gnus/mml-sec-tests.el (mml-secure-test-fixture): Fix a
bracketing mistake that misplaced the unwind code, and remove
superfluous condition-case.

* lisp/mwheel.el (mouse-wheel-global-text-scale):
* lisp/speedbar.el (speedbar-stealthy-updates)
(speedbar-fetch-dynamic-etags):
* lisp/emacs-lisp/edebug.el (edebug--recursive-edit):
* lisp/emacs-lisp/package.el (package--read-pkg-desc):
* lisp/cedet/semantic.el (semantic-refresh-tags-safe):
* lisp/emulation/viper-cmd.el (viper-escape-to-state):
* lisp/emulation/viper-cmd.el (viper-file-add-suffix):
* lisp/gnus/mail-source.el (mail-source-movemail):
* lisp/mail/feedmail.el (feedmail-send-it-immediately)
(feedmail-deduce-address-list):
* lisp/mail/mailclient.el (mailclient-send-it):
* lisp/mail/smtpmail.el (smtpmail-deduce-address-list):
* lisp/mh-e/mh-print.el (mh-ps-print-range):
* lisp/textmodes/reftex-index.el (reftex-index-this-phrase):
* test/lisp/emacs-lisp/ert-tests.el (ert-test-run-tests-batch):
(ert-test-run-tests-batch-expensive):
Remove unwind-protect forms that are apparently useless, some since a
prior edit that removed their purpose, some since their first
appearance.

* test/lisp/subr-tests.el (subr-test--frames-2):
Insert dummy unwind form in backtrace test code.
2023-04-07 19:08:33 +02:00

115 lines
4.3 KiB
EmacsLisp

;;; hl-line-tests.el --- Test suite for hl-line. -*- lexical-binding: t -*-
;; Copyright (C) 2022-2023 Free Software Foundation, Inc.
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Code:
(require 'ert)
(require 'hl-line)
(defsubst hl-line-tests-verify (_label on-p)
(if on-p
(cl-some (apply-partially #'eq hl-line-overlay)
(overlays-at (point)))
(not (cl-some (apply-partially #'eq hl-line-overlay)
(overlays-at (point))))))
(ert-deftest hl-line-tests-sticky-across-frames ()
(skip-unless (display-graphic-p))
(customize-set-variable 'global-hl-line-sticky-flag t)
(call-interactively #'global-hl-line-mode)
(let ((first-frame (selected-frame))
(first-buffer "foo")
(second-buffer "bar")
second-frame)
(unwind-protect
(progn
(switch-to-buffer first-buffer)
(save-excursion
(insert (buffer-name)))
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 111 t))
(select-frame (setq second-frame (make-frame)))
(switch-to-buffer second-buffer)
(save-excursion
(insert (buffer-name)))
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 762 t))
(with-current-buffer first-buffer
(should (hl-line-tests-verify 534 t)))
(call-interactively #'global-hl-line-mode)
(should (hl-line-tests-verify 125 nil))
(with-current-buffer first-buffer
(should (hl-line-tests-verify 892 nil)))
;; now do unsticky
(customize-set-variable 'hl-line-sticky-flag nil)
(call-interactively #'global-hl-line-mode)
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 467 t))
(with-current-buffer first-buffer
(should (hl-line-tests-verify 765 nil)))
(select-frame first-frame)
(should (equal (buffer-name) first-buffer))
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 423 t))
(with-current-buffer second-buffer
(should (hl-line-tests-verify 897 nil))))
(let (kill-buffer-query-functions)
(ignore-errors (kill-buffer first-buffer))
(ignore-errors (kill-buffer second-buffer))
(ignore-errors (delete-frame second-frame))))))
(ert-deftest hl-line-tests-sticky ()
(customize-set-variable 'hl-line-sticky-flag t)
(let ((first-buffer "foo")
(second-buffer "bar"))
(unwind-protect
(progn
(switch-to-buffer first-buffer)
(hl-line-mode 1)
(save-excursion
(insert (buffer-name)))
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 123 t))
(switch-to-buffer second-buffer)
(hl-line-mode 1)
(save-excursion
(insert (buffer-name)))
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 56 t))
(with-current-buffer first-buffer
(should (hl-line-tests-verify 67 t)))
;; now do unsticky
(customize-set-variable 'hl-line-sticky-flag nil)
(should (hl-line-tests-verify 234 t))
(with-current-buffer first-buffer
(should (hl-line-tests-verify 231 nil)))
(switch-to-buffer first-buffer)
(run-hooks 'post-command-hook)
(should (hl-line-tests-verify 257 t))
(with-current-buffer second-buffer
(should (hl-line-tests-verify 999 nil))))
(let (kill-buffer-query-functions)
(ignore-errors (kill-buffer first-buffer))
(ignore-errors (kill-buffer second-buffer))))))
(provide 'hl-line-tests)
;;; hl-line-tests.el ends here