mirror of
https://git.savannah.gnu.org/git/emacs.git
synced 2024-11-27 07:37:33 +00:00
f2bccae22b
Change `function` so that when evaluating #'(lambda ...) we return an object of type `interpreted-function` rather than a list starting with one of `lambda` or `closure`. The new type reuses the existing PVEC_CLOSURE (nee PVEC_COMPILED) tag and tries to align the corresponding elements: - the arglist, the docstring, and the interactive-form go in the same slots as for byte-code functions. - the body of the function goes in the slot used for the bytecode string. - the lexical context goes in the slot used for the constants of bytecoded functions. The first point above means that `help-function-arglist`, `documentation`, and `interactive-form`s don't need to distinguish interpreted and bytecode functions any more. Main benefits of the change: - We can now reliably distinguish a list from a function value. - `cl-defmethod` can dispatch on `interactive-function` and `closure`. Dispatch on `function` also works now for interpreted functions but still won't work for functions represented as lists or as symbols, of course. - Function values are now self-evaluating. That was alrready the case when byte-compiled, but not when interpreted since (eval '(closure ...)) signals a void-function error. That also avoids false-positive warnings about "don't quote your lambdas" when doing things like `(mapcar ',func ...)`. * src/eval.c (Fmake_interpreted_closure): New function. (Ffunction): Use it and change calling convention of `Vinternal_make_interpreted_closure_function`. (FUNCTIONP, Fcommandp, eval_sub, funcall_general, funcall_lambda) (Ffunc_arity, lambda_arity): Simplify. (funcall_lambda): Adjust to new representation. (syms_of_eval): `defsubr` the new function. Remove definition of `Qclosure`. * lisp/emacs-lisp/cconv.el (cconv-make-interpreted-closure): Change calling convention and use `make-interpreted-closure`. * src/data.c (Fcl_type_of): Distinguish `byte-code-function`s from `interpreted-function`s. (Fclosurep, finterpreted_function_p): New functions. (Fbyte_code_function_p): Don't be confused by `interpreted-function`s. (Finteractive_form, Fcommand_modes): Simplify. (syms_of_data): Define new type symbols and `defsubr` the two new functions. * lisp/emacs-lisp/cl-print.el (cl-print-object) <interpreted-function>: New method. * lisp/emacs-lisp/oclosure.el (oclosure): Refine the parent to be `closure`. (oclosure--fix-type, oclosure-type): Simplify. (oclosure--copy, oclosure--get, oclosure--set): Adjust to new representation. * src/callint.c (Fcall_interactively): Adjust to new representation. * src/lread.c (bytecode_from_rev_list): * lisp/simple.el (function-documentation): * lisp/help.el (help-function-arglist): Remove the old `closure` case and adjust the byte-code case so it handles `interpreted-function`s. * lisp/emacs-lisp/cl-preloaded.el (closure): New type. (byte-code-function): Add it as a parent. (interpreted-function): Adjust parent (the type itself was already added earlier by accident). * lisp/emacs-lisp/bytecomp.el (byte-compile--reify-function): Adjust to new representation. (byte-compile): Use `interpreted-function-p`. * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Adjust to new representation. (side-effect-free-fns): Add `interpreted-function-p` and `closurep`. * src/profiler.c (trace_hash, ffunction_equal): Simplify. * lisp/profiler.el (profiler-function-equal): Simplify. * lisp/emacs-lisp/nadvice.el (advice--interactive-form-1): Use `interpreted-function-p`; adjust to new representation; and take advantage of the fact that function values are now self-evaluating. * lisp/emacs-lisp/lisp-mode.el (closure): Remove `lisp-indent-function` property. * lisp/emacs-lisp/disass.el (disassemble-internal): Adjust to new representation. * lisp/emacs-lisp/edebug.el (edebug--strip-instrumentation): Use `interpreted-function-p`. * lisp/emacs-lisp/comp-common.el (comp-known-type-specifiers): Add `closurep` and `interpreted-function-p`. * test/lisp/help-fns-tests.el (help-fns-test-lisp-defun): Adjust to more precise type info in `describe-function`. * test/lisp/erc/resources/erc-d/erc-d-tests.el (erc-d--render-entries): Use `interpreted-function-p`. * test/lisp/emacs-lisp/macroexp-resources/vk.el (vk-f4, vk-f5): Don't hardcode function values. * doc/lispref/functions.texi (Anonymous Functions): Don't suggest that function values are lists. Reword "self-quoting" to reflect the fact that #' doesn't return the exact same object. Update examples with the new shape of the return value. * doc/lispref/variables.texi (Lexical Binding): * doc/lispref/lists.texi (Rearrangement): * doc/lispref/control.texi (Handling Errors): Update examples to reflect new representation of function values. |
||
---|---|---|
.. | ||
data | ||
infra | ||
lib-src | ||
lisp | ||
manual | ||
misc | ||
src | ||
ChangeLog.1 | ||
file-organization.org | ||
Makefile.in | ||
README |
Copyright (C) 2008-2024 Free Software Foundation, Inc. See the end of the file for license conditions. This directory contains files intended to test various aspects of Emacs's functionality. Please help add tests! See the file file-organization.org for the details of the directory structure and file-naming conventions. For tests in the manual/ subdirectory, look there for separate README files, or look for instructions in the test files themselves. Emacs uses ERT, Emacs Lisp Regression Testing, for testing. See (info "(ert)") or https://www.gnu.org/software/emacs/manual/html_node/ert/ for more information on writing and running tests. Tests could be tagged by the developer. In this test directory, the following tags are recognized: * :expensive-test The test needs a serious amount of time to run. It is not intended to run on a regular basis by users. Instead, it runs on demand only, or during regression tests. * :nativecomp The test runs only if Emacs is configured with Lisp native compiler support. * :unstable The test is under development. It shall run on demand only. The Makefile sets the environment variable $EMACS_TEST_DIRECTORY, which points to this directory. This environment variable does not exist when the tests are run outside make. The Makefile supports the following targets: * make check Run all tests as defined in the directory. Expensive and unstable tests are suppressed. The result of the tests for <filename>.el is stored in <filename>.log. * make check-maybe Like "make check", but run only the tests for files which have unresolved prerequisites. * make check-expensive Like "make check", but run also the tests marked as expensive. * make check-all Like "make check", but run all tests. * make check-<dirname> Like "make check", but run only the tests in test/<dirname>/*.el. <dirname> is a relative directory path, which has replaced "/" by "-", like in "check-src" or "check-lisp-net". * make <filename> -or- make <filename>.log Run all tests declared in <filename>.el. This includes expensive tests. In the former case the output is shown on the terminal, in the latter case the output is written to <filename>.log. <filename> could be either a relative file name like "lisp/files-tests", or a package name like "files-tests". ERT offers selectors, which make it possible to filter out which test cases shall run. The make variable $(SELECTOR) gives you a simple mean to use your own selectors. The ERT manual describes how selectors are constructed, see (info "(ert)Test Selectors") or https://www.gnu.org/software/emacs/manual/html_node/ert/Test-Selectors.html You could use predefined selectors of the Makefile. "make <filename> SELECTOR='$(SELECTOR_DEFAULT)'" runs all tests for <filename>.el except the tests tagged as expensive or unstable. Other predefined selectors are $(SELECTOR_EXPENSIVE) (run all tests except unstable ones) and $(SELECTOR_ALL) (run all tests). If your test file contains the tests "test-foo", "test2-foo" and "test-foo-remote", and you want to run only the former two tests, you could use a selector regexp (note that the "$" needs to be doubled to protect against "make" variable expansion): make <filename> SELECTOR='"foo$$"' In case you want to use the symbol name of a test as selector, you can use it directly: make <filename> SELECTOR='test-foo-remote' Note that although the test files are always compiled (unless they set no-byte-compile), the source files will be run when expensive or unstable tests are involved, to give nicer backtraces. To run the compiled version of a test use make TEST_LOAD_EL=no ... Some tests might take long time to run. In order to summarize the <nn> tests with the longest duration, call make SUMMARIZE_TESTS=<nn> ... The backtrace of failing tests are truncated to the default value of 'ert-batch-backtrace-right-margin'. To see more of the backtrace, use make TEST_BACKTRACE_LINE_LENGTH=<nn> ... The tests are run in batch mode by default; sometimes it's useful to get precisely the same environment but run in interactive mode for debugging. To do that, use make TEST_INTERACTIVE=yes ... By default, ERT test failure summaries are quite brief in batch mode--only the names of the failed tests are listed. If the $EMACS_TEST_VERBOSE environment variable is set and non-empty, the failure summaries will also include the data from the failing test. If the $EMACS_TEST_JUNIT_REPORT environment variable is set to a file name, a JUnit test report is generated under this name. Some of the tests require a remote temporary directory (autorevert-tests.el, dnd-tests.el, eglot-tests.el, filenotify-tests.el, shadowfile-tests.el and tramp-tests.el). Per default, a mock-up connection method is used (this might not be possible when running on MS Windows). If you want to test a real remote connection, set $REMOTE_TEMPORARY_FILE_DIRECTORY to a suitable value in order to overwrite the default value: env REMOTE_TEMPORARY_FILE_DIRECTORY=/ssh:host:/tmp make ... There are also continuous integration tests on <https://hydra.nixos.org/jobset/gnu/emacs-trunk> (see admin/notes/hydra) and <https://emba.gnu.org/emacs/emacs> (see admin/notes/emba). Both environments provide an environment variable, which could be used to determine, whether the tests run in one of these test environments. $EMACS_HYDRA_CI indicates the hydra environment, and $EMACS_EMBA_CI indicates the emba environment, respectively. If tests on these premises take too long, and it is needed to create a core dump for further analysis, the environment variable $EMACS_TEST_TIMEOUT could set a limit (in seconds) when this shall happen. (Also, see etc/compilation.txt for compilation mode font lock tests and etc/grep.txt for grep mode font lock tests.) This file is part of GNU Emacs. GNU Emacs is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. GNU Emacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.