2000-11-30 11:39:26 +00:00
|
|
|
--- gcc/c-common.c.orig Mon Feb 15 16:40:05 1999
|
2000-12-02 14:30:33 +00:00
|
|
|
+++ gcc/c-common.c Sat Dec 2 06:04:12 2000
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -61,7 +61,7 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
int, int, int));
|
|
|
|
static void init_attributes PROTO((void));
|
|
|
|
static void record_function_format PROTO((tree, tree, enum format_type,
|
|
|
|
- int, int));
|
|
|
|
+ int, int, int));
|
|
|
|
static void record_international_format PROTO((tree, tree, int));
|
2000-11-30 11:39:26 +00:00
|
|
|
|
|
|
|
/* Keep a stack of if statements. We record the number of compound
|
2000-12-02 14:30:33 +00:00
|
|
|
@@ -672,6 +672,7 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
enum format_type format_type;
|
|
|
|
tree argument;
|
|
|
|
int arg_num;
|
2000-12-02 14:30:33 +00:00
|
|
|
+ int null_format_ok;
|
|
|
|
|
|
|
|
if (TREE_CODE (decl) != FUNCTION_DECL)
|
|
|
|
{
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -682,7 +683,7 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
if (TREE_CODE (format_type_id) != IDENTIFIER_NODE)
|
|
|
|
{
|
|
|
|
- error ("unrecognized format specifier");
|
|
|
|
+ error_with_decl (decl, "unrecognized format specifier");
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
else
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -690,12 +691,26 @@
|
|
|
|
char *p = IDENTIFIER_POINTER (format_type_id);
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
if (!strcmp (p, "printf") || !strcmp (p, "__printf__"))
|
|
|
|
+ {
|
|
|
|
+ format_type = printf_format_type;
|
|
|
|
+ null_format_ok = 0;
|
|
|
|
+ }
|
|
|
|
+ else if (!strcmp (p, "printf0") || !strcmp (p, "__printf0__"))
|
|
|
|
+ {
|
|
|
|
format_type = printf_format_type;
|
|
|
|
+ null_format_ok = 1;
|
|
|
|
+ }
|
|
|
|
else if (!strcmp (p, "scanf") || !strcmp (p, "__scanf__"))
|
|
|
|
+ {
|
|
|
|
format_type = scanf_format_type;
|
|
|
|
+ null_format_ok = 0;
|
|
|
|
+ }
|
|
|
|
else if (!strcmp (p, "strftime")
|
|
|
|
|| !strcmp (p, "__strftime__"))
|
|
|
|
+ {
|
|
|
|
format_type = strftime_format_type;
|
|
|
|
+ null_format_ok = 0;
|
|
|
|
+ }
|
|
|
|
else
|
|
|
|
{
|
2000-11-30 11:39:26 +00:00
|
|
|
error ("`%s' is an unrecognized format function type", p);
|
|
|
|
@@ -766,7 +781,8 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
record_function_format (DECL_NAME (decl),
|
|
|
|
DECL_ASSEMBLER_NAME (decl),
|
|
|
|
- format_type, format_num, first_arg_num);
|
|
|
|
+ format_type, null_format_ok, format_num,
|
|
|
|
+ first_arg_num);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -1010,6 +1026,11 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
} format_char_info;
|
|
|
|
|
|
|
|
static format_char_info print_char_table[] = {
|
|
|
|
+/* FreeBSD kernel extensions. */
|
|
|
|
+ { "D", 1, T_C, T_C, NULL, NULL, NULL, NULL, NULL, "-wp" },
|
|
|
|
+ { "b", 1, T_C, T_C, NULL, NULL, NULL, NULL, NULL, "-wp" },
|
|
|
|
+ { "rz", 0, NULL, T_I, T_I, T_L, NULL, NULL, NULL, "-wp0 +#" },
|
|
|
|
+#define unextended_print_char_table (print_char_table + 3)
|
|
|
|
{ "di", 0, T_I, T_I, T_I, T_L, T_LL, T_LL, T_ST, "-wp0 +" },
|
|
|
|
{ "oxX", 0, T_UI, T_UI, T_UI, T_UL, T_ULL, T_ULL, T_ST, "-wp0#" },
|
|
|
|
{ "u", 0, T_UI, T_UI, T_UI, T_UL, T_ULL, T_ULL, T_ST, "-wp0" },
|
2000-12-02 14:30:33 +00:00
|
|
|
@@ -1072,6 +1093,7 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
enum format_type format_type; /* type of format (printf, scanf, etc.) */
|
|
|
|
int format_num; /* number of format argument */
|
|
|
|
int first_arg_num; /* number of first arg (zero for varargs) */
|
2000-12-02 14:30:33 +00:00
|
|
|
+ int null_format_ok; /* TRUE if the format string may be NULL */
|
1999-03-30 18:15:39 +00:00
|
|
|
} function_format_info;
|
2000-12-02 14:30:33 +00:00
|
|
|
|
|
|
|
static function_format_info *function_format_list = NULL;
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -1102,25 +1124,25 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
init_function_format_info ()
|
|
|
|
{
|
|
|
|
record_function_format (get_identifier ("printf"), NULL_TREE,
|
|
|
|
- printf_format_type, 1, 2);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 1, 2, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("fprintf"), NULL_TREE,
|
|
|
|
- printf_format_type, 2, 3);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 2, 3, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("sprintf"), NULL_TREE,
|
|
|
|
- printf_format_type, 2, 3);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 2, 3, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("scanf"), NULL_TREE,
|
|
|
|
- scanf_format_type, 1, 2);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ scanf_format_type, 1, 2, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("fscanf"), NULL_TREE,
|
|
|
|
- scanf_format_type, 2, 3);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ scanf_format_type, 2, 3, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("sscanf"), NULL_TREE,
|
|
|
|
- scanf_format_type, 2, 3);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ scanf_format_type, 2, 3, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("vprintf"), NULL_TREE,
|
|
|
|
- printf_format_type, 1, 0);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 1, 0, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("vfprintf"), NULL_TREE,
|
|
|
|
- printf_format_type, 2, 0);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 2, 0, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("vsprintf"), NULL_TREE,
|
|
|
|
- printf_format_type, 2, 0);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ printf_format_type, 2, 0, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
record_function_format (get_identifier ("strftime"), NULL_TREE,
|
|
|
|
- strftime_format_type, 3, 0);
|
2000-12-02 11:58:26 +00:00
|
|
|
+ strftime_format_type, 3, 0, 0);
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
record_international_format (get_identifier ("gettext"), NULL_TREE, 1);
|
|
|
|
record_international_format (get_identifier ("dgettext"), NULL_TREE, 2);
|
2000-12-02 14:30:33 +00:00
|
|
|
@@ -1138,12 +1160,13 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
static void
|
2000-12-02 14:30:33 +00:00
|
|
|
record_function_format (name, assembler_name, format_type,
|
|
|
|
- format_num, first_arg_num)
|
|
|
|
+ format_num, first_arg_num, null_format_ok)
|
1999-03-30 18:15:39 +00:00
|
|
|
tree name;
|
|
|
|
tree assembler_name;
|
|
|
|
enum format_type format_type;
|
|
|
|
int format_num;
|
|
|
|
int first_arg_num;
|
2000-12-02 14:30:33 +00:00
|
|
|
+ int null_format_ok;
|
1999-03-30 18:15:39 +00:00
|
|
|
{
|
2000-12-02 14:30:33 +00:00
|
|
|
function_format_info *info;
|
1999-03-30 18:15:39 +00:00
|
|
|
|
2000-12-02 14:30:33 +00:00
|
|
|
@@ -1167,6 +1190,7 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
info->format_type = format_type;
|
|
|
|
info->format_num = format_num;
|
|
|
|
info->first_arg_num = first_arg_num;
|
2000-12-02 14:30:33 +00:00
|
|
|
+ info->null_format_ok = null_format_ok;
|
1999-03-30 18:15:39 +00:00
|
|
|
}
|
2000-12-02 14:30:33 +00:00
|
|
|
|
|
|
|
/* Record information for the names of function that modify the format
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -1314,7 +1338,8 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
|
|
|
|
if (integer_zerop (format_tree))
|
|
|
|
{
|
|
|
|
- warning ("null format string");
|
|
|
|
+ if (!info->null_format_ok)
|
|
|
|
+ warning ("null format string");
|
|
|
|
return;
|
|
|
|
}
|
2000-11-30 11:39:26 +00:00
|
|
|
if (TREE_CODE (format_tree) != ADDR_EXPR)
|
|
|
|
@@ -1485,12 +1510,13 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
It will work on most machines, because size_t and int
|
|
|
|
have the same mode. But might as well warn anyway,
|
|
|
|
since it will fail on other machines. */
|
|
|
|
+ /* XXX should we allow unsigned ints here? */
|
|
|
|
if ((TYPE_MAIN_VARIANT (TREE_TYPE (cur_param))
|
|
|
|
!= integer_type_node)
|
|
|
|
&&
|
|
|
|
(TYPE_MAIN_VARIANT (TREE_TYPE (cur_param))
|
|
|
|
!= unsigned_type_node))
|
|
|
|
- warning ("field width is not type int (arg %d)", arg_num);
|
|
|
|
+ warning ("precision is not type int (arg %d)", arg_num);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -1535,6 +1561,53 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
+ if (*format_chars == 'b')
|
|
|
|
+ {
|
|
|
|
+ /* There should be an int arg to control the string arg. */
|
|
|
|
+ if (params == 0)
|
|
|
|
+ {
|
|
|
|
+ warning (tfaff);
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+ if (info->first_arg_num != 0)
|
|
|
|
+ {
|
|
|
|
+ cur_param = TREE_VALUE (params);
|
|
|
|
+ params = TREE_CHAIN (params);
|
|
|
|
+ ++arg_num;
|
|
|
|
+ if ((TYPE_MAIN_VARIANT (TREE_TYPE (cur_param))
|
|
|
|
+ != integer_type_node)
|
|
|
|
+ &&
|
|
|
|
+ (TYPE_MAIN_VARIANT (TREE_TYPE (cur_param))
|
|
|
|
+ != unsigned_type_node))
|
|
|
|
+ {
|
|
|
|
+ warning ("bitmap is not type int (arg %d)", arg_num);
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ if (*format_chars == 'D')
|
|
|
|
+ {
|
|
|
|
+ /* There should be an unsigned char * arg before the string arg. */
|
|
|
|
+ if (params == 0)
|
|
|
|
+ {
|
|
|
|
+ warning (tfaff);
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+ if (info->first_arg_num != 0)
|
|
|
|
+ {
|
|
|
|
+ cur_param = TREE_VALUE (params);
|
|
|
|
+ params = TREE_CHAIN (params);
|
|
|
|
+ ++arg_num;
|
|
|
|
+ cur_type = TREE_TYPE (cur_param);
|
|
|
|
+ if (TREE_CODE (cur_type) != POINTER_TYPE
|
|
|
|
+ || TYPE_MAIN_VARIANT (TREE_TYPE (cur_type))
|
|
|
|
+ != unsigned_char_type_node)
|
|
|
|
+ {
|
|
|
|
+ warning ("ethernet address is not type unsigned char *"
|
|
|
|
+ " (arg %d)",
|
|
|
|
+ arg_num);
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
|
|
|
|
aflag = 0;
|
|
|
|
|
2000-11-30 11:39:26 +00:00
|
|
|
@@ -1604,7 +1677,8 @@
|
1999-03-30 18:15:39 +00:00
|
|
|
switch (info->format_type)
|
|
|
|
{
|
|
|
|
case printf_format_type:
|
|
|
|
- fci = print_char_table;
|
|
|
|
+ fci = flag_format_extensions ? print_char_table
|
|
|
|
+ : unextended_print_char_table;
|
|
|
|
break;
|
|
|
|
case scanf_format_type:
|
|
|
|
fci = scan_char_table;
|