mirror/freebsd-ports
1
0
Fork 0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-07 06:40:06 +00:00
Code Issues Releases Activity

Add a patch to fix sudo bug #743 that causes a bug where it dereference

Browse Source 
a NULL pointer when it looks up a negative cached entry which is stored
as a NULL passwd or group struct pointer

PR:		208198
Submitted by:	Fredrik Eriksson <fredrik.eriksson@loopia.se>
Obtained from:	https://www.sudo.ws/repos/sudo/rev/1d13341d53ec
Sponsored by:	Rubicon Communications (Netgate)
This commit is contained in:
Renato Botelho 2016-06-11 20:39:38 +00:00
parent 6a75a4d271
commit 050bdc9f2f
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=416751
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/sudo/Makefile
View File

@ -3,7 +3,7 @@
PORTNAME= sudo
PORTVERSION= 1.8.16
PORTREVISION= 1
PORTREVISION= 2
CATEGORIES= security
MASTER_SITES= SUDO

35
security/sudo/files/patch-fix_bz208198 Normal file
View File

@ -0,0 +1,35 @@
--- plugins/sudoers/pwutil.c Thu Apr 28 15:27:53 2016 -0600
+++ plugins/sudoers/pwutil.c Wed May 04 08:55:21 2016 -0600
@@ -139,8 +139,8 @@
item = node->data;
sudo_debug_printf(SUDO_DEBUG_DEBUG,
"%s: uid %u [%s] -> user %s [%s] (cache hit)", __func__,
- (unsigned int)uid, key.registry, item->d.pw->pw_name,
- item->registry);
+ (unsigned int)uid, key.registry,
+ item->d.pw ? item->d.pw->pw_name : "unknown", item->registry);
goto done;
}
/*
@@ -202,8 +202,8 @@
if ((node = rbfind(pwcache_byname, &key)) != NULL) {
item = node->data;
sudo_debug_printf(SUDO_DEBUG_DEBUG,
- "%s: user %s [%s] -> uid %u [%s] (cache hit)", __func__, name,
- key.registry, (unsigned int)item->d.pw->pw_uid, item->registry);
+ "%s: user %s [%s] -> uid %d [%s] (cache hit)", __func__, name,
+ key.registry, item->d.pw ? (int)item->d.pw->pw_uid : -1, item->registry);
goto done;
}
/*
@@ -461,8 +461,8 @@
item = node->data;
sudo_debug_printf(SUDO_DEBUG_DEBUG,
"%s: gid %u [%s] -> group %s [%s] (cache hit)", __func__,
- (unsigned int)gid, key.registry, item->d.gr->gr_name,
- item->registry);
+ (unsigned int)gid, key.registry,
+ item->d.gr ? item->d.gr->gr_name : "unknown", item->registry);
goto done;
}
/*