mirror/freebsd-ports
1
0
Fork 0
mirror of https://git.FreeBSD.org/ports.git synced 2024-11-30 01:15:52 +00:00
Code Issues Releases Activity

bsd.port.mk: Handle incorrect binary aliases gracefully

Browse Source 
Currently, if the src element of a BINARY_ALIAS pair is missing,
the ports framework would just print out the help message of install(1)
and exit with a failure. This might be hard to debug for novice ports
users.

Let's introduce a check, which would allow us to print
that the src component is missing.

This situation happens more often than it seems to. For example,
BINARY_ALIAS tend to blow up when used for test dependencies,
because binary aliases are created before test dependencies
are installed. This leads to a lot of confusion for my experience.

Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D26551
This commit is contained in:
Mateusz Piotrowski 2020-09-28 13:46:43 +00:00
parent 45ce1db62d
commit 2922bb2e6b
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=550426
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Mk/bsd.port.mk
View File

@ -5134,7 +5134,12 @@ install-desktop-entries:
.if !target(create-binary-alias)
create-binary-alias: ${BINARY_LINKDIR}
.for target src in ${BINARY_ALIAS:C/=/ /}
@${RLN} `which ${src}` ${BINARY_LINKDIR}/${target}
@if srcpath=`which -- ${src}`; then \
${RLN} $${srcpath} ${BINARY_LINKDIR}/${target}; \
else \
${ECHO_MSG} "===> Missing \"${src}\" to create a binary alias at \"${BINARY_LINKDIR}/${target}\""; \
${FALSE}; \
fi
.endfor
.endif
.endif