mirror/freebsd-ports
1
0
Fork 0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-13 07:34:50 +00:00
Code Issues Releases Activity

graphics/poppler: fix build with libc++ 19

Browse Source 
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes graphics/poppler to fail to compile with clang 19 and libc++
19, resulting in errors similar to:

    /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
      820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
          |                                          ^
    /wrkdirs/usr/ports/graphics/poppler/work/poppler-24.02.0/cpp/poppler-global.h:101:43: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
      101 | class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short>
          |                                           ^
    /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
       23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
          |                             ^

Upstream poppler has fixed this in commit b4ac7d9a [2], so add it as a
PATCHFILES entry in the Makefile, until the next version of poppler is
released.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
[2] https://gitlab.freedesktop.org/poppler/poppler/-/commit/b4ac7d9a

PR:		280564
Approved by:	maintainer timeout (2 weeks)
MFH:		2024Q3
This commit is contained in:
Dimitry Andric 2024-08-01 21:48:37 +02:00
parent f6f3393e51
commit 6bf6ee1936
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
graphics/poppler/Makefile
View File

@ -4,6 +4,9 @@ PORTREVISION= 1
CATEGORIES= graphics print
MASTER_SITES= https://poppler.freedesktop.org/
PATCH_SITES= https://gitlab.freedesktop.org/poppler/${PORTNAME}/-/commit/
PATCHFILES+= b4ac7d9a.patch:-p1 # deprecated char_traits template has been removed in libc++ 19
MAINTAINER?= desktop@FreeBSD.org
COMMENT?= PDF rendering library
WWW= https://poppler.freedesktop.org/

4
graphics/poppler/distinfo
View File

@ -1,3 +1,5 @@
TIMESTAMP = 1707805389
TIMESTAMP = 1722540994
SHA256 (poppler-24.02.0.tar.xz) = 19187a3fdd05f33e7d604c4799c183de5ca0118640c88b370ddcf3136343222e
SIZE (poppler-24.02.0.tar.xz) = 1897604
SHA256 (b4ac7d9a.patch) = 0e03b8df2d44531b552dc6881ffe858e426eedd96019241b42bc37d979e66770
SIZE (b4ac7d9a.patch) = 911