Update to libnids-1.23.

Fix a couple of portlint warnings by simply removing *any* overriding
of CFLAGS, LDFLAGS, etc. and fixing the libnids configure script to
properly use the values obtained from pkg-config.

net/libnids/Makefile

@@ -6,8 +6,7 @@
 #
 
 PORTNAME=	libnids
-PORTVERSION=	1.21
-PORTREVISION=	4
+PORTVERSION=	1.23
 CATEGORIES=	net security
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -21,10 +20,6 @@ OPTIONS=	LIBNET "Include code requiring libnet" ON \
 
 WANT_GNOME=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CFLAGS="-I${LOCALBASE}/include ${PTHREAD_CFLAGS}" \
-		LDFLAGS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
-
-MAKE_ENV=	LDFLAGS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
 
 MAN3=		libnids.3
 

net/libnids/distinfo

@@ -1,3 +1,3 @@
-MD5 (libnids-1.21.tar.gz) = 8c43dd7d66350eed99a29be50bc5615f
-SHA256 (libnids-1.21.tar.gz) = 91ec08b9aeb2f869009b5b099f318c476f75942db64804eb50acde94696f4bf5
-SIZE (libnids-1.21.tar.gz) = 140138
+MD5 (libnids-1.23.tar.gz) = af35e8ef403a0ca95df2da94db856428
+SHA256 (libnids-1.23.tar.gz) = 755cd72483c2cdccbc6634c00de9e2d8666419fd80da36a2bdb3f81657130643
+SIZE (libnids-1.23.tar.gz) = 140975

net/libnids/files/patch-configure

@@ -0,0 +1,21 @@
+Do not attempt to put -lgthread-2.0 before its -L clause!
+
+--- configure.orig
++++ configure
+@@ -4288,7 +4288,7 @@
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else
+   ac_check_lib_save_LIBS=$LIBS
+-LIBS="-lgthread-2.0 $GTHREAD_LIBS $LIBS"
++LIBS="$GTHREAD_LIBS $LIBS"
+ cat >conftest.$ac_ext <<_ACEOF
+ /* confdefs.h.  */
+ _ACEOF
+@@ -4350,7 +4350,6 @@
+ #define HAVE_LIBGTHREAD_2_0 1
+ _ACEOF
+ 
+-  LIBS="-lgthread-2.0 $LIBS"
+ 
+ fi
+