security/keepassxc: Update to 2.4.1

* Remove the now obsolete patches for CMakeLists.txt (merged by upstream)
  and the one introduced in r496805 that fixed the build when the KEESHARE
  option was disabled.

Changelog:

* Fix database deletion when using unsafe saves to a different file system
* Fix opening databases with legacy key files that contain '/'
* Fix opening database files from the command line
* Fix crash when editing master key
* Fix multiple issues with apply button behavior
* Fix issues on application startup (tab order, --pw-stdin, etc.)
* Fix building without WITH_XC_KEESHARE
* Improve UX of update checker; reduce checks to every 7 days
* KeeShare improvements
* Re-enable Ctrl+C to copy password from search box
* Add KeePassXC-Browser integration for Brave browser
* SSH Agent: Re-Add keys on database unlock
* SSH Agent: Only remove keys on app exit if they are removed on lock
* CLI: Add --no-password option
* CLI: Improve database extraction to XML
* CLI: Don't call mandb on build
* CLI: Add debug info
* Improve support for Snap theming
* Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous
* Add .gitrev output to tarball for third-party builds
* Add WITH_XC_UPDATECHECK compile flag to toggle the update checker

https://github.com/keepassxreboot/keepassxc/blob/2.4.1/CHANGELOG

PR:		237625
Submitted by:	Andrew Romanenko <melanhit@gmail.com> (maintainer)
Approved by:	mentors (implicit)

security/keepassxc/Makefile

@@ -1,7 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	keepassxc
-DISTVERSION=	2.4.0
+DISTVERSION=	2.4.1
 CATEGORIES=	security
 MASTER_SITES=	https://github.com/keepassxreboot/keepassxc/releases/download/${DISTVERSION}/${PORTNAME}-${DISTVERSION}-src.tar.xz?dummy=/
 

security/keepassxc/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1553292671
-SHA256 (keepassxc-2.4.0.tar.xz) = 081ff1a34da8e0e8db951b5d70824d7a2b3d299ed4ae54e6ddc1e3ac176b95a8
-SIZE (keepassxc-2.4.0.tar.xz) = 3252104
+TIMESTAMP = 1556462578
+SHA256 (keepassxc-2.4.1.tar.xz) = 0da97bd1279d1b9b06a63b9f723b43ab8c078b7f1203d6c13504fdd4735489ab
+SIZE (keepassxc-2.4.1.tar.xz) = 3277856

security/keepassxc/files/patch-CMakeLists.txt

@@ -1,11 +0,0 @@
---- CMakeLists.txt.orig	2019-03-19 22:59:14 UTC
-+++ CMakeLists.txt
-@@ -192,7 +192,7 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug")
-     add_gcc_compiler_flags("-Werror")
- endif()
- 
--if((CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.8.999) OR CMAKE_COMPILER_IS_CLANGXX)
-+if((CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.8.999) OR (CMAKE_COMPILER_IS_CLANGXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 3.8))
-     add_gcc_compiler_flags("-fstack-protector-strong")
- else()
-     add_gcc_compiler_flags("-fstack-protector --param=ssp-buffer-size=4")

security/keepassxc/files/patch-src_gui_DatabaseWidget.cpp

@@ -1,35 +0,0 @@
-From eb9ff677d0c681a86a9ef296f5a363549b94c42c Mon Sep 17 00:00:00 2001
-From: Lars Wendler <polynomial-c@gentoo.org>
-Date: Wed, 20 Mar 2019 11:53:21 +0100
-Subject: [PATCH] src/gui/DatabaseWidget.cpp: Build fails without
- WITH_XC_KEESHARE
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-/var/tmp/portage/app-admin/keepassxc-2.4.0/work/keepassxc-2.4.0/src/gui/DatabaseWidget.cpp: In member function ‘void DatabaseWidget::search(const QString&)’:
-/var/tmp/portage/app-admin/keepassxc-2.4.0/work/keepassxc-2.4.0/src/gui/DatabaseWidget.cpp:1115:5: error: ‘m_shareLabel’ was not declared in this scope
-     m_shareLabel->setVisible(false);
-     ^~~~~~~~~~~~
-/var/tmp/portage/app-admin/keepassxc-2.4.0/work/keepassxc-2.4.0/src/gui/DatabaseWidget.cpp:1115:5: note: suggested alternative: ‘m_searchingLabel’
-     m_shareLabel->setVisible(false);
-     ^~~~~~~~~~~~
-     m_searchingLabel
----
- src/gui/DatabaseWidget.cpp | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/src/gui/DatabaseWidget.cpp b/src/gui/DatabaseWidget.cpp
-index 8728c331f..e4196734b 100644
---- src/gui/DatabaseWidget.cpp
-+++ src/gui/DatabaseWidget.cpp
-@@ -1112,7 +1112,9 @@ void DatabaseWidget::search(const QString& searchtext)
-     }
- 
-     m_searchingLabel->setVisible(true);
-+#ifdef WITH_XC_KEESHARE
-     m_shareLabel->setVisible(false);
-+#endif
- 
-     emit searchModeActivated();
- }