1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-10-19 19:59:43 +00:00

Patch to fix a debilitating problem for amd64 users. To quote Scott:

"While it compiles and seems to start fine, it will crash if you
start any GTK-based program, including Firefox and Mozilla ...
GTK populates the NET_WM_ICON X11 property with incorrectly padded
data, and WindowMaker blindly reads it out and winds up passing
garbage to some X libraries, which in turn abort the entire process ...
Fortunately, handling this X11 property is not mandatory as there are
other more reliable ways to pass icon state through X (and in fact very
very few other window managers even try this), so it's safe to avoid the
whole mess by stubbing it out and letting Windowmaker fall back to a
more reliable method."

I've tested this patch with i386 windowmaker, and haven't noticed any
differences. I have xterms and various other things doing fancy stuff
with window and icon titles, so I'm pretty confident that this will
be safe for users of all ARCH's. It's also possible that it will help
those users who were having weird QT problems, but I was not able to
reproduce that problem so I can't say for sure.

Submitted by:	scottl
Approved by:	portmgr (krion)
This commit is contained in:
Doug Barton 2005-03-28 09:13:21 +00:00
parent 05e2eb3bb9
commit 862f6c8711
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=132096

View File

@ -0,0 +1,11 @@
--- src/wmspec.c.old Sun Mar 27 19:42:28 2005
+++ src/wmspec.c Sun Mar 27 19:43:56 2005
@@ -381,7 +381,7 @@
XA_CARDINAL, &actual_type_return, &actual_format_return,
&nitems_return, &bytes_after_return, &prop_return);
- if (rc==Success && prop_return) {
+ if (0 && rc==Success && prop_return) {
unsigned int *data = (unsigned int *)prop_return;
unsigned int pos = 0, len = 0;
unsigned int best_pos = 0, best_tmp = ~0;