mirror/freebsd-ports
1
0
Fork 0
mirror of https://git.FreeBSD.org/ports.git synced 2024-12-29 05:38:00 +00:00
Code Issues Releases Activity

lang/spidermonkey102: fix build with clang and libc++ 19

Browse Source 
Clang 19 now diagnoses incorrect member accesses, which causes
lang/spidermonkey102 to fail with an error similar to:

    /wrkdirs/usr/ports/lang/spidermonkey102/work/firefox-102.9.0/js/src/threading/ExclusiveData.h:113:29: error: reference to non-static member function must be called
      113 |       : lock_(std::move(rhs.lock)), value_(std::move(rhs.value_)) {
          |                         ~~~~^~~~

Upstream fixed this for https://bugzilla.mozilla.org/1894423 in
changeset 223087fdc29f18678f6174e9807b8780e439acf6 [2], so pull this in
as a patch and apply it.

Also, as noted in the libc++ 19 release notes [1], std::char_traits<> is
now only provided for char, char8_t, char16_t, char32_t and wchar_t, and
any instantiation for other types will fail.

With lang/spidermonkey102 and clang/libc++ 19 this results in errors
similar to:

    /wrkdirs/usr/ports/lang/spidermonkey102/work/firefox-102.9.0/js/src/builtin/intl/Locale.cpp:208:20: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
      208 |       iter_ = std::char_traits<CharT>::find(
          |                    ^
    /wrkdirs/usr/ports/lang/spidermonkey102/work/firefox-102.9.0/js/src/builtin/intl/Locale.cpp:769:21: note: in instantiation of member function 'SepKeywordIterator<unsigned char>::next' requested here
      769 |     beginKey = iter.next();
          |                     ^
    /wrkdirs/usr/ports/lang/spidermonkey102/work/firefox-102.9.0/js/src/builtin/intl/Locale.cpp:808:16: note: in instantiation of function template specialization 'FindUnicodeExtensionType<unsigned char>' requested here
      808 |              ? FindUnicodeExtensionType(unicodeExtension->latin1Chars(nogc),
          |                ^

Upstream fixed this for https://bugzilla.mozilla.org/1849070 in
changeset 68ff4d3f7338248b4d67cf03aade5a73f8d396b2 [3], so pull this in
as a patch and apply it.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
[2] https://hg.mozilla.org/mozilla-central/rev/223087fdc29f18678f6174e9807b8780e439acf6
[3] https://hg.mozilla.org/mozilla-central/rev/68ff4d3f7338248b4d67cf03aade5a73f8d396b2

PR:		280730
Approved by:	nc (maintainer)
MFH:		2024Q3
This commit is contained in:
Dimitry Andric 2024-08-10 15:48:05 +02:00
parent 743cdc3096
commit 8e8ef3deb4
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lang/spidermonkey102/Makefile
View File

@ -5,6 +5,10 @@ MASTER_SITES= MOZILLA/firefox/releases/${DISTVERSION}esr/source
PKGNAMESUFFIX= ${SP_VER}
DISTNAME= firefox-${DISTVERSION}esr.source
PATCH_SITES= https://hg.mozilla.org/mozilla-central/raw-rev/
PATCHFILES+= 223087fdc29f18678f6174e9807b8780e439acf6:-p1 # https://bugzilla.mozilla.org/1894423
PATCHFILES+= 68ff4d3f7338248b4d67cf03aade5a73f8d396b2:-p1 # https://bugzilla.mozilla.org/1849070
MAINTAINER= nc@FreeBSD.org
COMMENT= Standalone JavaScript based from Mozilla 102-esr
WWW= https://spidermonkey.dev/

6
lang/spidermonkey102/distinfo
View File

@ -1,3 +1,7 @@
TIMESTAMP = 1720131181
TIMESTAMP = 1723296424
SHA256 (firefox-102.9.0esr.source.tar.xz) = 31b074623f09ca821a8a7dee0b3d2df1a45f1164264d31c26b4969a4d6a21dd1
SIZE (firefox-102.9.0esr.source.tar.xz) = 484308672
SHA256 (223087fdc29f18678f6174e9807b8780e439acf6) = f234371584e2b2bc9953ae4fd145da19c99a6f04087f53d59616aecf29df039c
SIZE (223087fdc29f18678f6174e9807b8780e439acf6) = 1597
SHA256 (68ff4d3f7338248b4d67cf03aade5a73f8d396b2) = 8d556dcb0d3a76a6cb8870b6eff45fafe0a78760ea24d34ea0b5e7ceb4489a71
SIZE (68ff4d3f7338248b4d67cf03aade5a73f8d396b2) = 2546