devel/pycharm-pro: update to 2020.3.4

Changes: https://confluence.jetbrains.com/display/PYH/PyCharm+2020.3.4+Release+Notes

PR:		253714
Submitted by:	Guido Kollerie <guido AT kollerie DOT com> (maintainer)

devel/pycharm-pro/Makefile

@@ -1,7 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	pycharm-pro
-PORTVERSION=	2020.2.3
+PORTVERSION=	2020.3.4
 CATEGORIES=	devel java python
 MASTER_SITES=	https://download.jetbrains.com/python/ \
 		http://download.jetbrains.com/python/
@@ -16,7 +16,8 @@ LICENSE_TEXT=	See: https://www.jetbrains.com/store/license.html
 LICENSE_PERMS=	no-dist-mirror no-dist-sell pkg-mirror no-pkg-sell auto-accept
 
 RUN_DEPENDS=	intellij-fsnotifier>0:java/intellij-fsnotifier \
-		intellij-pty4j>0:java/intellij-pty4j
+		intellij-pty4j>=0.11.4:java/intellij-pty4j \
+		openjfx14>=0:java/openjfx14
 
 USES=		python:run shebangfix
 
@@ -46,14 +47,16 @@ do-install:
 # Remove bundled linux-only JRE
 	@${RM} -r ${STAGEDIR}${DATADIR}/jbr
 	@${RM} -r ${STAGEDIR}${DATADIR}/helpers/pydev/pydevd_attach_to_process
-	@${RM} ${STAGEDIR}${DATADIR}/lib/pty4j-0.5.jar
 	${INSTALL_SCRIPT} ${WRKDIR}/pycharm ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
 	${INSTALL_DATA} ${WRKDIR}/${PORTNAME}.desktop ${STAGEDIR}${PREFIX}/share/applications/
-	#cd ${WRKSRC}/lib && ${JAVA_HOME}/bin/jar xf icons.jar
-# TODO: Remove and enable fsnotifier when devel/libinotify is fixed
-# Disable filewatcher warning message on IDEA startup
-	${ECHO} "idea.filewatcher.disabled=true" >> ${STAGEDIR}${DATADIR}/bin/idea.properties
+# Use pty4j replacement provided by java/intellij-pty4j
+	${LN} -sf ${IDEA_HOME}/lib/libpty ${STAGEDIR}${DATADIR}/lib/pty4j-native
 # Use fsnotifier replacement provided by java/intellij-fsnotifier
 	${ECHO} "idea.filewatcher.executable.path=${IDEA_HOME}/bin/fsnotifier" >> ${STAGEDIR}${DATADIR}/bin/idea.properties
+# Fix "Typeahead timeout is exceeded" error
+	${ECHO} "action.aware.typeAhead=false" >> ${STAGEDIR}${DATADIR}/bin/idea.properties
+# Fix slow render
+	${ECHO} "-Dsun.java2d.xrender=false" >> ${STAGEDIR}${DATADIR}/bin/idea.vmoptions
+	${ECHO} "-Dsun.java2d.xrender=false" >> ${STAGEDIR}${DATADIR}/bin/idea64.vmoptions
 
 .include <bsd.port.mk>

devel/pycharm-pro/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1602752444
-SHA256 (pycharm-professional-2020.2.3.tar.gz) = 4c7bd5856fe83a921da91d83421e591d0455011733729a070f6ac4bf489ceb3c
-SIZE (pycharm-professional-2020.2.3.tar.gz) = 528810852
+TIMESTAMP = 1616048799
+SHA256 (pycharm-professional-2020.3.4.tar.gz) = 2060539f9c4c42819a58a7bcae1143d6383507907acd1cc4d1f05d2c0a93f3a1
+SIZE (pycharm-professional-2020.3.4.tar.gz) = 608172710

devel/pycharm-pro/files/pkg-message.in

@@ -1,36 +1,12 @@
 [
 { type: install
   message: <<EOM
-1. There is experimental native (faster) file watching support which is
-disabled by default.  Currently there are problems with watching large
-trees.  To enable, edit %%DATADIR%%/bin/idea.properties and append
+There is experimental native (faster) file watching support which is
+enabled by default. Currently there are problems with watching large
+trees (>600 files). To disable it, edit 
+%%DATADIR%%/bin/idea.properties and append:
 
-  idea.filewatcher.disabled=false
-  idea.filewatcher.executable.path=%%IDEA_HOME%%/bin/fsnotifier
-
-Only enable fsnotifier if your projects have < 600 files.
-
-2. Should you experience dialog boxes not accepting keyboard input (eg.
-Navigate | File) than set the custom property action.aware.typeAhead=false in
-Help | Edit Custom Properties.
-
-3. Some bundled and third party plugins depend on OpenJFX. For JDK11, the SDK
-version this PyCharm port depends on, FreeBSD does not yet have an OpenJFX port
-available. Hence these plugins will not work! 
-
-An example of that is the bundled, and by default enabled, reStructuredText
-plugin. As a result, clicking on a *.rst file does not seem to do anything. To
-verify that the missing OpenJFX library is indeed the culprit, from within
-PyCharm: 
-
-    Open: Help | Show log in <your file manager>
-    Open: idea.log
-    Scroll to the end (timestamp matching attempt to open *.rst file)
-    Look for: 'java.lang.NoClassDefFoundError: javafx/embed/swing/JFXPanel'
-
-A workaround is to simply disable the reStructuredText plugin in File |
-Settings | Plugins. It will allow *.rst to be opened and editted in the default
-text editor. 
+  idea.filewatcher.disabled=true
 EOM
 }
 ]

devel/pycharm-pro/files/pycharm-pro.desktop.in

@@ -4,7 +4,7 @@ Encoding=UTF-8
 Type=Application
 Name=JetBrains PyCharm Professional Edition IDE
 GenericName=JetBrains PyCharm Professional Edition IDE
-Icon=%%DATADIR%%/bin/pycharm.png
+Icon=%%DATADIR%%/bin/pycharm.svg
 Exec=%%DATADIR%%/bin/pycharm.sh
 Comment=Develop with pleasure!
 Terminal=false