mirror/freebsd-ports
1
0
Fork 0
mirror of https://git.FreeBSD.org/ports.git synced 2024-12-16 03:24:07 +00:00
Code Issues Releases Activity

Allow USES=go ports to override make targets & include <bsd.port.pre.mk>

Browse Source 
Prior to this change, if a port had:
- USES=go.mk,
- .include <bsd.port.pre.mk>, and
- overrode a make target (e.g. post-extract:)

then the following warnings were produced when invoking make on the port:
  make: "/usr/local/poudriere/ports/default/CATEGORY/PORT/Makefile" line XX: warning: duplicate script for target "post-extract" ignored
  make: "/usr/local/poudriere/ports/default/Mk/Uses/go.mk" line 68: warning: using previous script for "post-extract" defined here

This change fixes this issue by wrapping the definition of make targets
in a separate once-only !defined wrapper which is blocked until post.mk.
This concept was copied from Mk/Uses/python.mk.

PR:		224948
Submitted by:	woodsb02
Approved by:	jlaffaye (maintainer)
This commit is contained in:
Ben Woods 2018-03-11 02:24:26 +00:00
parent 1052d22ee6
commit ddc0a187c8
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=464138
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Mk/Uses/go.mk
View File

@ -62,6 +62,12 @@ PLIST_SUB+= GO_LIBDIR=${GO_LIBDIR} \
GO_SRCDIR=${GO_SRCDIR} \
GO_PKGNAME=${GO_PKGNAME}
_USES_POST+= go
.endif # !defined(_INCLUDE_USES_GO_MK)
.if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_GO_POST_MK)
_INCLUDE_USES_GO_POST_MK= yes
.if !target(post-extract)
post-extract:
@${MKDIR} ${GO_WRKSRC:H}
@ -90,4 +96,4 @@ do-install:
.endfor
.endif
.endif
.endif # defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_GO_POST_MK)