Add set pipefail in most framework scripts.

set pipefail changes the pipeline return status from being the return status of the last command to the last non 0 exit status of any command in the pipeline. This is needed to make sure all the commands in a pipeline did actually return a non 0 status and not only the last one.
svn path=/head/; revision=554139
2024-12-01 01:17:02 +00:00 · 2020-11-05 16:42:35 +00:00 · 2020-11-05 16:42:35 +00:00 · e9b2078c6c · 2021-03-31 03:12:20 +00:00
commit e9b2078c6c
parent cd36c020a0
22 changed files with 29 additions and 0 deletions
--- a/Mk/Scripts/check-desktop-entries.sh
+++ b/Mk/Scripts/check-desktop-entries.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/check-stagedir.sh
+++ b/Mk/Scripts/check-stagedir.sh
@ -12,6 +12,7 @@
 #  c. Files in plist which are owned by dependencies/MTREEs

 set -e
+set pipefail

 . ${SCRIPTSDIR}/functions.sh

--- a/Mk/Scripts/check-vulnerable.sh
+++ b/Mk/Scripts/check-vulnerable.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/check_leftovers.sh
+++ b/Mk/Scripts/check_leftovers.sh
@ -23,6 +23,8 @@
 # The PLIST_SUB feature can be disabled by setting PLIST_SUB_SED=
 # in environment.

+set pipefail
+
 [ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_CHECK_LEFTOVERS}" ] && set -x

 origin="$1"
--- a/Mk/Scripts/checksum.sh
+++ b/Mk/Scripts/checksum.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/create-manifest.sh
+++ b/Mk/Scripts/create-manifest.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/depends-list.sh
+++ b/Mk/Scripts/depends-list.sh
@ -3,6 +3,7 @@
 # $FreeBSD$

 set -e
+set pipefail

 . ${dp_SCRIPTSDIR}/functions.sh

--- a/Mk/Scripts/desktop-categories.sh
+++ b/Mk/Scripts/desktop-categories.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/dialog4ports.sh
+++ b/Mk/Scripts/dialog4ports.sh
@ -2,6 +2,7 @@
 # $FreeBSD$
 # Maintainer: portmgr@FreeBSD.org
 set -e
+set pipefail

 [ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_DIALOG4PORTS}" ] && set -x

--- a/Mk/Scripts/do-depends.sh
+++ b/Mk/Scripts/do-depends.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . ${dp_SCRIPTSDIR}/functions.sh

--- a/Mk/Scripts/do-fetch.sh
+++ b/Mk/Scripts/do-fetch.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/do-patch.sh
+++ b/Mk/Scripts/do-patch.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/do-users-groups.sh
+++ b/Mk/Scripts/do-users-groups.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/find-lib.sh
+++ b/Mk/Scripts/find-lib.sh
@ -2,6 +2,8 @@
 # MAINTAINER: portmgr@FreeBSD.org
 # $FreeBSD$

+set pipefail
+
 [ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_FIND_LIB}" ] && set -x

 if [ -z "${LIB_DIRS}" -o -z "${LOCALBASE}" ]; then
--- a/Mk/Scripts/generate-symbols.sh
+++ b/Mk/Scripts/generate-symbols.sh
@ -9,6 +9,8 @@
 # /usr/local/bin/ssh    -> /usr/local/lib/debug/usr/local/bin/ssh.debug
 LIB_DIR_PREFIX="${LOCALBASE}/lib/debug"

+set pipefail
+
 msg() {
        echo "====> $*"
 }
--- a/Mk/Scripts/install-desktop-entries.sh
+++ b/Mk/Scripts/install-desktop-entries.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/makesum.sh
+++ b/Mk/Scripts/makesum.sh
@ -4,6 +4,7 @@
 # MAINTAINER: portmgr@FreeBSD.org

 set -e
+set pipefail

 . "${dp_SCRIPTSDIR}/functions.sh"

--- a/Mk/Scripts/plist_sub_sed_sort.sh
+++ b/Mk/Scripts/plist_sub_sed_sort.sh
@ -5,6 +5,8 @@
 #
 # PLIST_SUB_SED helper to sort by longest value first.

+set pipefail
+
 awk '{
 	while (match($0, /s![^!]*![^!]*!g;/)) {
 		sedp=substr($0, RSTART, RLENGTH)
--- a/Mk/Scripts/ports_env.sh
+++ b/Mk/Scripts/ports_env.sh
@ -3,6 +3,8 @@
 # MAINTAINER: portmgr@FreeBSD.org
 # $FreeBSD$

+set pipefail
+
 if [ -z "${SCRIPTSDIR}" ]; then
 	echo "Must set SCRIPTSDIR" >&2
 	exit 1
--- a/Mk/Scripts/qa.sh
+++ b/Mk/Scripts/qa.sh
@ -2,6 +2,8 @@
 # MAINTAINER: portmgr@FreeBSD.org
 # $FreeBSD$

+set pipefail
+
 if [ -z "${STAGEDIR}" -o -z "${PREFIX}" -o -z "${LOCALBASE}" ]; then
 	echo "STAGEDIR, PREFIX, LOCALBASE required in environment." >&2
 	exit 1
--- a/Mk/Scripts/rust-compat11-canary.sh
+++ b/Mk/Scripts/rust-compat11-canary.sh
@ -2,6 +2,7 @@
 # MAINTAINER: rust@FreeBSD.org
 # $FreeBSD$
 set -eu
+set pipefail

 if [ "${OPSYS}" != FreeBSD ] || [ "${OSVERSION}" -lt 1200000 ]; then
 	exit 0
--- a/Mk/Scripts/smart_makepatch.sh
+++ b/Mk/Scripts/smart_makepatch.sh
@ -25,6 +25,8 @@
 # if those targets modify source files (e.g. with sed).  You may also
 # want to disable EXTRA_PATCHES as well if that is being used.

+set pipefail
+
 [ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_SMART_MAKEPATCH}" ] && set -x

 if [ -z "${PATCHDIR}" -o -z "${PATCH_WRKSRC}" -o -z "${WRKDIR}" ]; then