1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-10-20 20:09:11 +00:00

Fix install-missing-packages

r519284 introduced a new target, install-missing-packages, which is
meant to allow users to install dependencies via pkg(8) instead of
building them themselves locally.

The target was producing errors when the dependencies were already
available on the system. This commit adjusts this behavior to just
silently do nothing if everything is fine. Also, wrap the command
with SU_CMD for better user experience.

Also, fix some trailing whitespace introduced in the original commit.

Reviewed by:	bapt
Approved by:	portmgr
Differential Revision:	https://reviews.freebsd.org/D23484
This commit is contained in:
Mateusz Piotrowski 2020-02-04 10:01:23 +00:00
parent f3531eaf97
commit f42c5dfeb9
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=525138

View File

@ -605,7 +605,7 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org
# for this port.
# install-missing-packages
# - Install missing dependencies from package and mark
# them as automatically installed
# them as automatically installed.
# extract - Unpacks ${DISTFILES} into ${WRKDIR}.
# patch - Apply any provided patches to the source.
# configure - Runs either GNU configure, one or more local configure
@ -4332,7 +4332,8 @@ missing-packages:
# Install missing dependencies from package
install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \
${PKG_BIN} install -A $$(${ECHO} $${_dirs} | ${SED} "s%${PORTSDIR}/%%g")
[ -z "$${_dirs}" ] || \
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO} $${_dirs} | ${SED} "s%${PORTSDIR}/%%g")"
################################################################
# Everything after here are internal targets and really