1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-12-02 01:20:54 +00:00
Commit Graph

160 Commits

Author SHA1 Message Date
Matthias Andree
dec3c81ea9 Update security/openvpn 2.5. For 2.3 peers, update your configuration,
...see ports/UPDATING or the
ChangeLog: https://github.com/OpenVPN/openvpn/blob/release/2.5/Changes.rst#overview-of-changes-in-25

Avoid LibreSSL (IGNORE_SSL).
INSTALL_DATA -> INSTALL_MAN for documentation.
Rearrange Makefile according to portclippy.
2020-10-30 20:36:01 +00:00
Matthias Andree
05da552577 security/openvpn: fix test suite when ifconfig emits ::1/128 address format
Some systems apparently format output of ifconfig lo0 similar to
"inet6 ::1/128" instead of 12.1's "inet6 ::1 prefixlen 128". This
confuses the test script, so strip the slash and trailing prefixlen
off.

Since that bug affects the build-time test suite and its occurrence
breaks the build, no PORTREVISION bump needed.

Reported by:	des@
2020-10-06 23:28:13 +00:00
Matthias Andree
81e7824bde openvpn: Add one TODO marker (no functional change). 2020-07-17 13:58:34 +00:00
Matthias Andree
8f2ea341c9 security/openvpn: future proofing, PLUGINDIR now ...
...configured the official way, not hacky (which failed in openvpn-devel
because it broke some configure tests).
2020-07-17 10:30:37 +00:00
Matthias Andree
20ed7ce24d security/openvpn: cherry-pick fixes from git repo
* 098edbb1 2020-05-20 | Switch assertion failure to returning false [Jeremy Evans]
* fc029714 2020-05-30 | pool: prevent IPv6 pools to be larger than 2^16 addresses [Antonio Quartulli]
* 38b46e6b 2020-02-20 | Persist management-query-remote and proxy prompts [Selva Nair]

MFH:		2020Q2 (blanket approval for stability fixes)
2020-05-31 08:40:02 +00:00
Matthias Andree
ec578cb332 security/openvpn: reliability fixes cherry-picked from upstream
Arne Schwabe's OpenSSL fix for Debian Bug#958296
"Fix tls_ctx_client/server_new leaving error on OpenSSL error stack"
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958296> [1]

Selva Nair's auth-pam fixes
"Parse static challenge response in auth-pam plugin"
"Accept empty password and/or response in auth-pam plugin"

Re-diff (with make makepatch) older patches.

Reported by:	Jonas Andradas via Debian BTS
Obtained from:	Arne Schwabe, Selva Nair <https://github.com/OpenVPN/openvpn/tree/release/2.4>
MFH:		2020Q2 (blanket for backporting reliability fixes)
2020-05-07 16:28:42 +00:00
Matthias Andree
d21d4b9d5f security/openvpn: update to 2.4.9 (also for -mbedtls slave port)
At the same time, remove ASYNC_PUSH_LIBS workaround from [1].

Changelog (high-level):
https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-249

Git changelog, marking the three fixes that were already in 2.4.8_3
as cherry-picks with a 1, 2, or 3 instead of "*" to correspond
with the PORTREVISION, and those with "-" that are specific to other systems,
say, Windows.

* 9b0dafca 2020-04-16 | Preparing release v2.4.9 (ChangeLog, version.m4, Changes.rst) (tag: v2.4.9) [Gert Doering]
3 f7b318f8 2020-04-15 | Fix illegal client float (CVE-2020-11810) [Lev Stipakov]
* 9bb285e3 2020-03-13 | Fix broken async push with NCP is used [Lev Stipakov]
- 5f8a9df1 2020-02-12 | Allow unicode search string in --cryptoapicert option [Selva Nair]
- 4658b3b6 2020-02-12 | Skip expired certificates in Windows certificate store [Selva Nair]
* df5ea7f1 2020-02-19 | Fix possible access of uninitialized pipe handles [Selva Nair]
* 1d9e0be2 2020-02-19 | Fix possibly uninitialized return value in GetOpenvpnSettings() [Selva Nair]
* 5ee76a8f 2020-03-28 | Fix OpenSSL 1.1.1 not using auto elliptic curve selection [Arne Schwabe]
* ed925c0a 2020-04-07 | OpenSSL: Fix --crl-verify not loading multiple CRLs in one file [Maxim Plotnikov]
* 2fe84732 2020-03-30 | When auth-user-pass file has no password query the management interface (if available). [Selva Nair]
* 908eae5c 2020-04-03 | Move querying username/password from management interface to a function [Selva Nair]
* 15bc476f 2020-04-02 | Fix OpenSSL error stack handling of tls_ctx_add_extra_certs [Arne Schwabe]
* 22df79bb 2020-04-01 | Fetch OpenSSL versions via source/old links [Arne Schwabe]
* 0efbd8e9 2020-03-31 | mbedTLS: Make sure TLS session survives move [Tom van Leeuwen]
* 33395693 2020-03-25 | docs: Add reference to X509_LOOKUP_hash_dir(3) [WGH]
* 7d19b2bb 2019-10-21 | Fix OpenSSL private key passphrase notices [Santtu Lakkala]
2 8484f37a 2020-03-14 | Fix building with --enable-async-push in FreeBSD [Lev Stipakov]
* 69bbfbdf 2020-02-18 | Swap the order of checks for validating interactive service user [Selva Nair]
* 0ba4f916 2019-11-09 | socks: use the right function when printing struct openvpn_sockaddr [Antonio Quartulli]
1 3bd91cd0 2019-10-30 | Fix broken fragmentation logic when using NCP [Lev Stipakov]

PR:		244286 [1]
MFH:		2020Q2 (patchlevel bugfix release)
2020-04-17 18:38:44 +00:00
Matthias Andree
9e0d49b895 security/openvpn: Fix illegal client float (CVE-2020-11810)
There is a time frame between allocating peer-id and initializing data
channel key (which is performed on receiving push request or on async
push-reply) in which the existing peer-id float checks do not work right.

If a "rogue" data channel packet arrives during that time frame from another
address and with same peer-id, this would cause client to float to that new
address.

The net effect of this behaviour is that the VPN session for the "victim
client" is broken. Since the "attacker client" does not have suitable keys,
it can not inject or steal VPN traffic from the other session. The time
window is small and it can not be used to attack a specific client's session,
unless some other way is found to make it disconnect and reconnect first.

This fix is inherited by the openvpn-mbedtls slave port.

Obtained from:	Lev Stipakov (OpenVPN)
MFH:		2020Q2 (blanket security patch)
Security:	CVE-2020-11810
Security:	8604121c-7fc2-11ea-bcac-7781e90b0c8f
2020-04-16 09:46:15 +00:00
Matthias Andree
59e157c12b security/openvpn: Add a FIXME marker to clean up a local workaround that was upstreamed for 2.4.9. [info: Lev Stipakov]
PR: 244286
2020-03-16 22:58:26 +00:00
Matthias Andree
62c776befb openvpn: Add default-off ASYNC_PUSH option.
When enabled, pulls in devel/libinotify, and
adds --enable-async-push to configure.

In contrast to garga@'s proposal, uses
ASYNC_PUSH_LIBS instead of a patch file.

PR:		244286
Submitted by:	garga@
2020-02-21 20:15:50 +00:00
Matthias Andree
2ba01738a7 Reduce fragmentation when using ncp-ciphers
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18975.html
2020-01-26 15:04:37 +00:00
Matthias Andree
35b9d959ec Allow build without compression libs.
In that situation, add ./configure --enable-compression-stub.

While here, rearrange Makefile and use _ENABLE rather than _OFF
tags for the options.

Submitted by:	Daniel Engberg
Differential Revision:	https://reviews.freebsd.org/D23190
2020-01-26 14:40:32 +00:00
Matthias Andree
81f5b95e4b security/openvpn[-mbedtls] upstream update to OpenVPN 2.4.8
This upstream release integrated two FreeBSD patches by Kyle Evans and me,
which are herewith dropped from the port.

Upstream release banner
"This is primarily a maintenance release with minor bugfixes and improvements."

High-level changes:
<https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-248>

Manually filtered FreeBSD-related excerpt from Git log: v2.4.7..v2.4.8:
-  mbedtls: fix segfault by calling mbedtls_cipher_free() in cipher_ctx_free() [Antonio Quartulli]
-  openssl: Fix compilation without deprecated OpenSSL 1.1 APIs [Rosen Penev]
-  Force combinationation of --socks-proxy and --proto UDP to use IPv4. [Gert Doering]
-  Ignore --pull-filter for --mode server [Richard Bonhomme]
-  Fix typo in NTLM proxy debug message [Mykola Baibuz]
-  tests/t_lpback.sh: Switch sed(1) to POSIX-compatible regex. [Kyle Evans]
-  Handle PSS padding in cryptoapicert [Selva Nair]
-  Fix regression, reinstate LibreSSL support. [Matthias Andree]
-  Increase listen() backlog queue to 32 [Gert Doering]
-  Wrong FILETYPE in .rc files [Gisle Vanem]
-  Do not set pkcs11-helper 'safe fork mode' [Hilko Bengen]
-  man: correct the description of --capath and --crl-verify regarding CRLs [Michal Soltys]
-  Fix various compiler warnings [Lev Stipakov]
-  build: Package missing mock_msg.h [David Sommerseth]
-  cmocka: use relative paths [Steffan Karger]
-  docs: Update INSTALL [David Sommerseth]
-  Better error message when script fails due to script-security setting [Selva Nair]
-  Fix documentation of tls-verify script argument [Thomas Quinot]

Detailed changes:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24#OpenVPN2.4.8>

Build tests in poudriere and in a live system succeeded on:
11.2-RELEASE 1102000 arm64.aarch64
11.2-RELEASE 1102000 mips.mips64
11.2-RELEASE-p14     i386
11.3-RELEASE-p3      amd64
12.0-RELEASE-p10     i386
12.0-RELEASE-p6      amd64
12.0-RELEASE-p10     amd64 (live)

MFH:		2019Q4
2019-11-01 11:54:44 +00:00
Matthias Andree
f94cbf23e2 security/openvpn: regression fix, support LibreSSL again.
(I use a different patch than what was submitted by pizzamig@,
and have sent our patch upstream.)

Remove IGNORE_SSL.

While here, remove USE_LDCONFIG to fix a portlint complaint,
and fix a typo in a Makefile comment.

PR:		238382
Reported by:	pizzamig@
2019-09-07 08:04:53 +00:00
Matthias Andree
5cf5a2a3b7 Fix a sed regexp from GNUism to POSIX.
Thanks!

Also sent upstream for inclusion today,
https://sourceforge.net/p/openvpn/mailman/message/36757480/ and
https://sourceforge.net/p/openvpn/mailman/message/36757481/

PR:		240306
Submitted by:	kevans@
2019-09-06 18:16:53 +00:00
Mathieu Arnold
bc89cd3d2c Convert to UCL & cleanup pkg-message (categories s) 2019-08-14 12:16:12 +00:00
Koichiro Iwao
222e095f2a Implement new virtual category: net-vpn for VPN related ports
based on discussion at ports@ [1]. As VPN softwares are put in different
physical category net and security. This is a little bit confusing. Let's
give them new virtual category net-vpn.

[1] https://lists.freebsd.org/pipermail/freebsd-ports/2019-April/115915.html

PR:		239395
Submitted by:	myself
Approved by:	portmgr (mat)
Differential Revision:	https://reviews.freebsd.org/D21174
2019-08-14 03:26:09 +00:00
Matthias Andree
aa5509fff0 OpenVPN won't compile with LibreSSL, mark IGNORE.
Upstream maintainers are massively pushing back against patches
offered so far with valid and concrete technical reasons and unsuitability
of the LibreSSL version API that will create a maintenance nightmare.
(And LibreSSL abusing the OpenSSL API.)

PR:		238382
Submitted by:	pizzamig
2019-07-13 08:31:14 +00:00
Matthias Andree
1da376f048 security/openvpn[-mbedtls] update to OpenVPN 2.4.7
Upstream release announcement:
"This is primarily a maintenance release with bugfixes and improvements.
One of the big things is enhanced TLS 1.3 support

Please note that LibreSSL is not a supported crypto backend. We accept
patches and we do test on OpenBSD 6.0 which comes with LibreSSL, but if
newer versions of LibreSSL break API compatibility we do not take
responsibility to fix that."

Move USES up to please portlint.

Change summary:
<https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-247>

Detailed change list:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24#OpenVPN2.4.7>
2019-02-21 19:30:52 +00:00
Dmitry Marakasov
d400344dea - Add LICENSE_FILE
- Update WWW

Approved by:	portmgr blanket
2018-11-05 09:30:18 +00:00
Tijl Coosemans
bf58b0f824 Update security/mbedtls to 2.13.0 and bump dependent ports. 2018-09-14 12:04:53 +00:00
Tijl Coosemans
ebd39b12a6 Update security/mbedtls to 2.12.0 and bump dependent ports.
MFH:		2018Q3
Security:	https://tls.mbed.org/tech-updates/security-advisories/mbedtls-security-advisory-2018-02
2018-08-10 14:23:15 +00:00
Tijl Coosemans
0528bd9bad Update security/mbedtls to 2.9.0 and bump dependent ports. 2018-06-07 12:16:47 +00:00
Mathieu Arnold
b4b1816b21 Only sleep in ports if BATCH/PACKAGE_BUILDING are not defined.
Sponsored by:	Absolight
2018-04-25 22:00:04 +00:00
Matthias Andree
e434336ced Update to new upstream bugfix release 2.4.6.
While here, warn and sleep for 10 s when building against LibreSSL.

Remove some cruft.

Change summary:
<https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-246>

Changelog:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24#OpenVPN2.4.6>

Reported by:	portscout
2018-04-25 21:09:11 +00:00
Tijl Coosemans
cd1fe74efa Update security/mbedtls to 2.8.0 and bump dependent ports.
MFH:		2018Q2
Security:	https://tls.mbed.org/tech-updates/releases/mbedtls-2.8.0-2.7.2-and-2.1.11-released
2018-04-23 19:26:32 +00:00
Matthias Andree
1677d7cc1b Fix build with LibreSSL 2.4.6
PR:		226568
Reported by:	Ralf van der Enden
Obtained from:	faminebadger <https://community.openvpn.net/openvpn/ticket/1038>
2018-03-13 22:50:33 +00:00
Matthias Andree
77939f8389 Update to new upstream bugfix release 2.4.5.
Change summary:
<https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-245>

Changelog:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24#OpenVPN2.4.5>

While here, add a sanity check that traps inconsistent linkage,
if, for instance, the PKCS#11 helper has been built with a different
OPENSSL library version than OpenVPN.
2018-03-13 00:10:33 +00:00
Tijl Coosemans
aa908db786 Update security/mbedtls to 2.7.1.
PR:		226550
MFH:		2018Q1
2018-03-12 13:01:53 +00:00
Tijl Coosemans
f6f4c350e7 - Update security/polarssl13 to 1.3.22.
- Update security/mbedtls to 2.7.0 and bump dependent ports.

MFH:		2018Q1
Security:	https://tls.mbed.org/tech-updates/security-advisories/mbedtls-security-advisory-2018-01
2018-03-10 18:49:04 +00:00
Alexey Dokuchaev
a247b2f47d Do not abuse INSTALL_MAN when installing documentation, examples, and
other miscellaneous files that are not actually manual pages (part 2).
2018-01-11 14:18:01 +00:00
Matthias Andree
63cd4a1f60 Add missing conflicts 2017-10-08 09:46:27 +00:00
Matthias Andree
9626dd78c0 OpenVPN[-mbedtls] security update to 2.4.4
Upstream maintainers write: "This release includes a large number of small
fixes and enhancements. There is also an important security fix for legacy
setups that may still be using key-method 1. As that option was deprecated
12 years ago we estimate that not many production setups are affected in
practice."

Security information:
<https://community.openvpn.net/openvpn/wiki/CVE-2017-12166>

Change Summary:
<https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-244>

Changes as Git shortlog:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24#OpenVPN2.4.4>

Given the low impact, let's forget about MFHing this three days before
2017Q3 becomes EOL and relieved by 2017Q4.

Reported by:	portscout
Security:	CVE-2017-12166
Security:	3dd6ccf4-a3c6-11e7-a52e-0800279f2ff8
2017-09-27 21:27:15 +00:00
Matthias Andree
2adeb1f9b2 OpenVPN security update to 2.4.3
OpenVPN v2.4.2 was analyzed closely using a fuzzer by Guido Vranken. In
the process several vulnerabilities were found, some of which are
remotely exploitable in certain circumstances.

Compared to OpenVPN 2.4.2 there are several bugfixes and one major
feature: support for building with OpenSSL 1.1.

MFH:		2017Q3 (preapproved by Xin Li)
Security:	9f65d382-56a4-11e7-83e3-080027ef73ec
Security:	CVE-2017-7508
Security:	CVE-2017-7512
Security:	CVE-2017-7520
Security:	CVE-2017-7521
Security:	CVE-2017-7522
2017-06-21 17:22:37 +00:00
Matthias Andree
e8b7e2e35b Switch MASTER_SITES from http to https URI scheme. 2017-05-19 21:20:19 +00:00
Matthias Andree
4ddb2857e5 OpenVPN update to 2.4.2 (security fixes)
ChangeLog:
<https://github.com/OpenVPN/openvpn/blob/v2.4.2/Changes.rst#version-242>

Details:
<https://github.com/OpenVPN/openvpn/releases/tag/v2.4.2>

Security Announcement:
<https://community.openvpn.net/openvpn/wiki/QuarkslabAndCryptographyEngineerAudits>

Reported by:	Samuli Seppänen
Security:	04cc7bd2-3686-11e7-aa64-080027ef73ec
Security:	CVE-2017-7478
Security:	CVE-2017-7479
MFH:		2017Q2
2017-05-11 21:19:20 +00:00
Matthias Andree
cca759b60e Update to openvpn release 2.4.1
This contains predominently bugfixes and compatibility with
newer OpenSSL/LibreSSL.

Remove one patch that had been cherry-picked from upstream, no longer
needed.

Summary: https://github.com/OpenVPN/openvpn/blob/release/2.4/Changes.rst#version-241
Changes: https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn24
2017-03-23 21:53:58 +00:00
Matthias Andree
a01977335f Fix build with LibreSSL 2.5.1.
PR:		217140
Submitted by:	brnrd@
Obtained from:	Olivier Wahrenberger, via upstream maintainers review
2017-03-21 23:04:59 +00:00
Matthias Andree
6077e6afc0 Flag conflict between PKCS11 and MBEDTLS in OPTIONS. 2017-01-05 08:38:30 +00:00
Matthias Andree
1a948efb1d OpenVPN update to v2.4.0, old version in openvpn23*.
OpenVPN has been updated to v2.4.0.
Changes: <https://github.com/OpenVPN/openvpn/blob/v2.4.0/Changes.rst>

openvpn-polarssl has been renamed to openvpn-mbedtls to match the TLS
library's change of name.

The prior versions of the openvpn ports have been preserved in openvpn23
and openvpn23-polarssl, respectively, and are set to expire 2017-03-31.
2016-12-27 23:16:57 +00:00
Matthias Andree
2e4ee5c5bb Upgrade to new upstream bugfix release 2.3.14.
Drop files/extra-patch-fix-subnet and corresponding OPTION, since this
is now part of the upstream release.

Changelog:	<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn23#OpenVPN2.3.14>
2016-12-08 03:01:18 +00:00
Matthias Andree
8cf2ecce41 Experimental patch for topology subnet.
Added as an extra patch behind an option that defaults to ON so people
can still opt out, this is slated for an upcoming 2.3.14 release that
is, however, not yet scheduled.

PR:		207831 (related)
Obtained from:	Gert Doering, via upstream Git repository 446ef5bda4cdc75d
2016-11-09 22:06:26 +00:00
Matthias Andree
1f2fa72e9e Upgrade to upstream bugfix release 2.3.13.
ChangeLog:
<https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn23#OpenVPN2.3.13>
2016-11-04 08:42:23 +00:00
Matthias Andree
e76da9426f Fix self-tests in poudriere, make them more robust [1].
The self-tests used to fail in poudriere with dependency cycles in
Makefile that weren't visible earlier. Conditionally change ALL_TARGET
to check (do not use all check, that would require gmake) if the TEST
option is set (default), or set TEST_TARGET if the TEST option is unset.

While I am unable to reproduce 212146 claiming the self-tests fail on an
IPv6-disabled host, and I believe it's a red herring masking a local
configuration issue, doubt sed(1) and add blanks, and be sure to add the
"proto" earlier. The reporter didn't mention his OS version.

No PORTREVISION bump since the default build is unaffected.

PR:		212146 [1]
2016-08-27 12:23:58 +00:00
Matthias Andree
2efda235d0 Make self-test the TEST option, support make test. Enabled by default.
NB: This is a critical port with many users, and the test is low on
resources, it takes two minutes idling, waiting for timers to expire.

Replace former ".if ... post-build:" by "post-build-TEST-on: test".
Replace former post-build by "TEST_TARGET=check".

Add a temporary (9 months or so-ish) compatibility wrapper to move
people from the prior port-specific WITHOUT_CHECK to WITHOUT=TEST or
OPTIONS_UNSET=TEST. Uses WARNING+= to make user aware of the change.

While here, shorten the POLARSSL_DESC help message.

Requested by:	brnrd@
Differential Revision:	D7507 (sort-of)
2016-08-27 09:32:30 +00:00
Matthias Andree
7a720cbaad Update Tunnelblick XOR patch.
PR:		212136
Submitted by:	Franco Fichtner
2016-08-27 01:17:24 +00:00
Mathieu Arnold
b89378d721 Fix build with tunnelblick patch.
Sponsored by:	Absolight
2016-08-25 12:58:16 +00:00
Matthias Andree
c12684409a Update to new upstream bugfix release 2.3.12, add "stats" to rc script.
* Upstream changes: <https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn23#OpenVPN2.3.12>
* The cmocka-based unit tests are currently disabled, too much hassle
  and deps to get them running.
* Add patch-configure to drop the unit-test related warnings.
* Extend run control script to understand the "stats" argument, to send
  SIGUSR2 to the process, contributed by Anton Yuzhaninov (with one
  additional line fold).
* Drop patch-629baad8, no longer needed.
* Refresh other patches with make clean extract do-patch makepatch
2016-08-24 22:33:25 +00:00
Matthias Andree
df18d093b2 Fix PolarSSL-based builds.
The upstream backported a change from the master branch that fixes the
PolarSSL-based builds to go with the PolarSSL 1.3.X built-in defaults.

Add a patch picked from the upstream's release/2.3 branch.
Remove the BROKEN= line and conditional.

No PORTREVISION bump because the patch only affects an option that was
formerly marked BROKEN.

(TRYBROKEN users need to force a rebuild and reinstallation manually.)
2016-05-13 16:07:26 +00:00
Matthias Andree
603b358714 Security upgrade to OpenVPN 2.3.11, breaking POLARSSL option.
Quoting upstream maintainers' release notes:
"This release fixes two vulnerabilities: a port-share bug with DoS
potential and a buffer overflow by user supplied data when using pam
authentication. In addition a number of small fixes and improvements are
included."

WARNING: this upgrade breaks the PolarSSL-based build due to an
oversight in the cipher suite selection hardening, crashing
PolarSSL-based builds with a 0-pointer deferences.
Marking port BROKEN if POLARSSL is set.

Changelog: https://community.openvpn.net/openvpn/wiki/ChangesInOpenvpn23
2016-05-12 23:38:15 +00:00