These ports were including chinese/ttfm/Makefile.ttf using an absolute
path using PORTSDIR instead of a relative one using .CURDIR. In
specific use cases, PORTSDIR will fail but .CURDIR always works. As
a bonus, this allows <pre> & <post> inclusions to be removed as well.
Covered by an old blanket permission (bapt) but only two of these ports
have maintainers anyway.
This port was in bad shape!
1) It had a MASTER_SITES definition pointing to a FreeBSD mirror. This
was a circular dependency that broke when the "real" master site
domain disappeared. Fix this by hosting at LOCAL/MARINO
2) The kai-pc ttf font was never installed (always broken)
3) It broke (more) with recent chinese font work
4) It included makefile.tty by absolute ${PORTDIR} instead of
correct ${.CURDIR}, which also unnecessarily required <pre>, <post>
5) It wasn't staged
So fix all that. Also improve efficiency of staging by copying directly
from distfiles to stage directory instead of first copying to WRKSRC then
STAGEDIR. The post-install target is no longer needed, nor is the
pkg-plist file.
Where possible, correct a few instances where PORTDOCS was being used
to flag stuff in EXAMPLESDIR. For some ports, mostly those owned by
ruby@, PORTDOCS is applied to pretty much everything whether it's
documentation or example.
- ports that set USE_SQLITE with the *_USE option helper
- ports that depend on libsqlite3 indirectly as reported by pkg rquery
Approved by: portmgr (implicit)
By request of Gea-Suan Lin <gslin@gslin.org> - reset ports to ports@FreeBSD.
Gea-Suan Lin's work is much appreciated.
Approved by: portmgr (implicit) (not really, skipping NO_STAGE check)
- Add LIBS="${LIBS}" to MAKE_ENV and CONFIGURE_ENV.
- Add an option helper for LIBS.
- Adjust all ports that already use LIBS. Also remove references to
PTHREAD_CFLAGS and PTHREAD_LIBS while here.
- Some ports did not support having a LIBS environment variable and
required additional patches.
Somewhat simplified a linker command line looks like:
${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS}
where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and
LIBS can be controlled by us. If possible -L and -l flags need to be
added to LIBS to make sure they appear after any -L and -l flags set by
upstream. Many ports currently add -L${LOCALBASE}/lib to LDFLAGS but this
may appear too early on the command line causing installed libraries to
be linked in instead of freshly built ones.
Additional changes:
benchmarks/netio: Replace WITH_IPV6 with an IPV6 option.
comms/gnokii: Replace some patches with USES=pathfix. Also remove -fPIC.
graphics/gimageview: USES=libtool and install desktop file in DESKTOPDIR.
graphics/visionworkbench: Remove FreeBSD 7 support.
multimedia/libmovtar: New LIB_DEPENDS syntax.
multimedia/opencinematools: Use standard do-build.
net/siproxd: USES=libtool:keepla (port actually needs .la files for plugins)
net-mgmt/nagios: Remove -fPIC.
net-mgmt/nagios4: Remove -fPIC.
print/cups-base: Only add -lssp_nonshared on i386 and OSVERSION < 1000036.
security/p11-kit: Replace PTHREAD_LIBS in CONFIGURE_ENV with
ac_cv_func_pthread_mutexattr_init=no in CONFIGURE_ARGS. This skips a test
in configure that falsely detects pthread_mutexattr_init in our libc.
sysutils/dar: Fix iconv detection.
x11/rxvt-unicode: Remove -lstdc++ and patch configure to remove a FreeBSD
hack and use $CXX as linker as on other platforms.
PR: 190592
Exp-run by: antoine
Approved by: portmgr (antoine)
- Speed staging phase by really installing to the stagedir directly
- Rework to use predefined targets for build and install
- Strip binaries
- Remove now unnecessary dependencies on autotools
- Add patches to fix crashes with icu 53.1
Related to:
PR: 186425
It looks NO_STAGE should have been removed when irc/bitchx was staged.
Late add: Fix master irc/bitchx to not override PORTREVISION
Starting with perl 5.20, they're not installed any more if empty,
and on FreeBSD, they're (always ?) empty.
PR: 190681
Submitted by: mat
Exp-Run by: antoine
Sponsored by: Absolight
When building a port with base system make, variables like CC and CFLAGS
need to be defined using '=' in the makefile. With '+=' values from
make.conf can be picked up. Normally the ports system values for these
variables are passed to a configure script which generates a makefile with
them. If there's no configure script the makefile has to be patched to use
the right values.
