Note: The following ports did not pass check-plist (CP) or stage-qa (QA)
tests. The sendmail port has many problems, but this was already known
by myself as I fixed it properly on DPorts last week. It's a forward
action to submit a PR against mail/sendmail.
* antivirus-milter (CP)
* dk-milter (CP)
* milter-regex (CP)
* sendmail (CP, QA)
approved by: PTHREAD blanket
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().
In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
constructions that parse out to [ -z "$foo" ] && foo=""
These are bad examples that get copied and pasted into new code, so the
hope is that with less bad examples there will be less need for me to
bring this up in review.
In a few of these files all that were changed were comments so that next
time I search for these patterns I won't trip on the file for no reason.
In a few places, add $FreeBSD$
No functional changes, so no PORTREVISION bumps
propogated by copy and paste.
1. Primarily the "empty variable" default assignment, which is mostly
${name}_flags="", but fix a few others as well.
2. Where they are not already documented, add the existence of the _flags
(or other deleted empties) option to the comments, and in some cases add
comments from scratch.
3. Replace things that look like:
prefix=%%PREFIX%%
command=${prefix}/sbin/foo
to just use %%PREFIX%%. In many cases the $prefix variable is only used
once, and in some cases it is not used at all.
4. In a few cases remove ${name}_flags from command_args
5. Remove a long-stale comment about putting the port's rc.d script in
/etc/rc.d (which is no longer necessary).
No PORTREVISION bumps because all of these changes are noops.
KEYWORD: FreeBSD scourge. We have ignored this keyword
for a long time now, so this is a non-functional change
(therefore no PORTREVISION bumps).
Insert a $FreeBSD tag where needed, and adjust a comment
in mail/milter-regex to match reality.
diff -urN showed that no file was changed, only the name of the WRKSRC
used DIST_SUBDIR to save users and mirrod from stalled updates.
Reported by: ache
