This "fix" for FreeBSD doesn't look right to me; I don't think it should
be using OSVERSION to determine which compiler is being used. Until its
fixed better, make sure OSVERSION is only compared on FreeBSD.
changes that Debian made to their libtool. The first command applies to
libtool versions 1.4 and up. The second command is somewhat more elaborate
but essentially it uses the sed hold space to move an "elif...fi" block
down. It applies to 2.x. Together these reduce overlinking to unpatched
.la files (from ports that don't have USES=libtool yet but also .la files
in the work directory).
The third and fourth command fix relinking. During staging libtool may
relink libA when it links to another library in the work directory libB.
The reason is that libA created during build phase has its runpath set to
the location of libB in the work directory. This allows running an
executable that links to libA from within the work directory. The relink
removes this extra runpath.
When libtool relinks libA it replaces "libB.la" on the linker command line
with "-L${STAGEDIR}${PREFIX}/lib -lB" with the intention to link to libB in
the stage directory but this -L flag isn't necessarily the first so another
libB may be linked instead. The two sed commands make relink the same as a
normal link. This means libtool will relink with libraries from the work
directory using a path similar to "../srcB/.libs/libB.so" without -L flags.
This applies to libtool 1.4 and up. Earlier versions don't seem to relink
libraries.
(This fixes ports like devel/apr1 so they link with freshly built libraries
instead of installed libraries.)
Fix all ports with missing libraries.
Additionally:
archivers/rpm4: USES=patchfix.
databases/gdbm: INSTALL_TARGET=install-strip.
devel/gnome-vfs: remove patch that doesn't change anything.
devel/ois: INSTALL_TARGET=install-strip and use standard USE_AUTOTOOLS.
devel/zziplib: INSTALL_TARGET=install-strip, MAKE_CMD.
multimedia/mjpegtools: remove USE_AUTOTOOLS, use modern compiler on i386
instead of disabling optimisations.
net/libnetdude: disable static plugins.
PR: 190941
Exp-run: antoine
Approved by: portmgr (antoine)
Sylvio's last commit was 17 months ago, a full 5 months after all of his
ports could have been reset per policy. Given the push to complete
staging (48 ports are still unstaged, something like 70+ have already
been staged by other committers) and given that PRs are automatically
assigned but never addressed, it's better just to reset all the ports and
PRs so that it's clear to others that these ports are free to maintain.
Approved by: portmgr (implicit)
- Add LIBS="${LIBS}" to MAKE_ENV and CONFIGURE_ENV.
- Add an option helper for LIBS.
- Adjust all ports that already use LIBS. Also remove references to
PTHREAD_CFLAGS and PTHREAD_LIBS while here.
- Some ports did not support having a LIBS environment variable and
required additional patches.
Somewhat simplified a linker command line looks like:
${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS}
where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and
LIBS can be controlled by us. If possible -L and -l flags need to be
added to LIBS to make sure they appear after any -L and -l flags set by
upstream. Many ports currently add -L${LOCALBASE}/lib to LDFLAGS but this
may appear too early on the command line causing installed libraries to
be linked in instead of freshly built ones.
Additional changes:
benchmarks/netio: Replace WITH_IPV6 with an IPV6 option.
comms/gnokii: Replace some patches with USES=pathfix. Also remove -fPIC.
graphics/gimageview: USES=libtool and install desktop file in DESKTOPDIR.
graphics/visionworkbench: Remove FreeBSD 7 support.
multimedia/libmovtar: New LIB_DEPENDS syntax.
multimedia/opencinematools: Use standard do-build.
net/siproxd: USES=libtool:keepla (port actually needs .la files for plugins)
net-mgmt/nagios: Remove -fPIC.
net-mgmt/nagios4: Remove -fPIC.
print/cups-base: Only add -lssp_nonshared on i386 and OSVERSION < 1000036.
security/p11-kit: Replace PTHREAD_LIBS in CONFIGURE_ENV with
ac_cv_func_pthread_mutexattr_init=no in CONFIGURE_ARGS. This skips a test
in configure that falsely detects pthread_mutexattr_init in our libc.
sysutils/dar: Fix iconv detection.
x11/rxvt-unicode: Remove -lstdc++ and patch configure to remove a FreeBSD
hack and use $CXX as linker as on other platforms.
PR: 190592
Exp-run by: antoine
Approved by: portmgr (antoine)
Related to:
PR: 186425
It looks NO_STAGE should have been removed when irc/bitchx was staged.
Late add: Fix master irc/bitchx to not override PORTREVISION
Starting with perl 5.20, they're not installed any more if empty,
and on FreeBSD, they're (always ?) empty.
PR: 190681
Submitted by: mat
Exp-Run by: antoine
Sponsored by: Absolight
Dave Shar <koalative at gmail.com> wishes to maintain these ports
with my help.
deskutils/py-send2trash
- Change Makefile header, use my name and @FreeBSD.org email
- Pass maintainership to koalative at gmail.com
- Change license BSD to BSD3CLAUSE
- Use USE_PYDISTUTILS=yes instead of easy_install
- Remove PYDISTUTILS_PKGNAME and add PYDISTUTILS_AUTOPLIST
graphics/founts
- Change Makefile header, use my name and @FreeBSD.org email
- Pass maintainership to koalative at gmail.com
- Add REINPLACE, fix ELAST
- Change distinfo, remove supplied icon
graphics/py-pyggel
- Pass maintainership to koalative at gmail.com
graphics/radius-engine
- Change Makefile header, use my name and @FreeBSD.org email
- Pass maintainership to koalative at gmail.com
irc/py-fishcrypt
- Pass maintainership to koalative at gmail.com
sysutils/gigolo
- Change Makefile header, use my name and @FreeBSD.org email
- Pass maintainership to koalative at gmail.com
- Use tar:bzip2 instead of USE_BZIP2=yes
- Remove TODO from DOCS
- Remove useless .include <bsd.port.options.mk>
- Change pkg-plist, remove mtree
and consumers of lang/python31 or lower to use Python 2.X
This is in preparation of removing lang/python31 which expired on 2014-06-01
While here apply some fixes for textproc/codespell:
- USE_XZ -> USES=tar:xz
- remove unneeded USE_PYTHON_RUN line
Approved by: python (mva)
- Support stage [3]
- Switch to options helpers
- Update patches, and rename them to follow makepatch naming
maintainer timeout [1] [2] [3]
-> take over maintainership
PR: ports/184150 [1], ports/187117 [2], ports/189615 [3]
Submitted by: Ryan Frederick [1], Jean-Sébastien Pédron [2], Ryan Frederick [3]
Sponsored by: Absolight
lang/lua51 is working the same way lang/lua52, chase ports using lua 5.1
Make the default lua lua52
Make all lua ports using USES=lua
Approved by: portmgr (implicit)
to "USES=libtool tar:bzip2". Bump PORTREVISION on all dependent ports
and modernise them as well (USES, LIB_DEPENDS, staging).
audio/pidgin-musictracker:
- Replace LIBS with LDFLAGS.
- Disable static plugin.
net/online-desktop: Remove obsolete patches.
net-im/mbpurple:
- Drop pkgconf dependency.
- Replace post-patch with MAKE_ARGS.
- Use standard do-build.
net-im/pidgin-audacious-remote: Disable static plugin.
net-im/pidgin-birthday-reminder: Disable static plugin.
net-im/pidgin-fetion: Replace pkg-plist with PLIST_FILES.
net-im/pidgin-guifications:
- Drop USE_GNOME=gnomeprefix.
- Replace LIBS with LDFLAGS.
net-im/pidgin-hotkeys:
- Drop CFLAGS=-fPIC.
- Fix build on systems without gcc.
net-im/pidgin-libnotify:
- Use option helpers.
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.
net-im/pidgin-manualsize: Fix build on systems without gcc.
net-im/pidgin-privacy-please:
- Replace a patch with CPPFLAGS and LDFLAGS.
- Don't use USE_LDCONFIG for a plugin.
net-im/pidgin-sipe:
- Don't use USE_LDCONFIG for a plugin.
- Drop PORTDOCS that don't contain useful documentation.
- Patch configure with s/LDLAGS/LDFLAGS/ so LDFLAGS can replace LIBS.
- Use option helpers and fix Kerberos option.
- Remove obsolete CONFIGURE_ENV.
security/pidgin-encryption:
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.
- Disable static plugin.
- Use option helpers.
security/pidgin-otr:
- Drop redundant comment about PORTREVISION.
- Add USE_GNOME=gtk20.
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.
- Port uses stack protector unconditionally so link with -lssp_nonshared
when necessary like Mk/bsd.ssp.mk does.
Approved by: portmgr (PORTREVISION bump on unstaged port)
- Remove leading article from COMMENT
- Convert to new LIB_DEPENDS format
- Remove Author line from pkg-descr
- Docdir safe, use DOCSDIR sub in pkg-plist
