o Make the Makefile respect CC, and respect CFLAGS when linking, too.
o Make a comparison for fputs() success "retval >= 0". Our manual says
fputs() returns 0 on success, but K&R says that it can return any non-
negative int on success. I might as well support either!
o Fix an improper bounds check. It was a simple case of a variable being
mixed up, and this prevents "calc really long arg list (REALLY LONG)"
from crashing calc.
This is just cleaning up the changes I effected earlier with the
maintainer's permission.
it's a safe bet that the ftp service would be too. Re-order the MASTER_SITES
to try and avoid trying the same broken site twice.
(2) Follow the bouncing checksum. The old one might need to be re-added.
(3) Respect CFLAGS properly.
[Has anyone figured-out what makes the number 393 so interesting to PW, now?]
I wonder what was going through Jordan's head during his infamous
$Id$-smashing commit.
Before I forget....
Thanks to naddy@mips.rhein-neckar.de (Christian Weisgerber) for prompting
this commit. See msg-id: 7geokh$tje$1@mips.rhein-neckar.de
bsd.port.mk rev. 1.304 for details on the change.
The fix here is one of the following.
(1) Define USE_BZIP2 instead of BUILD_DEPENDS on bzip2 and redefining
EXTRACT_* commands.
(2) Change ${EXTRACT_CMD} to ${TAR} when the command is obviously
calling the "tar" command (i.e., arguments like "-xzf" are spelled
out).
(3) If ${EXTRACT_CMD} is called directly with ${EXTRACT_BEFORE_ARGS},
add ${EXTRACT_AFTER_ARGS} to the command line as well.
(4) If any of EXTRACT_CMD, EXTRACT_BEFORE_ARGS or EXTRACT_AFTER_ARGS
is set, define the other two too.
changed distfile from calc-2.9.3t6.tar.gz to calc-2.9.3t6.tar
calc is fetched as an on-the-fly tarball from ftp.cdrom.com
gzipped on-the-fly tars are not supported.
removed trailing whitespace on several lines in PLIST
revised DESCR to <24 lines.
PLISTs.
Note: I know that this is going to break some symlinks and/or .so
includes, I will back some of these out as I run into these during
package building.
all the COMMENTs! No package names, no version numbers, no "this is
absolutix-3.1.2" type comments that have zero information contents.
Now, without any bad examples to follow, nobody has an excuse to import
a port with those kind of comments. :)
Phew! 238 ports modified!