* The check for quoted COMMENTs had a typo. However, this check has been
consolidated for other macros that should not be quoted. Merge the COMMENT
check into the BROKEN, et al check. [1]
* Properly pluralize the message which counts the number of fatal errors
and warnings. [2]
* Add distinfo checking support. [3]
* Huge refactoring of the error handling code. If the -g argument is specified,
errors will be grouped together to avoid spamming the console with
repeated lines.
* Add a check for icon installation, and recommend INSTALLS_ICONS.
PR: 97207 [1]
96089 [2]
96923 [3]
Submitted by: lawrance [1]
ehaupt [2]
sem [3]
Tested by: mezz
* Add a check for .mo (translation) files, and warn if USE_GETTEXT is not
set. [1]
* Make sure USE_RC_SUBR checking does macro expansion to catch cases were
USE_RC_SUBR=${PORTNAME} (for example). [2]
PR: 93273 [2]
Requested by: kris [1]
* Add a check to see if PORTREVISION=0 in master ports. [1]
* Add checks for direct use of the pkg_* commands. [2]
* Add a check that if a port is new, it is not maintained by
ports@FreeBSD.org. [3]
* Do not warn about .la files if USE_KDELIBS_VER is set. [4]
* Add a check for deprecated use of USE_RC_SUBR along with checks for its
proper use. [5]
PR: 91324 [1]
92888 [2]
92665 [3]
92586 [4]
Submitted by: lofi [4]
dougb [5]
* Update quoting requirements for new bsd.port.mk
* Warn on use of USE_REINPLACE [1]
* Recommend @dirrmtry instead of @unexec rmdir [1]
Requested by: pav [1]
* Warn on use of .tar.bz2 as an EXTRACT_SUFX [1]
* Throw a fatal error if INFO is defined, and install-info is called
directly [2]
* Throw a warning if install-info is called directly and INFO is not
defined [2]
PR: 89952 [2]
Requested by: Kövesdán Gábor <gabor.kovesdan@t-hosting.hu> [1]
* USE_PYTHON still cannot be included after bsd.port.pre.mk
* USE_APACHE can now be included after bsd.port.pre.mk [1]
* Handle the new autotools world order
* Check that IGNORE is properly capitalized and terminated [2]
PR: 88546 [2]
Reported by: pav [1]
Submitted by: lawrance [2]
* USE_PYTHON can now safely appear after bsd.port.pre.mk
* Expand the .elseif search to cover ".else if" as well
* Don't complain on direct use of autotools if we're using USE_AUTOTOOLS
* Don't check embedded comments for direct command use
* Add '+' to the list of valid characters for file names in the warning
message.
* Check to make sure OPTIONS is specified before bsd.port.pre.mk (only if
OPTIONS is actually defined). [1]
PR: 82316 [1]
Submitted by: sem [1]
* Check to make sure only characters [-.a-zA-Z0-9_] appear in file names [1]
* Check for proper quoting of IGNORE and BROKEN [1]
* Check to see if README.html is being committed [1]
* Check for uses of .elseif [2]
Submitted by: krion [1]
Suggested by: bsdcrank <bsdcrank@squbes.com> [2]
* Add a check to make sure a WWW is defined in pkg-descr (this is a nice
thing to have) [1]
* Add a slew of Java-related checks (see
http://wikitest.freebsd.org/moin.cgi/JavaPortlint for more details) [2]
* Add @mode to the list of plist directives to warn about [3]
PR: 78126 [1]
78947 [3]
Requested by: hq [2]
Submitted by: leeym [1]
Renato Botelho <renato@galle.com.br> [3]
* Do not warn on direct command use if the command is preceeded by "--" [1]
* Add a check for ports installing charset.alias or locale.alias. In most
cases these ports should depend on libiconv or gettext, and not install
their own copies of these files [2]
PR: 77410 [2]
Requested by: gerald [1]
Submitted by: leeym [2]
* Ignore comments when checking for absolute pathname usage
* Check DISTNAME for uses of PORTREVISION and PORTEPOCH [1]
* Make sure to quote meta-characters in PORTNAME before using it as a
regular expression [1]
* Fix bug when matching OPTIONS in ".if defined(WITH_OPT1) &&
defined(WITHOUT_OPT2)" [2]
* Update OMF checks to account for the new INSTALLS_OMF macro
* Update GConf checks to account for the new GCONF_SCHEMAS macro
PR: 73536 [2]
Submitted by: mat [1]
leeym [2]
* Check PLIST_FILES for shared libraries, and make sure
INSTALLS_SHLIB is defined [1]
* Check DATADIR and MAN3PREFIX macros [2]
* Check OPTIONS [3]
PR: 71405 [2]
71468 [3]
Requested by: michael johnson <ahze@ahze.net> [1]
Submitted by: leeym [2] [3]
* Switch the direct use of ``echo'' check to suggest ${ECHO_CMD} or
${ECHO_MSG} instead of ${ECHO} [1]
* Tighten the check for improper GConf schema handling so that we only look
in the GConf schemas directory [2]
* Correct some grammar mistakes [3]
* Avoid erroneous "direct use of command" warnings [4]
PR: 71159 [4]
Submitted by: gerald [1]
pav [3]
eik [4]
Reported by: pav [2]
* Fix a typo in the libtool archive hint [1]
* Check for ports that have a poorly specified CONFLICTS line as well as ports
that conflict with themselves [2]
* Check for proper handling of gconf schemas
* Check for explicit listing of %gconf keys in the plist
Spotted by: lofi [1]
Submitted by: eik [2]
* Fix a bug introduced in the "use strict" conversion, and don't check patch
files for trailing blank lines
* Add a check to make sure pkg-config files are installed into the correct
location [1]
* Fix some nearby spacing nits
Requested by: pav [1]
* Remove check for SIZE and MD5 in distinfo since this was a rush job, and
missed some common cases. [1]
* Re-enable use strict, and fix portlint to obey it
Requested by: eik [1]
* Add a generic check for deprecated macros (e.g. the recent autotools batch),
and add USE_MESA to the set [1]
* Only use USE_LIBTOOL_VER for checking .la file installation [1]
* Add a check for USE_LIBLTDL and warn about directly using a libltdl
dependency [1]
* Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries
if NO_SIZE and NO_CHECKSUM are not defined
Submitted by: krion and tobez [1]
* Do not complain about SIZE if NO_SIZE is set [1]
* Allow ``%%PORTDOCS%%@unexec rmdir %D/%%DOCSDIR%% 2>/dev/null || true'' in
pkg-plist when using PORTDOCS
* Be a little smarter about complaining when .la files are seen in the plist.
Also, point users to the GNOME site for elimintating .la files altogether [2]
* Super-scrub PKGNAME and PORTVERSION for illegal characters [3]
* Check for port versions that go backwards [3]
PR: 66891 [2]
Submitted by: krion [1]
leeym [2] (based on)
eik [3]
* Add a check to see if PLIST_{FILES,DIRS} is defined and pkg-plist exists.
If so, print an error [1]
* Add a check for direct usage of iconv.\d+ and intl.\d+ instead of USE_ICONV
and USE_GETTEXT [1]
* If %%DOCSDIR%% is used in the plist, make sure @dirrm %%DOCSDIR%% is also
present [1]
* Don't flag a missing distinfo as FATAL [2]
Submitted by: krion [1]
eik [2]
* Add some additional checks for USE_* variables included too late [1]
* Add a check for SIZE in distinfo [2]
* Fix a small style nit [2]
* Warn is USE_SIZE is used in a port's Makefile
* Check to see if a port supports WITHOUT_NLS if USE_GETTEXT is defined [3]
Submitted by: eik [1]
krion [2]
Requested by: kris [3]
* Add code for formal master/slave checking rules as defined in ports/64393 [1]:
1. A port is a slave port if and only if MASTERDIR != .CURDIR
2. Slave ports should define MASTERDIR using one of the following lines:
MASTERDIR= ${.CURDIR}/../../<category>/<port>
MASTERDIR= ${.CURDIR}/../<port>
3. Non-slave ports shouldn't define MASTERDIR at all
4. The last line of a slave port's Makefile has to be
.include "${MASTERDIR}/Makefile"
5. The last line of a non-slave ports Makefile must be one of:
.include <bsd.port.mk>
.include <bsd.port.post.mk>
6. slave ports may not include bsd.port(.pre).mk
* Check to make sure MACHINE_ARCH is not defined and make sure it is never
tested directly [2]
* Fix some grammar nits [3]
PR: 64420 [1]
Submitted by: eik [1]
krion [3]
Requested by: kris [2]
* Add dirname and egrep direct command use checks
* Add a missing '?' in checking for text after bsd.port(.post)?.mk [1]
* Add a check to make sure OPTIONS is set before bsd.port.pre.mk
Submitted by: eik [1]
* Fix some grammar nits in portlint.1
* Add some missing options to the summary in portlint.1
* Reorganize some option descriptions in portlint.1
* Add an ENVIRONMENT section describing PL_CVS_IGNORE and PORTSDIR in
portlint.1
* Don't check the MAINTAINER field for direct command use [1]
* Add a new PL_CVS_IGNORE environment variable that allows users to filter
out certain patterns from the CVS files check [2]
* Only warn about CATEGORY problems if the user is in PORTSDIR [3]
* Sync new command macros with recent bsd.port.mk changes
* Correct a regular expression problem when looking for direct command use [4]
PR: 61562 [1]
61449 [2] [3]
Submitted by: Sergey Matveychuk <sem@ciam.ru> [1]
sergei [3]
leeym [4]
* Check to make sure RCS tags begin with capital letters [1]
* Do not look direct command use in .for loops [2]
PR: 60947 [1]
Submitted by: leeym [1]
petef [2]
* Fix up the usage text
* Ignore arguments passed to REINPLACE_CMD so portlint will not complain on
things such as ${REINPLACE_CMD} -e 's,/usr/local,${PREFIX},g' [1]
* Only match libraries installed into lib when looking for .so's [2]
* Try to make the PKGCATEGORY check a little more forgiving to committers
checking single ports [3]
PR: 60608 [1]
60803 [2]
Submitted by: leeym [1] [2] (based on)
dougb [3]
* Correct a typo (-n should be -N) [1]
* Don't check comments for direct command use [2]
Submitted by: pav [1]
Sascha Holzleiter <sascha@root-login.org> [2]
* Check to make sure new ports do not contain PORTEPOCH
* Throw a FATAL error if an additional file exists in the port directory but
not in CVS [2]
* Throw a FATAL error if a file is in CVS but not in the port's directory [2]
* Throw a FATAL error if a file was deleted from CVS but still in the port's
directory [2]
* Warn if a new file contains a non-empty RCS Id [2]
* Add a missing ``if ($verbose)'' [2]
Submitted by: arved [1]
eik [2]
* Add some linenumbers to the whole file search
* Hack the direct command use code some more
* Add a check for the deprecated USE_MESA
* Allow PKGCATEGORY not in CATEGORIES [1]
* Allow %B in pkg-plist, as it has a valid prefix [1]
* Allow simple rm -f, it needs no redirection [1]
* Add portlintgrep.pl, an example on how to use portlint to find certain
portlint problems in the ports tree [2]
Submitted by: dinoex [1]
eik [2]
* Add a check to make sure the last line of a slave port's Makefile contains
an appropriate MASTERDIR include directive [1]
* study() the $whole string to improve performance [1]
* Fix the search for direct command use
* Check for ports that may break INDEX [1]
* Check for GNOME ports that use pre-patch and gnomehack
Submitted by: eik [1]
