1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-11-22 00:35:15 +00:00
freebsd-ports/cad
Dimitry Andric e821fb4570 cad/kicad-devel: fix build with libc++ 19
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes cad/kicad-devel to fail to compile with clang 19 and libc++
19, resulting in errors similar to:

  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nanodbc/nanodbc/nanodbc.cpp:261:25: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
    261 |     auto const n = std::char_traits<NANODBC_SQLCHAR>::length(array);
        |                         ^
  /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
     45 | struct char_traits;
        |        ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nanodbc/nanodbc/nanodbc.cpp:3576:52: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
   3576 |             dsn.name = string(&name[0], &name[std::char_traits<NANODBC_SQLCHAR>::length(name)]);
        |                                                    ^
  /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
     45 | struct char_traits;
        |        ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nanodbc/nanodbc/nanodbc.cpp:3578:49: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
   3578 |                 string(&driver[0], &driver[std::char_traits<NANODBC_SQLCHAR>::length(driver)]);
        |                                                 ^
  /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
     45 | struct char_traits;
        |        ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nanodbc/nanodbc/nanodbc.cpp:3629:54: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
   3629 |             drv.name = string(&descr[0], &descr[std::char_traits<NANODBC_SQLCHAR>::length(descr)]);
        |                                                      ^
  /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
     45 | struct char_traits;
        |        ^

and:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
        |                                          ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/compoundfilereader/compoundfilereader.h:226:21: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
    226 |         utf16string dir;
        |                     ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

and:

  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nlohmann_json/nlohmann/json.hpp:3604:22: error: implicit instantiation of undefined template 'std::char_traits<wxUniChar>'
   3604 | struct char_traits : std::char_traits<T>
        |                      ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nlohmann_json/nlohmann/json.hpp:6289:14: note: in instantiation of template class 'nlohmann::detail::char_traits<wxUniChar>' requested here
   6289 |     typename char_traits<char_type>::int_type get_character()
        |              ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nlohmann_json/nlohmann/json.hpp:6465:22: note: in instantiation of template class 'nlohmann::detail::iterator_input_adapter<wxString::const_iterator>' requested here
   6465 |     BaseInputAdapter base_adapter;
        |                      ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/thirdparty/nlohmann_json/nlohmann/json.hpp:23323:16: note: in instantiation of template class 'nlohmann::detail::wide_string_input_adapter<nlohmann::detail::iterator_input_adapter<wxString::const_iterator>, wxUniChar>' requested here
   23323 |         parser(detail::input_adapter(std::forward<InputType>(i)), cb, allow_exceptions, ignore_comments).parse(true, result);
         |                ^
  /wrkdirs/usr/ports/cad/kicad-devel/work/kicad-6ebd8f46fe24533214b9ed43f1f7e5a4b80dcc71/eeschema/sch_io/easyedapro/sch_io_easyedapro.cpp:209:53: note: in instantiation of function template specialization 'nlohmann::basic_json<>::parse<wxString>' requested here
    209 |                 nlohmann::json js = nlohmann::json::parse( txt.ReadLine() );
        |                                                     ^
  /usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
     45 | struct char_traits;
        |        ^

The first batch of errors can be fixed by providing a simple `length()`
function for the `NANODBC_SQLCHAR const*` type. The second batch can be
fixed by using `std::basic_string<char16_t>` for `utf16string`, and
adjusting the call to `std::basic_string<char16_t>::append`. The third
batch can be fixed by adding a `char_traits` definition specifically for
the `wxUniChar` type.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

PR:		282512
Approved by:	maintainer timeout (2 weeks)
MFH:		2024Q4

(cherry picked from commit 1b22fed46c)
2024-11-17 19:46:11 +01:00
..
abc
admesh
adms
alliance
antimony
apio
appcsxcad
archimedes
astk-client
astk-serveur
atlc
brlcad all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
calculix all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
calculix-ccx
camotics
caneda cad/caneda: update 0.3.1 → 0.4.0 2024-09-30 23:03:18 -07:00
cascade
cascade-compiler
chipvault
Clipper2 cad/Clipper2: Build shared lib 2024-10-13 19:10:40 +02:00
csxcad */*: bump consumers after devel/boost* update 2024-10-03 13:25:14 +03:00
cura
cura-engine
cvc
digital
dinotrace
ecpprog
electric all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
electric-ng
fasm
fdm_materials
feappv
fidocadj
freecad cad/freecad: enable Assembly workbench 2024-10-05 23:36:41 +02:00
freehdl
fritzing
gds3d
gdscpp
gdsreader
gdstk
gdt
geda
gerbv
ghdl
gmsh
gnucap
gplcver
graywolf
gspiceui
gtkwave cad/gtkwave: Update to 3.3.121 2024-10-06 20:30:51 +01:00
horizon-eda
hs-verismith
ifcopenshell */*: bump consumers after devel/boost* update 2024-10-03 13:25:14 +03:00
impact
irsim
iverilog
k40-whisperer
kicad cad/kicad: fix build with libc++ 19 2024-10-07 22:54:46 +02:00
kicad-devel cad/kicad-devel: fix build with libc++ 19 2024-11-17 19:46:11 +01:00
kicad-doc
kicad-library-footprints
kicad-library-footprints-devel
kicad-library-packages3d
kicad-library-packages3d-devel
kicad-library-symbols
kicad-library-symbols-devel
kicad-library-templates
kicad-library-templates-devel
klayout
ktechlab
ldraw
ldview all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
leocad
lepton-eda
libbgcode */*: bump consumers after devel/boost* update 2024-10-03 13:25:14 +03:00
libgdsii
libopencad
librecad
libredwg
librepcb
librnd
logisim
magic all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
meshdev
meshlab
netgen
netgen-lvs
ngspice_rework
nvc cad/nvc: update 1.13.3 → 1.14.0 2024-09-26 01:27:09 -07:00
opencascade */*: bump port revisions of dependents following x265 updates 2024-10-06 13:49:16 +02:00
opencascade740 cad/opencascade740: Fix build with with freetype2 2.13.3 2024-09-24 21:04:41 +02:00
openctm
openfpgaloader
openroad devel/protobuf: Update to 28.2 2024-10-07 22:16:41 +08:00
openscad cad/openscad*: Clean up 2024-10-16 11:38:40 +02:00
openscad-devel cad/openscad*: Clean up 2024-10-16 11:38:40 +02:00
opentimer
openvsp
oregano all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
p5-GDS2
p5-Verilog-Perl
padring
pcb
pcb-rnd
pdnmesh
PrusaSlicer cad/PrusaSlicer: unbreak build with boost-1.85 2024-10-03 13:24:50 +03:00
py-amaranth cad/py-amaranth: Fix build by expanding the range of dependency version 2024-10-04 20:09:29 -07:00
py-cocotb
py-csxcad
py-edalize
py-ezdxf
py-gdspy
py-gdstk
py-gmsh
py-lcapy
py-phidl
py-pyfda
py-pygmsh
py-pymtl
py-pyvcd
py-vunit-hdl
python-gdsii
qcad
qcsxcad
qelectrotech
qflow
qmls
qrouter cad/qrouter: update 1.4.87 → 1.4.88 2024-10-03 02:17:08 -07:00
qspeakers
qucs-s
qucsator
repsnapper
rubygem-gdsii
scotch
silice
solvespace
sp2sp
spice all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
stepcode
stm32flash
sumo
surelog
svlint
svls
sweethome3d
symbiyosys
tkgate
tochnog all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
uhdm
uranium
verilator
verilog-mode.el
veroroute
veryl cad/veryl: Fix runaway builds problem by disabling LTO 2024-09-27 01:38:47 -07:00
xcircuit
xyce
yosys
yosys-ghdl-plugin
yosys-systemverilog
z88 all: drop support for expired FreeBSD 14.0 2024-10-01 20:56:20 +02:00
zcad
Makefile cad/Makefile: Fix 2024-10-13 19:10:32 +02:00