1
0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-16 07:58:04 +00:00
freebsd-ports/x11-fm
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00
..
caja Bump PORTREVISION for ports depending on the canonical version of GCC 2018-12-12 01:35:33 +00:00
catseye-fm
deforaos-browser - Fix LICENSE 2018-11-23 09:30:28 +00:00
dolphin Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
doublecmd x11-fm/doublecmd: Update to 0.8.4 2019-01-09 22:16:20 +00:00
emelfm2
ezfm
filerunner
gentoo
gprename
konqueror Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
krusader2 Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
librfm
libtubo
mucommander x11-fm/mucommander: 2019-01-03 09:36:54 +00:00
nautilus Add INSTALLS_ICONS. 2018-12-15 14:26:55 +00:00
nemo Bump PORTREVISION for ports depending on the canonical version of GCC 2018-12-12 01:35:33 +00:00
pcmanfm x11/libfm, x11-fm/pcmanfm: update and flavorize both. 2019-01-07 15:08:08 +00:00
pcmanfm-qt Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
pcmanfmqt-l10n Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
qtfm Mark QT4 ports/functionality for removal on 2019-03-15 2018-12-02 15:41:47 +00:00
rodent
rox-filer
rox-mime-editor
rox-session - Fix LICENSE 2018-12-11 13:33:40 +00:00
sunflower
sushi Bump PORTREVISION for ports depending on the canonical version of GCC 2018-12-12 01:35:33 +00:00
tdfsb
thunar
thunar-vfs
twander
ultracopier Fix Qt5 symbol version scripts to put the catch-all clause first. When 2019-01-16 11:13:44 +00:00
wcmcommander Change cmake default behaviour to outsource. 2018-12-25 20:25:39 +00:00
worker Bump PORTREVISION for ports depending on the canonical version of GCC 2018-12-12 01:35:33 +00:00
xcruise
xdiskusage
xfe
xplore
Makefile Remove KDE4, part 5 2018-12-31 17:55:45 +00:00