1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-10-18 19:49:40 +00:00
freebsd-ports/sysutils/vzvol/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

52 lines
1.4 KiB
Makefile

# $FreeBSD$
PORTNAME= vzvol
DISTVERSIONPREFIX= v
DISTVERSION= 0.7.0
PORTREVISION= 1
CATEGORIES= sysutils
MAINTAINER= rainbow@sanitylinux.org
COMMENT= Feature-rich ZFS zvol management tool
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
GROUPS= operator
USE_GITHUB= yes
GH_ACCOUNT= RainbowHackerHorse
NO_BUILD= yes
NO_ARCH= yes
PORTDOCS= README.md CONTRIBUTORS
OPTIONS_DEFINE= DOCS PROGRESS VIRTUALBOX
OPTIONS_GROUP= FILESYSTEMS
OPTIONS_GROUP_FILESYSTEMS= EXT XFS
OPTIONS_DEFAULT= EXT PROGRESS VIRTUALBOX XFS
EXT_RUN_DEPENDS= mke2fs:sysutils/e2fsprogs
PROGRESS_RUN_DEPENDS= pv:sysutils/pv
VIRTUALBOX_RUN_DEPENDS= VBoxManage:emulators/virtualbox-ose
XFS_RUN_DEPENDS= mkfs.xfs:sysutils/xfsprogs
EXT_DESC= Install support for ext2, ext3, and ext4
PROGRESS_DESC= Enables progress bars for import
VIRTUALBOX_DESC= Support .VMDK creation with VirtualBox tools
XFS_DESC= Install support for XFS Filesystem
do-install:
${INSTALL_MAN} ${WRKSRC}/man/freebsd/vzvol.8 ${STAGEDIR}${PREFIX}/man/man8/
${INSTALL_SCRIPT} ${WRKSRC}/bin/vzvol ${STAGEDIR}${PREFIX}/sbin
.for dir in shared freebsd linux
@${MKDIR} ${STAGEDIR}${PREFIX}/lib/vzvol/lib/${dir}
${INSTALL_SCRIPT} ${WRKSRC}/lib/${dir}/* ${STAGEDIR}${PREFIX}/lib/vzvol/lib/${dir}
.endfor
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
${INSTALL_DATA} ${WRKSRC}/docs/* ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>