1
0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-27 10:03:20 +00:00
freebsd-ports/sysutils/fcron/files/patch-fileconf.c
Eygene Ryabinkin 4839c29cd1 sysutils/fcron: fixup default argument promotion
When mode_t is char- or short-like, it will be promoted to the pure
int when it is passed as the variable argument [1], so we should pass
'int' to the va_arg.

I had also eliminated fflush for the stream opened read-only, since
it will always fail and there is no need to flush read-only streams.

[1] http://c-faq.com/~scs/cclass/int/sx11c.html

Feature safe: yes
PR: 152304
2011-09-25 07:24:25 +00:00

16 lines
508 B
C

We don't need to fflush the file, since it is opened read-only.
--- fileconf.c.orig 2011-07-18 19:55:28.726082293 +0400
+++ fileconf.c 2011-07-18 19:55:37.988079816 +0400
@@ -264,10 +264,6 @@
cf->cf_next = file_base;
file_base = cf;
- /* don't close as underlying fd may still be used by calling function */
- if (fflush(file) != 0)
- error_e("could not fflush() file_name");
-
free(default_line.cl_runas);
free(default_line.cl_mailto);
free(default_line.cl_tz);