Dimitry Andric 3822416493 java/openjdk*: work around UB in markOopDesc, fix builds with clang 13 ... During an exp-run for llvm 13 (see bug 258209), it turned out that java/openjdk11 through openjdk13 fail to build with clang 13: === Output from failing command(s) repeated here === * For target jdk__packages_attribute.done: These crashes are all caused by the markOop/markOopDesc classes, which are used to keep track of objects, and which are 'marked' using the low few bits. (See https://github.com/openjdk/jdk13u/blob/master/src/hotspot/share/oops/markOop.hpp ). After some laborious bisecting, I found out that these crashes start occuring after the upstream commit https://github.com /llvm/llvm-project/commit/16d03818412 (Return "[CGCall] Annotate this argument with alignment"). What happens afterwards, is that clang considers the "this" pointer to always be aligned to the alignment of the actual object, and then masking or adding a few low bits is not working as expected. The reason openjdk14 and higher work fine with clang 13, and don't crash similarly, is that the OpenJDK people completely redid the markOop/markOopDesc classes in ae5615c614 ("8229258: Rework markOop and markOopDesc into a simpler mark word value carrier"). E.g, the markOopDesc class was renamed to markWord, and *stores* a pointer-like value instead of *being* a pointer-like value. This is a much safer way of handling things. However, this upstream commit is *very* large, as are a few of its follow-ups, which is probably the reason why it has not been backported to JDKs <= 13. I tried manually backporting it, but got lost in many nasty patch conflicts and problems. As a workaround, build openjdk8 through 13 with clang12 from the devel/llvm12 port, for the time being. In addition, allow openjdk14 through 17 to be built with clang 13, by adding -Wno-unused-but-set-parameter to the compilation flags. PR: 258954 Approved by: maintainer timeout (2 weeks) MFH: 2021Q4		2021-10-16 14:22:03 +02:00
..
files
distinfo
Makefile	java/openjdk*: work around UB in markOopDesc, fix builds with clang 13	2021-10-16 14:22:03 +02:00
pkg-descr
pkg-message