1
0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-28 10:08:24 +00:00
freebsd-ports/security/fwbuilder/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

84 lines
2.2 KiB
Makefile

# Created by: Roman Shterenzon <roman@xpert.com>
# $FreeBSD$
PORTNAME= fwbuilder
PORTVERSION= 5.3.7
PORTREVISION= 2
DISTVERSIONPREFIX= v
CATEGORIES= security
MAINTAINER= cy@FreeBSD.org
COMMENT= Firewall Builder GUI and policy compilers
BROKEN_powerpc64= fails to configure: libz library not found
LIB_DEPENDS= libxslt.so:textproc/libxslt \
libnetsnmp.so:net-mgmt/net-snmp
OPTIONS_DEFINE= DOCS
.if defined(PKGNAMESUFFIX) && ${PKGNAMESUFFIX} == -devel
CONFLICTS= fwbuilder-[234].* fwbuilder-devel-[234].* \
libfwbuilder-[234].* libfwbuilder-devel-[234].*
.else
CONFLICTS= fwbuilder-[234].* fwbuilder-devel-* \
libfwbuilder-[234].* libfwbuilder-devel-*
.endif
USES= autoreconf:build gmake libtool qmake:no_configure qt:5 ssl
USE_GITHUB= yes
PLIST_SUB= PORTVERSION=${PORTVERSION}
USE_QT= buildtools gui \
linguist_build \
printsupport \
qmake_build \
svg \
xml
QTDIR?= ${PREFIX}
GNU_CONFIGURE= yes
CONFIGURE_ENV= QMAKESPEC=${LOCALBASE}/share/qt/mkspecs/freebsd-g++ \
INSTALL_ROOT=${STAGEDIR}
CPPFLAGS+= -I${LOCALBASE}/include
CXXFLAGS+= -Wno-reserved-user-defined-literal
LDFLAGS+= -L${LOCALBASE}/lib
CONFIGURE_ARGS= --with-docdir=${DOCSDIR} --with-qtdir=${QTDIR} \
--prefix=${PREFIX}
MAKE_ARGS+= QTDIR="${QTDIR}" \
QMAKESPEC=${LOCALBASE}/share/qt/mkspecs/freebsd-g++
MAKE_ENV= INSTALL_ROOT=${STAGEDIR} CCACHE_DISABLE=yes
USE_LDCONFIG= yes
PLIST_SUB+= PORTVERSION="${PORTVERSION}"
PORTDOCS= *
.include <bsd.port.options.mk>
.if !exists (/usr/bin/rcs)
# IMPORTANT: Newer versions of rcs will NOT work with fwbuilder.
RUN_DEPENDS+= rcs:devel/rcs57
.endif
.if empty(PORT_OPTIONS:MDOCS)
BROKEN= DOCS must be enabled in this port
.endif
post-patch:
@${REINPLACE_CMD} '/^\.\/configure/d' ${WRKSRC}/autogen.sh
pre-configure:
(cd ${WRKSRC} && ./autogen.sh)
# Work around an esoteric build issue related to the QT5 build infrastructure
post-configure:
@find ${WRKSRC} -name Makefile | ${XARGS} ${REINPLACE_CMD} 's|-isystem /usr/include||g'
post-install:
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/fwbuilder
@${ECHO} If you are upgrading from a previous version of fwbuilder,
@${ECHO} please make sure to backup your fwbuilder database files
@${ECHO} prior to invoking fwbuilder for the first time.
.include <bsd.port.mk>